simplesamlphp / saml2

src/SAML2/Certificate/KeyLoader.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SAML2\Certificate\Exception\InvalidCertificateStructureException;
 use SAML2\Certificate\Exception\NoKeysFoundException;
 use SAML2\Configuration\CertificateProvider;
-use SAML2\Exception\InvalidArgumentException;
 use SAML2\Utilities\Certificate;
 use SAML2\Utilities\File;
 

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
                 $key = new Key($keyData);
             }
 
-            if ($usage !== null  && !$key->canBeUsedFor($usage)) {
+            if ($usage !== null && !$key->canBeUsedFor($usage)) {
                 continue;
             }
 

src/SAML2/Configuration/ServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     public function getPrivateKey(string $name, bool $required = false)
     {
         $privateKeys = $this->get('privateKeys');
-        $key         = array_filter($privateKeys, function (PrivateKey $key) use ($name) {
+        $key         = array_filter($privateKeys, function(PrivateKey $key) use ($name) {
             return $key->getName() === $name;
         });
 

src/SAML2/Configuration/IdentityProvider.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
     public function getPrivateKey(string $name, bool $required = false)
     {
         $privateKeys = $this->get('privateKeys');
-        $key = array_filter($privateKeys, function (PrivateKey $key) use ($name) {
+        $key = array_filter($privateKeys, function(PrivateKey $key) use ($name) {
             return $key->getName() === $name;
         });
 

src/SAML2/Configuration/SimpleSAMLConverter.php

Spacing +6 added lines, -6 removed lines

@@ -57,20 +57,20 @@
 
         // ported from
         // https://github.com/simplesamlphp/simplesamlphp/blob/3d735912342767d391297cc5e13272a76730aca0/lib/SimpleSAML/Configuration.php#L1092
-        if ($configuration->hasValue($prefix . 'keys')) {
-            $extracted['keys'] = $configuration->getArray($prefix . 'keys');
+        if ($configuration->hasValue($prefix.'keys')) {
+            $extracted['keys'] = $configuration->getArray($prefix.'keys');
         }
 
         // ported from
         // https://github.com/simplesamlphp/simplesamlphp/blob/3d735912342767d391297cc5e13272a76730aca0/lib/SimpleSAML/Configuration.php#L1108
-        if ($configuration->hasValue($prefix . 'certData')) {
-            $extracted['certificateData'] = $configuration->getString($prefix . 'certData');
+        if ($configuration->hasValue($prefix.'certData')) {
+            $extracted['certificateData'] = $configuration->getString($prefix.'certData');
         }
 
         // ported from
         // https://github.com/simplesamlphp/simplesamlphp/blob/3d735912342767d391297cc5e13272a76730aca0/lib/SimpleSAML/Configuration.php#L1119
-        if ($configuration->hasValue($prefix . 'certificate')) {
-            $extracted['certificateData'] = $configuration->getString($prefix . 'certificate');
+        if ($configuration->hasValue($prefix.'certificate')) {
+            $extracted['certificateData'] = $configuration->getString($prefix.'certificate');
         }
 
         $extracted['assertionEncryptionEnabled'] = $configuration->getBoolean('assertion.encryption', false);

src/SAML2/XML/md/EndpointType.php

Spacing +7 added lines, -7 removed lines

@@ -54,12 +54,12 @@ 
         }
 
         if (!$xml->hasAttribute('Binding')) {
-            throw new \Exception('Missing Binding on ' . $xml->tagName);
+            throw new \Exception('Missing Binding on '.$xml->tagName);
         }
         $this->Binding = $xml->getAttribute('Binding');
 
         if (!$xml->hasAttribute('Location')) {
-            throw new \Exception('Missing Location on ' . $xml->tagName);
+            throw new \Exception('Missing Location on '.$xml->tagName);
         }
         $this->Location = $xml->getAttribute('Location');
 
@@ -71,7 +71,7 @@ 
             if ($a->namespaceURI === null) {
                 continue; /* Not namespace-qualified -- skip. */
             }
-            $fullName = '{' . $a->namespaceURI . '}' . $a->localName;
+            $fullName = '{'.$a->namespaceURI.'}'.$a->localName;
             $this->attributes[$fullName] = [
                 'qualifiedName' => $a->nodeName,
                 'namespaceURI' => $a->namespaceURI,
@@ -89,7 +89,7 @@ 
      */
     public function hasAttributeNS(string $namespaceURI, string $localName)
     {
-        $fullName = '{' . $namespaceURI . '}' . $localName;
+        $fullName = '{'.$namespaceURI.'}'.$localName;
 
         return isset($this->attributes[$fullName]);
     }
@@ -103,7 +103,7 @@ 
      */
     public function getAttributeNS(string $namespaceURI, string $localName)
     {
-        $fullName = '{' . $namespaceURI . '}' . $localName;
+        $fullName = '{'.$namespaceURI.'}'.$localName;
         if (!isset($this->attributes[$fullName])) {
             return '';
         }
@@ -127,7 +127,7 @@ 
         }
         $localName = $name[1];
 
-        $fullName = '{' . $namespaceURI . '}' . $localName;
+        $fullName = '{'.$namespaceURI.'}'.$localName;
         $this->attributes[$fullName] = [
             'qualifiedName' => $qualifiedName,
             'namespaceURI' => $namespaceURI,
@@ -143,7 +143,7 @@ 
      */
     public function removeAttributeNS(string $namespaceURI, string $localName)
     {
-        $fullName = '{' . $namespaceURI . '}' . $localName;
+        $fullName = '{'.$namespaceURI.'}'.$localName;
         unset($this->attributes[$fullName]);
     }
 

src/SAML2/XML/md/ContactPerson.php

Spacing +2 added lines, -2 removed lines

@@ -115,7 +115,7 @@ 
      */
     private static function getStringElements(\DOMElement $parent, string $name)
     {
-        $e = Utils::xpQuery($parent, './saml_metadata:' . $name);
+        $e = Utils::xpQuery($parent, './saml_metadata:'.$name);
 
         $ret = [];
         foreach ($e as $i) {
@@ -140,7 +140,7 @@ 
             return null;
         }
         if (count($e) > 1) {
-            throw new \Exception('More than one ' . $name . ' in ' . $parent->tagName);
+            throw new \Exception('More than one '.$name.' in '.$parent->tagName);
         }
 
         return $e[0];

src/SAML2/SignedElementHelper.php

Spacing +2 added lines, -2 removed lines

@@ -175,8 +175,8 @@
         $ret = [];
         foreach ($this->certificates as $cert) {
             /* Construct a PEM formatted certificate */
-            $pemCert = "-----BEGIN CERTIFICATE-----\n" .
-                chunk_split($cert, 64) .
+            $pemCert = "-----BEGIN CERTIFICATE-----\n".
+                chunk_split($cert, 64).
                 "-----END CERTIFICATE-----\n";
 
             /* Extract the public key from the certificate for validation. */

src/SAML2/HTTPArtifact.php

Spacing +5 added lines, -5 removed lines

@@ -40,7 +40,7 @@ 
         }
 
         $generatedId = pack('H*', bin2hex(openssl_random_pseudo_bytes(20)));
-        $artifact = base64_encode("\x00\x04\x00\x00" . sha1($message->getIssuer(), true) . $generatedId) ;
+        $artifact = base64_encode("\x00\x04\x00\x00".sha1($message->getIssuer(), true).$generatedId);
         $artifactData = $message->toUnsignedXML();
         $artifactDataString = $artifactData->ownerDocument->saveXML($artifactData);
 
@@ -82,7 +82,7 @@ 
     {
         if (array_key_exists('SAMLart', $_REQUEST)) {
             $artifact = base64_decode($_REQUEST['SAMLart']);
-            $endpointIndex =  bin2hex(substr($artifact, 2, 2));
+            $endpointIndex = bin2hex(substr($artifact, 2, 2));
             $sourceId = bin2hex(substr($artifact, 4, 20));
         } else {
             throw new \Exception('Missing SAMLart parameter.');
@@ -93,12 +93,12 @@ 
         $idpMetadata = $metadataHandler->getMetaDataConfigForSha1($sourceId, 'saml20-idp-remote');
 
         if ($idpMetadata === null) {
-            throw new \Exception('No metadata found for remote provider with SHA1 ID: ' . var_export($sourceId, true));
+            throw new \Exception('No metadata found for remote provider with SHA1 ID: '.var_export($sourceId, true));
         }
 
         $endpoint = null;
         foreach ($idpMetadata->getEndpoints('ArtifactResolutionService') as $ep) {
-            if ($ep['index'] ===  hexdec($endpointIndex)) {
+            if ($ep['index'] === hexdec($endpointIndex)) {
                 $endpoint = $ep;
                 break;
             }
@@ -108,7 +108,7 @@ 
             throw new \Exception('No ArtifactResolutionService with the correct index.');
         }
 
-        Utils::getContainer()->getLogger()->debug("ArtifactResolutionService endpoint being used is := " . $endpoint['Location']);
+        Utils::getContainer()->getLogger()->debug("ArtifactResolutionService endpoint being used is := ".$endpoint['Location']);
 
         //Construct the ArtifactResolve Request
         $ar = new ArtifactResolve();

src/SAML2/SOAPClient.php

Spacing +7 added lines, -7 removed lines

@@ -55,8 +55,8 @@ 
             $privateKey = \SimpleSAML\Utils\Crypto::loadPrivateKey($srcMetadata);
             $publicKey = \SimpleSAML\Utils\Crypto::loadPublicKey($srcMetadata);
             if ($privateKey !== null && $publicKey !== null && isset($publicKey['PEM'])) {
-                $keyCertData = $privateKey['PEM'] . $publicKey['PEM'];
-                $file = \SimpleSAML\Utils\System::getTempDir() . '/' . sha1($keyCertData) . '.pem';
+                $keyCertData = $privateKey['PEM'].$publicKey['PEM'];
+                $file = \SimpleSAML\Utils\System::getTempDir().'/'.sha1($keyCertData).'.pem';
                 if (!file_exists($file)) {
                     \SimpleSAML\Utils\System::writeFile($file, $keyCertData);
                 }
@@ -75,11 +75,11 @@ 
                 if ($key['type'] !== 'X509Certificate') {
                     continue;
                 }
-                $certData .= "-----BEGIN CERTIFICATE-----\n" .
-                    chunk_split($key['X509Certificate'], 64) .
+                $certData .= "-----BEGIN CERTIFICATE-----\n".
+                    chunk_split($key['X509Certificate'], 64).
                     "-----END CERTIFICATE-----\n";
             }
-            $peerCertFile = \SimpleSAML\Utils\System::getTempDir() . '/' . sha1($certData) . '.pem';
+            $peerCertFile = \SimpleSAML\Utils\System::getTempDir().'/'.sha1($certData).'.pem';
             if (!file_exists($peerCertFile)) {
                 \SimpleSAML\Utils\System::writeFile($peerCertFile, $certData);
             }
@@ -116,7 +116,7 @@ 
 
         // Add soap-envelopes
         $request = $msg->toSignedXML();
-        $request = self::START_SOAP_ENVELOPE . $request->ownerDocument->saveXML($request) . self::END_SOAP_ENVELOPE;
+        $request = self::START_SOAP_ENVELOPE.$request->ownerDocument->saveXML($request).self::END_SOAP_ENVELOPE;
 
         Utils::getContainer()->debugMessage($request, 'out');
 
@@ -239,7 +239,7 @@ 
         // There is a fault element but we haven't found out what the fault string is
         $soapFaultString = "Unknown fault string found";
         // find out the fault string
-        $faultStringElement =   Utils::xpQuery($soapFaultElement, './soap-env:faultstring') ;
+        $faultStringElement = Utils::xpQuery($soapFaultElement, './soap-env:faultstring');
         if (!empty($faultStringElement)) {
             return $faultStringElement[0]->textContent;
         }