silverstripe / silverstripe-translatable

code/controller/TranslatableCMSMainExtension.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use SilverStripe\Forms\FormAction;
 use SilverStripe\Forms\HiddenField;
 use SilverStripe\Forms\LiteralField;
-use SilverStripe\Forms\HTMLEditor\HTMLEditorConfig;
 use SilverStripe\i18n\i18n;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\Security\Member;

code/forms/TemporaryInlineFormAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
     /**
      * @param array $properties
-     * @return HTMLText
+     * @return DBField
      */
     public function Field($properties = [])
     {

code/model/Translatable.php

Doc Comments +3 added lines, -6 removed lines

@@ -326,7 +326,7 @@ 
      * any database records (like pages), as this locale will be attached
      * to all new records.
      *
-     * @param $locale String
+     * @param string $locale String
      * @throws InvalidArgumentException if the locale is not valid
      */
     public static function set_default_locale($locale)
@@ -360,7 +360,6 @@ 
      * to "auto-filter" all SELECT queries by this language.
      * See {@link disable_locale_filter()} on how to override this behaviour temporarily.
      *
-     * @param string $lang New reading language.
      */
     public static function set_current_locale($locale)
     {
@@ -408,8 +407,6 @@ 
      * @param string $join A single join clause.  This can be used for filtering, only 1
      *               instance of each DataObject will be returned.
      * @param string $limit A limit expression to be inserted into the LIMIT clause.
-     * @param string $containerClass The container class to return the results in.
-     * @param string $having A filter to be inserted into the HAVING clause.
      * @return mixed The objects matching the conditions.
      */
     public static function get_by_locale($class, $locale, $filter = '', $sort = '', $join = "", $limit = "")
@@ -596,7 +593,7 @@ 
      * Check if a given SQLSelect filters on the Locale field
      *
      * @param SQLSelect $query
-     * @return boolean
+     * @return boolean|null
      */
     protected function filtersOnLocale($query)
     {
@@ -1640,7 +1637,7 @@ 
     }
 
     /**
-     * @return boolean
+     * @return null|false
      */
     public function canEdit($member)
     {

Unused Use Statements -6 removed lines

@@ -10,14 +10,12 @@ 
 use SilverStripe\Control\Controller;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
-use SilverStripe\Core\ClassInfo;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\HeaderField;
 use SilverStripe\Forms\HiddenField;
 use SilverStripe\Forms\LiteralField;
 use SilverStripe\Forms\Tab;
 use SilverStripe\i18n\i18n;
-use SilverStripe\i18n\Data\Intl\IntlLocales;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataExtension;
 use SilverStripe\ORM\DataObject;
@@ -33,10 +31,6 @@ 
 use SilverStripe\Translatable\Forms\LanguageDropdownField;
 use SilverStripe\Translatable\Model\Translatable;
 use SilverStripe\Versioned\Versioned;
-
-
-
-
 use SilverStripe\Translatable\Forms\TemporaryInlineFormAction;
 
 /**

tests/unit/TranslatableTest.php

Doc Comments +6 added lines

@@ -84,6 +84,9 @@ 
         parent::tearDown();
     }
 
+    /**
+     * @param string $message
+     */
     protected function assertArrayEqualsAfterSort($expected, $actual, $message = null)
     {
         sort($expected);
@@ -274,6 +277,9 @@ 
         );
     }
 
+    /**
+     * @param DataObject|null $node
+     */
     public function assertClass($class, $node)
     {
         $this->assertNotNull($node);

Unused Use Statements -3 removed lines

@@ -12,19 +12,16 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use SilverStripe\Dev\FunctionalTest;
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\Forms\DropdownField;
 use SilverStripe\Forms\LookupField;
 use SilverStripe\Forms\ReadonlyField;
 use SilverStripe\Forms\TextField;
-use SilverStripe\ORM\DataExtension;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
 use SilverStripe\SiteConfig\SiteConfig;
 use SilverStripe\Translatable\Model\Translatable;
 use SilverStripe\Translatable\Tests\Stub\EveryoneCanPublish;
-use SilverStripe\Translatable\Tests\Stub\TranslatableTestData;
 use SilverStripe\Translatable\Tests\Stub\TranslatableTestDataObject;
 use SilverStripe\Translatable\Tests\Stub\TranslatableTestExtension;
 use SilverStripe\Translatable\Tests\Stub\TranslatableTestOneByLocaleDataObject;