SubsitesVirtualPageTest::tearDown() - Code Metrics - Inspection of "Merge branch '2.3'" - silverstripe/silverstripe-subsites - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 483a86...be3bca )

by Robbie

created 2019-06-24 22:02 UTC

SubsitesVirtualPageTest::tearDown() A

↳ Parent: SubsitesVirtualPageTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	4
rs	10

<?php

namespace SilverStripe\Subsites\Tests;

use Page;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\Assets\File;
use SilverStripe\Assets\Filesystem;
use SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Control\Director;
use SilverStripe\Core\Config\Config;
use SilverStripe\ORM\DB;
use SilverStripe\Subsites\Model\Subsite;
use SilverStripe\Subsites\Pages\SubsitesVirtualPage;
use SilverStripe\Versioned\Versioned;

class SubsitesVirtualPageTest extends BaseSubsiteTest
{
    protected static $fixture_file = [
        'SubsiteTest.yml',
        'SubsitesVirtualPageTest.yml',
    ];

    protected function setUp()
    {
        parent::setUp();

        Config::modify()->set(Subsite::class, 'write_hostmap', false);

        // Set backend root to /DataDifferencerTest
        TestAssetStore::activate('SubsitesVirtualPageTest');

        // Create a test files for each of the fixture references
        $file = $this->objFromFixture(File::class, 'file1');
        $page = $this->objFromFixture(SiteTree::class, 'page1');
        $fromPath = __DIR__ . '/testscript-test-file.pdf';
        $destPath = TestAssetStore::getLocalPath($file);
        Filesystem::makeFolder(dirname($destPath));
        copy($fromPath, $destPath);

        // Hack in site link tracking after the fact
        $page->Content = '<p><img src="' . $file->getURL() . '" data-fileid="' . $file->ID . '" /></p>';
        $page->write();
    }

    public function tearDown()
    {
        TestAssetStore::reset();
        parent::tearDown();
    }

    // Attempt to bring main:linky to subsite2:linky
    public function testVirtualPageFromAnotherSubsite()
    {
        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');

        Subsite::changeSubsite($subsite->ID);
        Subsite::$disable_subsite_filter = false;

        $linky = $this->objFromFixture(Page::class, 'linky');

        $svp = new SubsitesVirtualPage();
        $svp->CopyContentFromID = $linky->ID;
        $svp->SubsiteID = $subsite->ID;
        $svp->URLSegment = 'linky';

        $svp->write();

        $this->assertEquals($svp->SubsiteID, $subsite->ID);

        $this->assertEquals($svp->Title, $linky->Title);

    }

    public function testFileLinkRewritingOnVirtualPages()
    {
        $this->markTestSkipped('File handling needs update');
        // File setup
        $this->logInWithPermission('ADMIN');
        touch(Director::baseFolder() . '/assets/testscript-test-file.pdf');

        // Publish the source page
        $page = $this->objFromFixture(SiteTree::class, 'page1');
        $this->assertTrue($page->publishSingle());

        // Create a virtual page from it, and publish that
        $svp = new SubsitesVirtualPage();
        $svp->CopyContentFromID = $page->ID;
        $svp->write();
        $svp->publishSingle();

        // Rename the file
        $file = $this->objFromFixture(File::class, 'file1');
        $file->Name = 'renamed-test-file.pdf';
        $file->write();

        // Verify that the draft and publish virtual pages both have the corrected link
        $this->assertContains(
            '<img src="/assets/SubsitesVirtualPageTest/464dedb70a/renamed-test-file.pdf"',
            DB::query("SELECT \"Content\" FROM \"SiteTree\" WHERE \"ID\" = $svp->ID")->value()
        );
        $this->assertContains(
            '<img src="/assets/SubsitesVirtualPageTest/464dedb70a/renamed-test-file.pdf"',
            DB::query("SELECT \"Content\" FROM \"SiteTree_Live\" WHERE \"ID\" = $svp->ID")->value()
        );
    }

    public function testSubsiteVirtualPagesArentInappropriatelyPublished()
    {
        $this->markTestSkipped('Needs some update or refactoring');
        // Fixture
        $p = new Page();
        $p->Content = 'test content';
        $p->write();
        $vp = new SubsitesVirtualPage();
        $vp->CopyContentFromID = $p->ID;
        $vp->write();

        // VP is oragne
        $this->assertTrue($vp->IsAddedToStage);

        // VP is still orange after we publish
        $p->publishSingle();
        $this->fixVersionNumberCache($vp);
        $this->assertTrue($vp->IsAddedToStage);

        // A new VP created after P's initial construction
        $vp2 = new SubsitesVirtualPage();
        $vp2->CopyContentFromID = $p->ID;
        $vp2->write();
        $this->assertTrue($vp2->IsAddedToStage);

        // Also remains orange after a republish
        $p->Content = 'new content';
        $p->write();
        $p->publishSingle();
        $this->fixVersionNumberCache($vp2);
        $this->assertTrue($vp2->IsAddedToStage);

        // VP is now published
        $vp->publishSingle();

        $this->fixVersionNumberCache($vp);
        $this->assertTrue($vp->ExistsOnLive);
        $this->assertFalse($vp->IsModifiedOnStage);

        // P edited, VP and P both go green
        $p->Content = 'third content';
        $p->write();

        $this->fixVersionNumberCache($vp, $p);
        $this->assertTrue($p->IsModifiedOnStage);
        $this->assertTrue($vp->IsModifiedOnStage);

        // Publish, VP goes black
        $p->publishSingle();
        $this->fixVersionNumberCache($vp);
        $this->assertTrue($vp->ExistsOnLive);
        $this->assertFalse($vp->IsModifiedOnStage);
    }

    /**
     * This test ensures published Subsites Virtual Pages immediately reflect updates
     * to their published target pages. Note - this has to happen when the virtual page
     * is in a different subsite to the page you are editing and republishing,
     * otherwise the test will pass falsely due to current subsite ID being the same.
     */
    public function testPublishedSubsiteVirtualPagesUpdateIfTargetPageUpdates()
    {
        $this->markTestSkipped('Needs some update or refactoring');

        // create page
        $p = new Page();
        $p->Content = 'Content';
        $p->Title = 'Title';
        $p->writeToStage('Stage');
        $p->copyVersionToStage('Stage', 'Live');
        $this->assertTrue($p->ExistsOnLive);

        // change to subsite
        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');
        Subsite::changeSubsite($subsite->ID);
        Subsite::$disable_subsite_filter = false;

        // create svp in subsite
        $svp = new SubsitesVirtualPage();
        $svp->CopyContentFromID = $p->ID;
        $svp->write();
        $svp->writeToStage('Stage');
        $svp->copyVersionToStage('Stage', 'Live');
        $this->assertEquals($svp->SubsiteID, $subsite->ID);
        $this->assertTrue($svp->ExistsOnLive);

        // change back to original subsite ("Main site")
        Subsite::changeSubsite(0);

        // update original page
        $p->Title = 'New Title';
        // "save & publish"
        $p->writeToStage('Stage');
        $p->copyVersionToStage('Stage', 'Live');
        $this->assertNotEquals($p->SubsiteID, $subsite->ID);

        // reload SVP from database
        // can't use DO::get by id because caches.
        $svpdb = $svp->get()->byID($svp->ID);

        // ensure title changed
        $this->assertEquals($svpdb->Title, $p->Title);
    }

    public function testUnpublishingParentPageUnpublishesSubsiteVirtualPages()
    {
        $this->markTestIncomplete('@todo fix this test');

        Config::modify()->set('StaticPublisher', 'disable_realtime', true);

        // Go to main site, get parent page
        $subsite = $this->objFromFixture(Subsite::class, 'main');
        Subsite::changeSubsite($subsite->ID);
        $page = $this->objFromFixture('Page', 'importantpage');

        // Create two SVPs on other subsites
        $subsite = $this->objFromFixture(Subsite::class, 'subsite1');
        Subsite::changeSubsite($subsite->ID);
        $vp1 = new SubsitesVirtualPage();
        $vp1->CopyContentFromID = $page->ID;
        $vp1->write();
        $vp1->copyVersionToStage(Versioned::DRAFT, Versioned::LIVE);

        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');
        Subsite::changeSubsite($subsite->ID);
        $vp2 = new SubsitesVirtualPage();
        $vp2->CopyContentFromID = $page->ID;
        $vp2->write();
        $vp2->copyVersionToStage(Versioned::DRAFT, Versioned::LIVE);

        // Switch back to main site, unpublish source
        $subsite = $this->objFromFixture(Subsite::class, 'main');
        Subsite::changeSubsite($subsite->ID);
        $page = $this->objFromFixture('Page', 'importantpage');
        $page->doUnpublish();

        Subsite::changeSubsite($vp1->SubsiteID);
        $onLive = Versioned::get_one_by_stage(SubsitesVirtualPage::class, 'Live', '"SiteTree_Live"."ID" = ' . $vp1->ID);
        $this->assertNull($onLive, 'SVP has been removed from live');

        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');

        Subsite::changeSubsite($vp2->SubsiteID);
        $onLive = Versioned::get_one_by_stage(SubsitesVirtualPage::class, 'Live', '"SiteTree_Live"."ID" = ' . $vp2->ID);
        $this->assertNull($onLive, 'SVP has been removed from live');
    }

    /**
     * Similar to {@link SiteTreeSubsitesTest->testTwoPagesWithSameURLOnDifferentSubsites()}
     * and {@link SiteTreeSubsitesTest->testPagesInDifferentSubsitesCanShareURLSegment()}.
     */
    public function testSubsiteVirtualPageCanHaveSameUrlsegmentAsOtherSubsite()
    {
        $this->markTestIncomplete('@todo fix this test');

        $subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
        $subsite2 = $this->objFromFixture(Subsite::class, 'subsite2');
        Subsite::changeSubsite($subsite1->ID);

        $subsite1Page = $this->objFromFixture(Page::class, 'subsite1_staff');
        $subsite1Page->URLSegment = 'staff';
        $subsite1Page->write();

        // saving on subsite1, and linking to subsite1
        $subsite1Vp = new SubsitesVirtualPage();
        $subsite1Vp->CopyContentFromID = $subsite1Page->ID;
        $subsite1Vp->SubsiteID = $subsite1->ID;
        $subsite1Vp->write();

        $this->assertNotEquals(
            $subsite1Vp->URLSegment,
            $subsite1Page->URLSegment,
            "Doesn't allow explicit URLSegment overrides when already existing in same subsite"
        );

        //Change to subsite 2
        Subsite::changeSubsite($subsite2->ID);

        // saving in subsite2 (which already has a page with URLSegment 'contact-us'),
        // but linking to a page in subsite1
        $subsite2Vp = new SubsitesVirtualPage();
        $subsite2Vp->CopyContentFromID = $subsite1Page->ID;
        $subsite2Vp->SubsiteID = $subsite2->ID;
        $subsite2Vp->write();
        $this->assertEquals(
            $subsite2Vp->URLSegment,
            $subsite1Page->URLSegment,
            'Does allow explicit URLSegment overrides when only existing in a different subsite'
        );

        // When changing subsites and re-saving this page, it doesn't trigger a change
        Subsite::changeSubsite($subsite1->ID);
        $subsite1Page->write();
        $subsite2Vp->write();
        $this->assertEquals(
            $subsite2Vp->URLSegment,
            $subsite1Page->URLSegment,
            "SubsiteVirtualPage doesn't change urls when being written in another subsite"
        );
    }

    protected function fixVersionNumberCache($page)
    {
        $pages = func_get_args();
        foreach ($pages as $p) {
            Versioned::prepopulate_versionnumber_cache(SiteTree::class, 'Stage', [$p->ID]);
            Versioned::prepopulate_versionnumber_cache(SiteTree::class, 'Live', [$p->ID]);
        }
    }

    public function testValidURLSegmentWithUniquePageAndNestedURLs()
    {
        SiteTree::config()->set('nested_urls', true);

        $newPage = new SubsitesVirtualPage();
        $newPage->Title = 'My new page';
        $newPage->URLSegment = 'my-new-page';

        $this->assertTrue($newPage->validURLSegment());
    }

    public function testValidURLSegmentWithExistingPageInSubsite()
    {
        $subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
        Subsite::changeSubsite($subsite1->ID);

        SiteTree::config()->set('nested_urls', false);

        $similarContactUsPage = new SubsitesVirtualPage();
        $similarContactUsPage->Title = 'Similar to Contact Us in Subsite 1';
        $similarContactUsPage->URLSegment = 'contact-us';

        $this->assertFalse($similarContactUsPage->validURLSegment());
    }

    public function testValidURLSegmentWithExistingPageInAnotherSubsite()
    {
        $subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
        Subsite::changeSubsite($subsite1->ID);

        $similarStaffPage = new SubsitesVirtualPage();
        $similarStaffPage->Title = 'Similar to Staff page in main site';
        $similarStaffPage->URLSegment = 'staff';

        $this->assertFalse($similarStaffPage->validURLSegment());
    }
}


1			<?php
2
3			namespace SilverStripe\Subsites\Tests;
4
5			use Page;
			0 ignored issues – show Bug introduced 2017-12-04 02:38 UTC by Report Bug Copy Issue Report The type `Page` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use SilverStripe\Assets\File;
7			use SilverStripe\Assets\Filesystem;
8			use SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore;
			0 ignored issues – show Bug introduced 2018-03-15 03:01 UTC by Report Bug Copy Issue Report The type `SilverStripe\Assets\Test...toreTest\TestAssetStore` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9			use SilverStripe\CMS\Model\SiteTree;
10			use SilverStripe\Control\Director;
11			use SilverStripe\Core\Config\Config;
12			use SilverStripe\ORM\DB;
13			use SilverStripe\Subsites\Model\Subsite;
14			use SilverStripe\Subsites\Pages\SubsitesVirtualPage;
15			use SilverStripe\Versioned\Versioned;
16
17			class SubsitesVirtualPageTest extends BaseSubsiteTest
18			{
19			protected static $fixture_file = [
20			'SubsiteTest.yml',
21			'SubsitesVirtualPageTest.yml',
22			];
23
24			protected function setUp()
25			{
26			parent::setUp();
27
28			Config::modify()->set(Subsite::class, 'write_hostmap', false);
29
30			// Set backend root to /DataDifferencerTest
31			TestAssetStore::activate('SubsitesVirtualPageTest');
32
33			// Create a test files for each of the fixture references
34			$file = $this->objFromFixture(File::class, 'file1');
35			$page = $this->objFromFixture(SiteTree::class, 'page1');
36			$fromPath = __DIR__ . '/testscript-test-file.pdf';
37			$destPath = TestAssetStore::getLocalPath($file);
38			Filesystem::makeFolder(dirname($destPath));
39			copy($fromPath, $destPath);
40
41			// Hack in site link tracking after the fact
42			$page->Content = '<p><img src="' . $file->getURL() . '" data-fileid="' . $file->ID . '" /></p>';
43			$page->write();
44			}
45
46			public function tearDown()
47			{
48			TestAssetStore::reset();
49			parent::tearDown();
50			}
51
52			// Attempt to bring main:linky to subsite2:linky
53			public function testVirtualPageFromAnotherSubsite()
54			{
55			$subsite = $this->objFromFixture(Subsite::class, 'subsite2');
56
57			Subsite::changeSubsite($subsite->ID);
58			Subsite::$disable_subsite_filter = false;
59
60			$linky = $this->objFromFixture(Page::class, 'linky');
61
62			$svp = new SubsitesVirtualPage();
63			$svp->CopyContentFromID = $linky->ID;
64			$svp->SubsiteID = $subsite->ID;
65			$svp->URLSegment = 'linky';
66
67			$svp->write();
68
69			$this->assertEquals($svp->SubsiteID, $subsite->ID);
			0 ignored issues – show Bug Best Practice introduced 2017-12-04 02:38 UTC by Report Bug Copy Issue Report The property `SubsiteID` does not exist on `SilverStripe\Subsites\Pages\SubsitesVirtualPage`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
70			$this->assertEquals($svp->Title, $linky->Title);
			0 ignored issues – show Bug Best Practice introduced 2017-12-04 02:38 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `SilverStripe\Subsites\Pages\SubsitesVirtualPage`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
71			}
72
73			public function testFileLinkRewritingOnVirtualPages()
74			{
75			$this->markTestSkipped('File handling needs update');
76			// File setup
77			$this->logInWithPermission('ADMIN');
78			touch(Director::baseFolder() . '/assets/testscript-test-file.pdf');
79
80			// Publish the source page
81			$page = $this->objFromFixture(SiteTree::class, 'page1');
82			$this->assertTrue($page->publishSingle());
83
84			// Create a virtual page from it, and publish that
85			$svp = new SubsitesVirtualPage();
86			$svp->CopyContentFromID = $page->ID;
87			$svp->write();
88			$svp->publishSingle();
89
90			// Rename the file
91			$file = $this->objFromFixture(File::class, 'file1');
92			$file->Name = 'renamed-test-file.pdf';
93			$file->write();
94
95			// Verify that the draft and publish virtual pages both have the corrected link
96			$this->assertContains(
97			'<img src="/assets/SubsitesVirtualPageTest/464dedb70a/renamed-test-file.pdf"',
98			DB::query("SELECT \"Content\" FROM \"SiteTree\" WHERE \"ID\" = $svp->ID")->value()
99			);
100			$this->assertContains(
101			'<img src="/assets/SubsitesVirtualPageTest/464dedb70a/renamed-test-file.pdf"',
102			DB::query("SELECT \"Content\" FROM \"SiteTree_Live\" WHERE \"ID\" = $svp->ID")->value()
103			);
104			}
105
106			public function testSubsiteVirtualPagesArentInappropriatelyPublished()
107			{
108			$this->markTestSkipped('Needs some update or refactoring');
109			// Fixture
110			$p = new Page();
111			$p->Content = 'test content';
112			$p->write();
113			$vp = new SubsitesVirtualPage();
114			$vp->CopyContentFromID = $p->ID;
115			$vp->write();
116
117			// VP is oragne
118			$this->assertTrue($vp->IsAddedToStage);
119
120			// VP is still orange after we publish
121			$p->publishSingle();
122			$this->fixVersionNumberCache($vp);
123			$this->assertTrue($vp->IsAddedToStage);
124
125			// A new VP created after P's initial construction
126			$vp2 = new SubsitesVirtualPage();
127			$vp2->CopyContentFromID = $p->ID;
128			$vp2->write();
129			$this->assertTrue($vp2->IsAddedToStage);
130
131			// Also remains orange after a republish
132			$p->Content = 'new content';
133			$p->write();
134			$p->publishSingle();
135			$this->fixVersionNumberCache($vp2);
136			$this->assertTrue($vp2->IsAddedToStage);
137
138			// VP is now published
139			$vp->publishSingle();
140
141			$this->fixVersionNumberCache($vp);
142			$this->assertTrue($vp->ExistsOnLive);
143			$this->assertFalse($vp->IsModifiedOnStage);
144
145			// P edited, VP and P both go green
146			$p->Content = 'third content';
147			$p->write();
148
149			$this->fixVersionNumberCache($vp, $p);
150			$this->assertTrue($p->IsModifiedOnStage);
151			$this->assertTrue($vp->IsModifiedOnStage);
152
153			// Publish, VP goes black
154			$p->publishSingle();
155			$this->fixVersionNumberCache($vp);
156			$this->assertTrue($vp->ExistsOnLive);
157			$this->assertFalse($vp->IsModifiedOnStage);
158			}
159
160			/**
161			* This test ensures published Subsites Virtual Pages immediately reflect updates
162			* to their published target pages. Note - this has to happen when the virtual page
163			* is in a different subsite to the page you are editing and republishing,
164			* otherwise the test will pass falsely due to current subsite ID being the same.
165			*/
166			public function testPublishedSubsiteVirtualPagesUpdateIfTargetPageUpdates()
167			{
168			$this->markTestSkipped('Needs some update or refactoring');
169
170			// create page
171			$p = new Page();
172			$p->Content = 'Content';
173			$p->Title = 'Title';
174			$p->writeToStage('Stage');
175			$p->copyVersionToStage('Stage', 'Live');
176			$this->assertTrue($p->ExistsOnLive);
177
178			// change to subsite
179			$subsite = $this->objFromFixture(Subsite::class, 'subsite2');
180			Subsite::changeSubsite($subsite->ID);
181			Subsite::$disable_subsite_filter = false;
182
183			// create svp in subsite
184			$svp = new SubsitesVirtualPage();
185			$svp->CopyContentFromID = $p->ID;
186			$svp->write();
187			$svp->writeToStage('Stage');
188			$svp->copyVersionToStage('Stage', 'Live');
189			$this->assertEquals($svp->SubsiteID, $subsite->ID);
190			$this->assertTrue($svp->ExistsOnLive);
191
192			// change back to original subsite ("Main site")
193			Subsite::changeSubsite(0);
194
195			// update original page
196			$p->Title = 'New Title';
197			// "save & publish"
198			$p->writeToStage('Stage');
199			$p->copyVersionToStage('Stage', 'Live');
200			$this->assertNotEquals($p->SubsiteID, $subsite->ID);
201
202			// reload SVP from database
203			// can't use DO::get by id because caches.
204			$svpdb = $svp->get()->byID($svp->ID);
205
206			// ensure title changed
207			$this->assertEquals($svpdb->Title, $p->Title);
208			}
209
210			public function testUnpublishingParentPageUnpublishesSubsiteVirtualPages()
211			{
212			$this->markTestIncomplete('@todo fix this test');
213
214			Config::modify()->set('StaticPublisher', 'disable_realtime', true);
215
216			// Go to main site, get parent page
217			$subsite = $this->objFromFixture(Subsite::class, 'main');
218			Subsite::changeSubsite($subsite->ID);
219			$page = $this->objFromFixture('Page', 'importantpage');
220
221			// Create two SVPs on other subsites
222			$subsite = $this->objFromFixture(Subsite::class, 'subsite1');
223			Subsite::changeSubsite($subsite->ID);
224			$vp1 = new SubsitesVirtualPage();
225			$vp1->CopyContentFromID = $page->ID;
226			$vp1->write();
227			$vp1->copyVersionToStage(Versioned::DRAFT, Versioned::LIVE);
228
229			$subsite = $this->objFromFixture(Subsite::class, 'subsite2');
230			Subsite::changeSubsite($subsite->ID);
231			$vp2 = new SubsitesVirtualPage();
232			$vp2->CopyContentFromID = $page->ID;
233			$vp2->write();
234			$vp2->copyVersionToStage(Versioned::DRAFT, Versioned::LIVE);
235
236			// Switch back to main site, unpublish source
237			$subsite = $this->objFromFixture(Subsite::class, 'main');
238			Subsite::changeSubsite($subsite->ID);
239			$page = $this->objFromFixture('Page', 'importantpage');
240			$page->doUnpublish();
241
242			Subsite::changeSubsite($vp1->SubsiteID);
243			$onLive = Versioned::get_one_by_stage(SubsitesVirtualPage::class, 'Live', '"SiteTree_Live"."ID" = ' . $vp1->ID);
244			$this->assertNull($onLive, 'SVP has been removed from live');
245
246			$subsite = $this->objFromFixture(Subsite::class, 'subsite2');
			0 ignored issues – show Unused Code introduced 2017-12-04 02:38 UTC by Report Bug Copy Issue Report The assignment to `$subsite` is dead and can be removed. Loading history...
247			Subsite::changeSubsite($vp2->SubsiteID);
248			$onLive = Versioned::get_one_by_stage(SubsitesVirtualPage::class, 'Live', '"SiteTree_Live"."ID" = ' . $vp2->ID);
249			$this->assertNull($onLive, 'SVP has been removed from live');
250			}
251
252			/**
253			* Similar to {@link SiteTreeSubsitesTest->testTwoPagesWithSameURLOnDifferentSubsites()}
254			* and {@link SiteTreeSubsitesTest->testPagesInDifferentSubsitesCanShareURLSegment()}.
255			*/
256			public function testSubsiteVirtualPageCanHaveSameUrlsegmentAsOtherSubsite()
257			{
258			$this->markTestIncomplete('@todo fix this test');
259
260			$subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
261			$subsite2 = $this->objFromFixture(Subsite::class, 'subsite2');
262			Subsite::changeSubsite($subsite1->ID);
263
264			$subsite1Page = $this->objFromFixture(Page::class, 'subsite1_staff');
265			$subsite1Page->URLSegment = 'staff';
266			$subsite1Page->write();
267
268			// saving on subsite1, and linking to subsite1
269			$subsite1Vp = new SubsitesVirtualPage();
270			$subsite1Vp->CopyContentFromID = $subsite1Page->ID;
271			$subsite1Vp->SubsiteID = $subsite1->ID;
272			$subsite1Vp->write();
273
274			$this->assertNotEquals(
275			$subsite1Vp->URLSegment,
276			$subsite1Page->URLSegment,
277			"Doesn't allow explicit URLSegment overrides when already existing in same subsite"
278			);
279
280			//Change to subsite 2
281			Subsite::changeSubsite($subsite2->ID);
282
283			// saving in subsite2 (which already has a page with URLSegment 'contact-us'),
284			// but linking to a page in subsite1
285			$subsite2Vp = new SubsitesVirtualPage();
286			$subsite2Vp->CopyContentFromID = $subsite1Page->ID;
287			$subsite2Vp->SubsiteID = $subsite2->ID;
288			$subsite2Vp->write();
289			$this->assertEquals(
290			$subsite2Vp->URLSegment,
291			$subsite1Page->URLSegment,
292			'Does allow explicit URLSegment overrides when only existing in a different subsite'
293			);
294
295			// When changing subsites and re-saving this page, it doesn't trigger a change
296			Subsite::changeSubsite($subsite1->ID);
297			$subsite1Page->write();
298			$subsite2Vp->write();
299			$this->assertEquals(
300			$subsite2Vp->URLSegment,
301			$subsite1Page->URLSegment,
302			"SubsiteVirtualPage doesn't change urls when being written in another subsite"
303			);
304			}
305
306			protected function fixVersionNumberCache($page)
307			{
308			$pages = func_get_args();
309			foreach ($pages as $p) {
310			Versioned::prepopulate_versionnumber_cache(SiteTree::class, 'Stage', [$p->ID]);
311			Versioned::prepopulate_versionnumber_cache(SiteTree::class, 'Live', [$p->ID]);
312			}
313			}
314
315			public function testValidURLSegmentWithUniquePageAndNestedURLs()
316			{
317			SiteTree::config()->set('nested_urls', true);
318
319			$newPage = new SubsitesVirtualPage();
320			$newPage->Title = 'My new page';
321			$newPage->URLSegment = 'my-new-page';
322
323			$this->assertTrue($newPage->validURLSegment());
324			}
325
326			public function testValidURLSegmentWithExistingPageInSubsite()
327			{
328			$subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
329			Subsite::changeSubsite($subsite1->ID);
330
331			SiteTree::config()->set('nested_urls', false);
332
333			$similarContactUsPage = new SubsitesVirtualPage();
334			$similarContactUsPage->Title = 'Similar to Contact Us in Subsite 1';
335			$similarContactUsPage->URLSegment = 'contact-us';
336
337			$this->assertFalse($similarContactUsPage->validURLSegment());
338			}
339
340			public function testValidURLSegmentWithExistingPageInAnotherSubsite()
341			{
342			$subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
343			Subsite::changeSubsite($subsite1->ID);
344
345			$similarStaffPage = new SubsitesVirtualPage();
346			$similarStaffPage->Title = 'Similar to Staff page in main site';
347			$similarStaffPage->URLSegment = 'staff';
348
349			$this->assertFalse($similarStaffPage->validURLSegment());
350			}
351			}
352

silverstripe / silverstripe-subsites

Push — master ( 483a86...be3bca )

SubsitesVirtualPageTest::tearDown() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like