SilverStripe\Subsites\Tests\SubsitesVirtualPageTest

Complexity

Total Complexity

13

Size/Duplication

Total Lines	333
Duplicated Lines	0 %

Importance

Changes	13
Bugs	3	Features	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	4	1
A	fixVersionNumberCache()	0	6	2
A	testPublishedSubsiteVirtualPagesUpdateIfTargetPageUpdates()	0	42	1
A	setUp()	0	20	1
A	testVirtualPageFromAnotherSubsite()	0	18	1
A	testFileLinkRewritingOnVirtualPages()	0	30	1
A	testSubsiteVirtualPageCanHaveSameUrlsegmentAsOtherSubsite()	0	47	1
A	testValidURLSegmentWithExistingPageInSubsite()	0	12	1
A	testValidURLSegmentWithExistingPageInAnotherSubsite()	0	10	1
A	testValidURLSegmentWithUniquePageAndNestedURLs()	0	9	1
A	testSubsiteVirtualPagesArentInappropriatelyPublished()	0	52	1
A	testUnpublishingParentPageUnpublishesSubsiteVirtualPages()	0	40	1

<?php

namespace SilverStripe\Subsites\Tests;

use Page;

The type Page was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\Assets\File;
use SilverStripe\Assets\Filesystem;
use SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore;

The type SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Control\Director;
use SilverStripe\Core\Config\Config;
use SilverStripe\ORM\DB;
use SilverStripe\Subsites\Model\Subsite;
use SilverStripe\Subsites\Pages\SubsitesVirtualPage;
use SilverStripe\Versioned\Versioned;

class SubsitesVirtualPageTest extends BaseSubsiteTest
{
    protected static $fixture_file = [
        'SubsiteTest.yml',
        'SubsitesVirtualPageTest.yml',
    ];

    protected function setUp()
    {
        parent::setUp();

        Config::modify()->set(Subsite::class, 'write_hostmap', false);

        // Set backend root to /DataDifferencerTest
        TestAssetStore::activate('SubsitesVirtualPageTest');

        // Create a test files for each of the fixture references
        $file = $this->objFromFixture(File::class, 'file1');
        $page = $this->objFromFixture(SiteTree::class, 'page1');
        $fromPath = __DIR__ . '/testscript-test-file.pdf';
        $destPath = TestAssetStore::getLocalPath($file);
        Filesystem::makeFolder(dirname($destPath));
        copy($fromPath, $destPath);

        // Hack in site link tracking after the fact
        $page->Content = '<p><img src="' . $file->getURL() . '" data-fileid="' . $file->ID . '" /></p>';
        $page->write();
    }

    public function tearDown()
    {
        TestAssetStore::reset();
        parent::tearDown();
    }

    // Attempt to bring main:linky to subsite2:linky
    public function testVirtualPageFromAnotherSubsite()
    {
        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');

        Subsite::changeSubsite($subsite->ID);
        Subsite::$disable_subsite_filter = false;

        $linky = $this->objFromFixture(Page::class, 'linky');

        $svp = new SubsitesVirtualPage();
        $svp->CopyContentFromID = $linky->ID;
        $svp->SubsiteID = $subsite->ID;
        $svp->URLSegment = 'linky';

        $svp->write();

        $this->assertEquals($svp->SubsiteID, $subsite->ID);

The property SubsiteID does not exist on SilverStripe\Subsites\Pages\SubsitesVirtualPage. Since you implemented __get, consider adding a @property annotation.

        $this->assertEquals($svp->Title, $linky->Title);

The property Title does not exist on SilverStripe\Subsites\Pages\SubsitesVirtualPage. Since you implemented __get, consider adding a @property annotation.

    }

    public function testFileLinkRewritingOnVirtualPages()
    {
        $this->markTestSkipped('File handling needs update');
        // File setup
        $this->logInWithPermission('ADMIN');
        touch(Director::baseFolder() . '/assets/testscript-test-file.pdf');

        // Publish the source page
        $page = $this->objFromFixture(SiteTree::class, 'page1');
        $this->assertTrue($page->publishSingle());

        // Create a virtual page from it, and publish that
        $svp = new SubsitesVirtualPage();
        $svp->CopyContentFromID = $page->ID;
        $svp->write();
        $svp->publishSingle();

        // Rename the file
        $file = $this->objFromFixture(File::class, 'file1');
        $file->Name = 'renamed-test-file.pdf';
        $file->write();

        // Verify that the draft and publish virtual pages both have the corrected link
        $this->assertContains(
            '<img src="/assets/SubsitesVirtualPageTest/464dedb70a/renamed-test-file.pdf"',
            DB::query("SELECT \"Content\" FROM \"SiteTree\" WHERE \"ID\" = $svp->ID")->value()
        );
        $this->assertContains(
            '<img src="/assets/SubsitesVirtualPageTest/464dedb70a/renamed-test-file.pdf"',
            DB::query("SELECT \"Content\" FROM \"SiteTree_Live\" WHERE \"ID\" = $svp->ID")->value()
        );
    }

    public function testSubsiteVirtualPagesArentInappropriatelyPublished()
    {
        $this->markTestSkipped('Needs some update or refactoring');
        // Fixture
        $p = new Page();
        $p->Content = 'test content';
        $p->write();
        $vp = new SubsitesVirtualPage();
        $vp->CopyContentFromID = $p->ID;
        $vp->write();

        // VP is oragne
        $this->assertTrue($vp->IsAddedToStage);

        // VP is still orange after we publish
        $p->publishSingle();
        $this->fixVersionNumberCache($vp);
        $this->assertTrue($vp->IsAddedToStage);

        // A new VP created after P's initial construction
        $vp2 = new SubsitesVirtualPage();
        $vp2->CopyContentFromID = $p->ID;
        $vp2->write();
        $this->assertTrue($vp2->IsAddedToStage);

        // Also remains orange after a republish
        $p->Content = 'new content';
        $p->write();
        $p->publishSingle();
        $this->fixVersionNumberCache($vp2);
        $this->assertTrue($vp2->IsAddedToStage);

        // VP is now published
        $vp->publishSingle();

        $this->fixVersionNumberCache($vp);
        $this->assertTrue($vp->ExistsOnLive);
        $this->assertFalse($vp->IsModifiedOnStage);

        // P edited, VP and P both go green
        $p->Content = 'third content';
        $p->write();

        $this->fixVersionNumberCache($vp, $p);
        $this->assertTrue($p->IsModifiedOnStage);
        $this->assertTrue($vp->IsModifiedOnStage);

        // Publish, VP goes black
        $p->publishSingle();
        $this->fixVersionNumberCache($vp);
        $this->assertTrue($vp->ExistsOnLive);
        $this->assertFalse($vp->IsModifiedOnStage);
    }

    /**
     * This test ensures published Subsites Virtual Pages immediately reflect updates
     * to their published target pages. Note - this has to happen when the virtual page
     * is in a different subsite to the page you are editing and republishing,
     * otherwise the test will pass falsely due to current subsite ID being the same.
     */
    public function testPublishedSubsiteVirtualPagesUpdateIfTargetPageUpdates()
    {
        $this->markTestSkipped('Needs some update or refactoring');

        // create page
        $p = new Page();
        $p->Content = 'Content';
        $p->Title = 'Title';
        $p->writeToStage('Stage');
        $p->copyVersionToStage('Stage', 'Live');
        $this->assertTrue($p->ExistsOnLive);

        // change to subsite
        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');
        Subsite::changeSubsite($subsite->ID);
        Subsite::$disable_subsite_filter = false;

        // create svp in subsite
        $svp = new SubsitesVirtualPage();
        $svp->CopyContentFromID = $p->ID;
        $svp->write();
        $svp->writeToStage('Stage');
        $svp->copyVersionToStage('Stage', 'Live');
        $this->assertEquals($svp->SubsiteID, $subsite->ID);
        $this->assertTrue($svp->ExistsOnLive);

        // change back to original subsite ("Main site")
        Subsite::changeSubsite(0);

        // update original page
        $p->Title = 'New Title';
        // "save & publish"
        $p->writeToStage('Stage');
        $p->copyVersionToStage('Stage', 'Live');
        $this->assertNotEquals($p->SubsiteID, $subsite->ID);

        // reload SVP from database
        // can't use DO::get by id because caches.
        $svpdb = $svp->get()->byID($svp->ID);

        // ensure title changed
        $this->assertEquals($svpdb->Title, $p->Title);
    }

    public function testUnpublishingParentPageUnpublishesSubsiteVirtualPages()
    {
        $this->markTestIncomplete('@todo fix this test');

        Config::modify()->set('StaticPublisher', 'disable_realtime', true);

        // Go to main site, get parent page
        $subsite = $this->objFromFixture(Subsite::class, 'main');
        Subsite::changeSubsite($subsite->ID);
        $page = $this->objFromFixture('Page', 'importantpage');

        // Create two SVPs on other subsites
        $subsite = $this->objFromFixture(Subsite::class, 'subsite1');
        Subsite::changeSubsite($subsite->ID);
        $vp1 = new SubsitesVirtualPage();
        $vp1->CopyContentFromID = $page->ID;
        $vp1->write();
        $vp1->copyVersionToStage(Versioned::DRAFT, Versioned::LIVE);

        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');
        Subsite::changeSubsite($subsite->ID);
        $vp2 = new SubsitesVirtualPage();
        $vp2->CopyContentFromID = $page->ID;
        $vp2->write();
        $vp2->copyVersionToStage(Versioned::DRAFT, Versioned::LIVE);

        // Switch back to main site, unpublish source
        $subsite = $this->objFromFixture(Subsite::class, 'main');
        Subsite::changeSubsite($subsite->ID);
        $page = $this->objFromFixture('Page', 'importantpage');
        $page->doUnpublish();

        Subsite::changeSubsite($vp1->SubsiteID);
        $onLive = Versioned::get_one_by_stage(SubsitesVirtualPage::class, 'Live', '"SiteTree_Live"."ID" = ' . $vp1->ID);
        $this->assertNull($onLive, 'SVP has been removed from live');

        $subsite = $this->objFromFixture(Subsite::class, 'subsite2');

The assignment to $subsite is dead and can be removed.

        Subsite::changeSubsite($vp2->SubsiteID);
        $onLive = Versioned::get_one_by_stage(SubsitesVirtualPage::class, 'Live', '"SiteTree_Live"."ID" = ' . $vp2->ID);
        $this->assertNull($onLive, 'SVP has been removed from live');
    }

    /**
     * Similar to {@link SiteTreeSubsitesTest->testTwoPagesWithSameURLOnDifferentSubsites()}
     * and {@link SiteTreeSubsitesTest->testPagesInDifferentSubsitesCanShareURLSegment()}.
     */
    public function testSubsiteVirtualPageCanHaveSameUrlsegmentAsOtherSubsite()
    {
        $this->markTestIncomplete('@todo fix this test');

        $subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
        $subsite2 = $this->objFromFixture(Subsite::class, 'subsite2');
        Subsite::changeSubsite($subsite1->ID);

        $subsite1Page = $this->objFromFixture(Page::class, 'subsite1_staff');
        $subsite1Page->URLSegment = 'staff';
        $subsite1Page->write();

        // saving on subsite1, and linking to subsite1
        $subsite1Vp = new SubsitesVirtualPage();
        $subsite1Vp->CopyContentFromID = $subsite1Page->ID;
        $subsite1Vp->SubsiteID = $subsite1->ID;
        $subsite1Vp->write();

        $this->assertNotEquals(
            $subsite1Vp->URLSegment,
            $subsite1Page->URLSegment,
            "Doesn't allow explicit URLSegment overrides when already existing in same subsite"
        );

        //Change to subsite 2
        Subsite::changeSubsite($subsite2->ID);

        // saving in subsite2 (which already has a page with URLSegment 'contact-us'),
        // but linking to a page in subsite1
        $subsite2Vp = new SubsitesVirtualPage();
        $subsite2Vp->CopyContentFromID = $subsite1Page->ID;
        $subsite2Vp->SubsiteID = $subsite2->ID;
        $subsite2Vp->write();
        $this->assertEquals(
            $subsite2Vp->URLSegment,
            $subsite1Page->URLSegment,
            'Does allow explicit URLSegment overrides when only existing in a different subsite'
        );

        // When changing subsites and re-saving this page, it doesn't trigger a change
        Subsite::changeSubsite($subsite1->ID);
        $subsite1Page->write();
        $subsite2Vp->write();
        $this->assertEquals(
            $subsite2Vp->URLSegment,
            $subsite1Page->URLSegment,
            "SubsiteVirtualPage doesn't change urls when being written in another subsite"
        );
    }

    protected function fixVersionNumberCache($page)
    {
        $pages = func_get_args();
        foreach ($pages as $p) {
            Versioned::prepopulate_versionnumber_cache(SiteTree::class, 'Stage', [$p->ID]);
            Versioned::prepopulate_versionnumber_cache(SiteTree::class, 'Live', [$p->ID]);
        }
    }

    public function testValidURLSegmentWithUniquePageAndNestedURLs()
    {
        SiteTree::config()->set('nested_urls', true);

        $newPage = new SubsitesVirtualPage();
        $newPage->Title = 'My new page';
        $newPage->URLSegment = 'my-new-page';

        $this->assertTrue($newPage->validURLSegment());
    }

    public function testValidURLSegmentWithExistingPageInSubsite()
    {
        $subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
        Subsite::changeSubsite($subsite1->ID);

        SiteTree::config()->set('nested_urls', false);

        $similarContactUsPage = new SubsitesVirtualPage();
        $similarContactUsPage->Title = 'Similar to Contact Us in Subsite 1';
        $similarContactUsPage->URLSegment = 'contact-us';

        $this->assertFalse($similarContactUsPage->validURLSegment());
    }

    public function testValidURLSegmentWithExistingPageInAnotherSubsite()
    {
        $subsite1 = $this->objFromFixture(Subsite::class, 'subsite1');
        Subsite::changeSubsite($subsite1->ID);

        $similarStaffPage = new SubsitesVirtualPage();
        $similarStaffPage->Title = 'Similar to Staff page in main site';
        $similarStaffPage->URLSegment = 'staff';

        $this->assertFalse($similarStaffPage->validURLSegment());
    }
}