silverstripe / silverstripe-lumberjack

tests/LumberjackTest.php

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
      */
     protected function filteredClassNames($classNames, $explicitClassNames)
     {
-        $classNames = array_filter($classNames, function ($value) use ($explicitClassNames) {
+        $classNames = array_filter($classNames, function($value) use ($explicitClassNames) {
             return in_array($value, $explicitClassNames);
         });
         return $classNames;

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\Lumberjack\Tests\Stub\SiteTree\LumberjackStub;
 use SilverStripe\Lumberjack\Tests\Stub\SiteTree\LumberjackHiddenStub;
 use SilverStripe\Lumberjack\Tests\Stub\SiteTree\LumberjackShownStub;

Indentation +45 added lines, -45 removed lines

@@ -12,54 +12,54 @@
 
 class LumberjackTest extends SapphireTest
 {
-    /**
-     * {@inheritDoc}
-     * @var string
-     */
-    protected static $fixture_file = 'fixtures.yml';
+	/**
+	 * {@inheritDoc}
+	 * @var string
+	 */
+	protected static $fixture_file = 'fixtures.yml';
 
-    /**
-     * @var array
-     */
-    protected static $extra_dataobjects = [
-        LumberjackStub::class,
-        LumberjackHiddenStub::class,
-        LumberjackShownStub::class,
-    ];
+	/**
+	 * @var array
+	 */
+	protected static $extra_dataobjects = [
+		LumberjackStub::class,
+		LumberjackHiddenStub::class,
+		LumberjackShownStub::class,
+	];
 
-    public function testGetExcludedSiteTreeClassNames()
-    {
-        $standard = $this->objFromFixture(LumberjackStub::class, 'standard');
+	public function testGetExcludedSiteTreeClassNames()
+	{
+		$standard = $this->objFromFixture(LumberjackStub::class, 'standard');
 
-        $excluded = $standard->getExcludedSiteTreeClassNames();
-        $excluded = $this->filteredClassNames($excluded, self::$extra_dataobjects);
-        $this->assertEquals($excluded, array(LumberjackHiddenStub::class => LumberjackHiddenStub::class));
+		$excluded = $standard->getExcludedSiteTreeClassNames();
+		$excluded = $this->filteredClassNames($excluded, self::$extra_dataobjects);
+		$this->assertEquals($excluded, array(LumberjackHiddenStub::class => LumberjackHiddenStub::class));
 
-        Config::modify()->set(SiteTree::class, 'show_in_sitetree', false);
-        $excluded = $standard->getExcludedSiteTreeClassNames();
-        $excluded = $this->filteredClassNames($excluded, self::$extra_dataobjects);
-        $this->assertEquals(
-            $excluded,
-            array(
-                LumberjackStub::class       => LumberjackStub::class,
-                LumberjackHiddenStub::class => LumberjackHiddenStub::class
-            )
-        );
-    }
+		Config::modify()->set(SiteTree::class, 'show_in_sitetree', false);
+		$excluded = $standard->getExcludedSiteTreeClassNames();
+		$excluded = $this->filteredClassNames($excluded, self::$extra_dataobjects);
+		$this->assertEquals(
+			$excluded,
+			array(
+				LumberjackStub::class       => LumberjackStub::class,
+				LumberjackHiddenStub::class => LumberjackHiddenStub::class
+			)
+		);
+	}
 
-    /**
-     * Because we don't know what other test classes are included, we filter to the ones we know
-     * and want to test.
-     *
-     * @param  array $classNames
-     * @param  array $explicitClassNames
-     * @return array
-     */
-    protected function filteredClassNames($classNames, $explicitClassNames)
-    {
-        $classNames = array_filter($classNames, function ($value) use ($explicitClassNames) {
-            return in_array($value, $explicitClassNames);
-        });
-        return $classNames;
-    }
+	/**
+	 * Because we don't know what other test classes are included, we filter to the ones we know
+	 * and want to test.
+	 *
+	 * @param  array $classNames
+	 * @param  array $explicitClassNames
+	 * @return array
+	 */
+	protected function filteredClassNames($classNames, $explicitClassNames)
+	{
+		$classNames = array_filter($classNames, function ($value) use ($explicitClassNames) {
+			return in_array($value, $explicitClassNames);
+		});
+		return $classNames;
+	}
 }

src/Forms/GridFieldConfig_Lumberjack.php

Indentation +18 added lines, -18 removed lines

@@ -24,24 +24,24 @@
  **/
 class GridFieldConfig_Lumberjack extends GridFieldConfig
 {
-    /**
-     * @param int|null $itemsPerPage
-     */
-    public function __construct($itemsPerPage = null)
-    {
-        parent::__construct($itemsPerPage);
+	/**
+	 * @param int|null $itemsPerPage
+	 */
+	public function __construct($itemsPerPage = null)
+	{
+		parent::__construct($itemsPerPage);
 
-        $this->addComponent(new GridFieldButtonRow('before'));
-        $this->addComponent(new GridFieldSiteTreeAddNewButton('buttons-before-left'));
-        $this->addComponent(new GridFieldToolbarHeader());
-        $this->addComponent(new GridFieldSortableHeader());
-        $this->addComponent(new GridFieldFilterHeader());
-        $this->addComponent(new GridFieldDataColumns());
-        $this->addComponent(new GridFieldSiteTreeEditButton());
-        $this->addComponent(new GridFieldPageCount('toolbar-header-right'));
-        $this->addComponent($pagination = new GridFieldPaginator($itemsPerPage));
-        $this->addComponent(new GridFieldSiteTreeState());
+		$this->addComponent(new GridFieldButtonRow('before'));
+		$this->addComponent(new GridFieldSiteTreeAddNewButton('buttons-before-left'));
+		$this->addComponent(new GridFieldToolbarHeader());
+		$this->addComponent(new GridFieldSortableHeader());
+		$this->addComponent(new GridFieldFilterHeader());
+		$this->addComponent(new GridFieldDataColumns());
+		$this->addComponent(new GridFieldSiteTreeEditButton());
+		$this->addComponent(new GridFieldPageCount('toolbar-header-right'));
+		$this->addComponent($pagination = new GridFieldPaginator($itemsPerPage));
+		$this->addComponent(new GridFieldSiteTreeState());
 
-        $pagination->setThrowExceptionOnBadDataType(true);
-    }
+		$pagination->setThrowExceptionOnBadDataType(true);
+	}
 }

src/Forms/GridFieldSiteTreeState.php

Indentation +70 added lines, -70 removed lines

@@ -14,80 +14,80 @@
 **/
 class GridFieldSiteTreeState implements GridField_ColumnProvider
 {
-    public function augmentColumns($gridField, &$columns)
-    {
-        // Ensure Actions always appears as the last column.
-        $key = array_search('Actions', $columns);
-        if ($key !== false) {
-            unset($columns[$key]);
-        }
+	public function augmentColumns($gridField, &$columns)
+	{
+		// Ensure Actions always appears as the last column.
+		$key = array_search('Actions', $columns);
+		if ($key !== false) {
+			unset($columns[$key]);
+		}
 
-        $columns = array_merge($columns, array(
-            'State',
-            'Actions',
-        ));
-    }
+		$columns = array_merge($columns, array(
+			'State',
+			'Actions',
+		));
+	}
 
-    public function getColumnsHandled($gridField)
-    {
-        return array('State');
-    }
+	public function getColumnsHandled($gridField)
+	{
+		return array('State');
+	}
 
-    public function getColumnContent($gridField, $record, $columnName)
-    {
-        if ($columnName == 'State') {
-            if ($record->hasMethod('isPublished')) {
-                $modifiedLabel = '';
-                if ($record->isModifiedOnStage) {
-                    $modifiedLabel = "<span class='modified'>" . _t('GridFieldSiteTreeState.Modified', 'Modified') . '</span>';
-                }
+	public function getColumnContent($gridField, $record, $columnName)
+	{
+		if ($columnName == 'State') {
+			if ($record->hasMethod('isPublished')) {
+				$modifiedLabel = '';
+				if ($record->isModifiedOnStage) {
+					$modifiedLabel = "<span class='modified'>" . _t('GridFieldSiteTreeState.Modified', 'Modified') . '</span>';
+				}
 
-                $published = $record->isPublished();
-                if (!$published) {
-                    return _t(
-                        'GridFieldSiteTreeState.Draft',
-                        '<i class="btn-icon gridfield-icon btn-icon-pencil"></i> Saved as Draft on {date}',
-                        'State for when a post is saved.',
-                        array(
-                            'date' => $record->dbObject('LastEdited')->Nice()
-                        )
-                    );
-                }
-                return _t(
-                    'GridFieldSiteTreeState.Published',
-                    '<i class="btn-icon gridfield-icon btn-icon-accept"></i> Published on {date}',
-                    'State for when a post is published.',
-                    array(
-                        'date' => $record->dbObject('LastEdited')->Nice()
-                    )
-                ) . $modifiedLabel;
-            }
-        }
-    }
+				$published = $record->isPublished();
+				if (!$published) {
+					return _t(
+						'GridFieldSiteTreeState.Draft',
+						'<i class="btn-icon gridfield-icon btn-icon-pencil"></i> Saved as Draft on {date}',
+						'State for when a post is saved.',
+						array(
+							'date' => $record->dbObject('LastEdited')->Nice()
+						)
+					);
+				}
+				return _t(
+					'GridFieldSiteTreeState.Published',
+					'<i class="btn-icon gridfield-icon btn-icon-accept"></i> Published on {date}',
+					'State for when a post is published.',
+					array(
+						'date' => $record->dbObject('LastEdited')->Nice()
+					)
+				) . $modifiedLabel;
+			}
+		}
+	}
 
-    public function getColumnAttributes($gridField, $record, $columnName)
-    {
-        if ($columnName == 'State') {
-            if ($record->hasMethod('isPublished')) {
-                $published = $record->isPublished();
-                if (!$published) {
-                    $class = 'gridfield-icon draft';
-                } else {
-                    $class = 'gridfield-icon published';
-                }
-                return array('class' => $class);
-            }
-        }
-        return array();
-    }
+	public function getColumnAttributes($gridField, $record, $columnName)
+	{
+		if ($columnName == 'State') {
+			if ($record->hasMethod('isPublished')) {
+				$published = $record->isPublished();
+				if (!$published) {
+					$class = 'gridfield-icon draft';
+				} else {
+					$class = 'gridfield-icon published';
+				}
+				return array('class' => $class);
+			}
+		}
+		return array();
+	}
 
-    public function getColumnMetaData($gridField, $columnName)
-    {
-        switch ($columnName) {
-            case 'State':
-                return array('title' => _t('GridFieldSiteTreeState.StateTitle', 'State', 'Column title for state'));
-            default:
-                break;
-        }
-    }
+	public function getColumnMetaData($gridField, $columnName)
+	{
+		switch ($columnName) {
+			case 'State':
+				return array('title' => _t('GridFieldSiteTreeState.StateTitle', 'State', 'Column title for state'));
+			default:
+				break;
+		}
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
             if ($record->hasMethod('isPublished')) {
                 $modifiedLabel = '';
                 if ($record->isModifiedOnStage) {
-                    $modifiedLabel = "<span class='modified'>" . _t('GridFieldSiteTreeState.Modified', 'Modified') . '</span>';
+                    $modifiedLabel = "<span class='modified'>"._t('GridFieldSiteTreeState.Modified', 'Modified').'</span>';
                 }
 
                 $published = $record->isPublished();
@@ -60,7 +60,7 @@ 
                     array(
                         'date' => $record->dbObject('LastEdited')->Nice()
                     )
-                ) . $modifiedLabel;
+                ).$modifiedLabel;
             }
         }
     }

src/Forms/GridFieldSiteTreeAddNewButton.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\CMS\Controllers\CMSPageAddController;
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Control\Controller;
-use SilverStripe\Control\Director;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\DropdownField;

Spacing +2 added lines, -2 removed lines

@@ -116,8 +116,8 @@
         $forTemplate->Fields->push($pageTypes);
         $forTemplate->Fields->push($addAction);
 
-        Requirements::css(LUMBERJACK_DIR . '/css/lumberjack.css');
-        Requirements::javascript(LUMBERJACK_DIR . '/javascript/GridField.js');
+        Requirements::css(LUMBERJACK_DIR.'/css/lumberjack.css');
+        Requirements::javascript(LUMBERJACK_DIR.'/javascript/GridField.js');
 
         return [$this->targetFragment => $forTemplate->renderWith(__CLASS__)];
     }

Indentation +138 added lines, -138 removed lines

@@ -30,143 +30,143 @@
  * @author Michael Strong <mstrong@silverstripe.org>
  */
 class GridFieldSiteTreeAddNewButton extends GridFieldAddNewButton implements
-    GridField_ActionProvider,
-    GridFieldComponent
+	GridField_ActionProvider,
+	GridFieldComponent
 {
-    /**
-     * Determine the list of classnames and titles allowed for a given parent object
-     *
-     * @param SiteTree $parent
-     * @return boolean
-     */
-    public function getAllowedChildren(SiteTree $parent = null)
-    {
-        if (!$parent || !$parent->canAddChildren()) {
-            return array();
-        }
-
-        $nonHiddenPageTypes = SiteTree::page_type_classes();
-        $allowedChildren = $parent->allowedChildren();
-        $children = array();
-        foreach ($allowedChildren as $class) {
-            if (Config::inst()->get($class, 'show_in_sitetree') === false) {
-                $instance = Injector::inst()->get($class);
-                // Note: Second argument to SiteTree::canCreate will support inherited permissions
-                // post 3.1.12, and will default to the old permission model in 3.1.11 or below
-                // See http://docs.silverstripe.org/en/changelogs/3.1.11
-                if ($instance->canCreate(null, array('Parent' => $parent)) && in_array($class, $nonHiddenPageTypes)) {
-                    $children[$class] = $instance->i18n_singular_name();
-                }
-            }
-        }
-        return $children;
-    }
-
-    public function getHTMLFragments($gridField)
-    {
-        $state = $gridField->State->GridFieldSiteTreeAddNewButton;
-
-        $parent = SiteTree::get()->byId(Controller::curr()->currentPageID());
-
-        if ($parent) {
-            $state->currentPageID = $parent->ID;
-        }
-
-        $children = $this->getAllowedChildren($parent);
-        if (empty($children)) {
-            return array();
-        } elseif (count($children) > 1) {
-            $pageTypes = DropdownField::create('PageType', 'Page Type', $children, $parent->defaultChild());
-            $pageTypes
-                ->setFieldHolderTemplate('GridFieldSiteTreeAddNewButton_holder')
-                ->addExtraClass('gridfield-dropdown no-change-track');
-
-            $state->pageType = $parent->defaultChild();
-
-            if (!$this->buttonName) {
-                $this->buttonName = _t(
-                    'GridFieldSiteTreeAddNewButton.AddMultipleOptions',
-                    'Add new',
-                    'Add button text for multiple options.'
-                );
-            }
-        } else {
-            $keys = array_keys($children);
-            $pageTypes = HiddenField::create('PageType', 'Page Type', $keys[0]);
-
-            $state->pageType = $keys[0];
-
-            if (!$this->buttonName) {
-                $this->buttonName = _t(
-                    'GridFieldSiteTreeAddNewButton.Add',
-                    'Add new {name}',
-                    'Add button text for a single option.',
-                    ['name' => $children[$keys[0]]]
-                );
-            }
-        }
-
-        $addAction = GridField_FormAction::create($gridField, 'add', $this->buttonName, 'add', 'add');
-        $addAction
-            ->setAttribute('data-icon', 'add')
-            ->addExtraClass('no-ajax btn btn-primary font-icon-plus');
-
-        $forTemplate = ArrayData::create([]);
-        $forTemplate->Fields = ArrayList::create();
-        $forTemplate->Fields->push($pageTypes);
-        $forTemplate->Fields->push($addAction);
-
-        Requirements::css(LUMBERJACK_DIR . '/css/lumberjack.css');
-        Requirements::javascript(LUMBERJACK_DIR . '/javascript/GridField.js');
-
-        return [$this->targetFragment => $forTemplate->renderWith(__CLASS__)];
-    }
-
-    /**
-     * Provide actions to this component.
-     *
-     * @param  GridField $gridField
-     * @return array
-    **/
-    public function getActions($gridField)
-    {
-        return array('add');
-    }
-
-    /**
-     * Handles the add action, but only acts as a wrapper for {@link CMSPageAddController::doAdd()}
-     *
-     * @param GridField $gridField
-     * @param string $actionName
-     * @param mixed $arguments
-     * @param array $data
-    **/
-    public function handleAction(GridField $gridField, $actionName, $arguments, $data)
-    {
-        if ($actionName == 'add') {
-            $tmpData = json_decode($data['ChildPages']['GridState'], true);
-            /** @skipUpgrade  */
-            $tmpData = $tmpData['GridFieldSiteTreeAddNewButton'];
-
-            $data = array(
-                'ParentID' => $tmpData['currentPageID'],
-                'PageType' => $tmpData['pageType']
-            );
-
-            $controller = Injector::inst()->create(CMSPageAddController::class);
-
-            $form = $controller->AddForm();
-            $form->loadDataFrom($data);
-
-            $controller->doAdd($data, $form);
-            $response = $controller->getResponseNegotiator()->getResponse();
-
-            // Get the current record
-            $record = SiteTree::get()->byId($controller->currentPageID());
-            if ($record) {
-                $response->redirect($record->CMSEditLink(), 301);
-            }
-            return $response;
-        }
-    }
+	/**
+	 * Determine the list of classnames and titles allowed for a given parent object
+	 *
+	 * @param SiteTree $parent
+	 * @return boolean
+	 */
+	public function getAllowedChildren(SiteTree $parent = null)
+	{
+		if (!$parent || !$parent->canAddChildren()) {
+			return array();
+		}
+
+		$nonHiddenPageTypes = SiteTree::page_type_classes();
+		$allowedChildren = $parent->allowedChildren();
+		$children = array();
+		foreach ($allowedChildren as $class) {
+			if (Config::inst()->get($class, 'show_in_sitetree') === false) {
+				$instance = Injector::inst()->get($class);
+				// Note: Second argument to SiteTree::canCreate will support inherited permissions
+				// post 3.1.12, and will default to the old permission model in 3.1.11 or below
+				// See http://docs.silverstripe.org/en/changelogs/3.1.11
+				if ($instance->canCreate(null, array('Parent' => $parent)) && in_array($class, $nonHiddenPageTypes)) {
+					$children[$class] = $instance->i18n_singular_name();
+				}
+			}
+		}
+		return $children;
+	}
+
+	public function getHTMLFragments($gridField)
+	{
+		$state = $gridField->State->GridFieldSiteTreeAddNewButton;
+
+		$parent = SiteTree::get()->byId(Controller::curr()->currentPageID());
+
+		if ($parent) {
+			$state->currentPageID = $parent->ID;
+		}
+
+		$children = $this->getAllowedChildren($parent);
+		if (empty($children)) {
+			return array();
+		} elseif (count($children) > 1) {
+			$pageTypes = DropdownField::create('PageType', 'Page Type', $children, $parent->defaultChild());
+			$pageTypes
+				->setFieldHolderTemplate('GridFieldSiteTreeAddNewButton_holder')
+				->addExtraClass('gridfield-dropdown no-change-track');
+
+			$state->pageType = $parent->defaultChild();
+
+			if (!$this->buttonName) {
+				$this->buttonName = _t(
+					'GridFieldSiteTreeAddNewButton.AddMultipleOptions',
+					'Add new',
+					'Add button text for multiple options.'
+				);
+			}
+		} else {
+			$keys = array_keys($children);
+			$pageTypes = HiddenField::create('PageType', 'Page Type', $keys[0]);
+
+			$state->pageType = $keys[0];
+
+			if (!$this->buttonName) {
+				$this->buttonName = _t(
+					'GridFieldSiteTreeAddNewButton.Add',
+					'Add new {name}',
+					'Add button text for a single option.',
+					['name' => $children[$keys[0]]]
+				);
+			}
+		}
+
+		$addAction = GridField_FormAction::create($gridField, 'add', $this->buttonName, 'add', 'add');
+		$addAction
+			->setAttribute('data-icon', 'add')
+			->addExtraClass('no-ajax btn btn-primary font-icon-plus');
+
+		$forTemplate = ArrayData::create([]);
+		$forTemplate->Fields = ArrayList::create();
+		$forTemplate->Fields->push($pageTypes);
+		$forTemplate->Fields->push($addAction);
+
+		Requirements::css(LUMBERJACK_DIR . '/css/lumberjack.css');
+		Requirements::javascript(LUMBERJACK_DIR . '/javascript/GridField.js');
+
+		return [$this->targetFragment => $forTemplate->renderWith(__CLASS__)];
+	}
+
+	/**
+	 * Provide actions to this component.
+	 *
+	 * @param  GridField $gridField
+	 * @return array
+	 **/
+	public function getActions($gridField)
+	{
+		return array('add');
+	}
+
+	/**
+	 * Handles the add action, but only acts as a wrapper for {@link CMSPageAddController::doAdd()}
+	 *
+	 * @param GridField $gridField
+	 * @param string $actionName
+	 * @param mixed $arguments
+	 * @param array $data
+	 **/
+	public function handleAction(GridField $gridField, $actionName, $arguments, $data)
+	{
+		if ($actionName == 'add') {
+			$tmpData = json_decode($data['ChildPages']['GridState'], true);
+			/** @skipUpgrade  */
+			$tmpData = $tmpData['GridFieldSiteTreeAddNewButton'];
+
+			$data = array(
+				'ParentID' => $tmpData['currentPageID'],
+				'PageType' => $tmpData['pageType']
+			);
+
+			$controller = Injector::inst()->create(CMSPageAddController::class);
+
+			$form = $controller->AddForm();
+			$form->loadDataFrom($data);
+
+			$controller->doAdd($data, $form);
+			$response = $controller->getResponseNegotiator()->getResponse();
+
+			// Get the current record
+			$record = SiteTree::get()->byId($controller->currentPageID());
+			if ($record) {
+				$response->redirect($record->CMSEditLink(), 301);
+			}
+			return $response;
+		}
+	}
 }

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
      * Provide actions to this component.
      *
      * @param  GridField $gridField
-     * @return array
+     * @return string[]
     **/
     public function getActions($gridField)
     {

src/Forms/GridFieldSiteTreeEditButton.php

Indentation +15 added lines, -15 removed lines

@@ -17,21 +17,21 @@
 **/
 class GridFieldSiteTreeEditButton extends GridFieldEditButton
 {
-    /**
-     * @param  GridField $gridField
-     * @param  DataObject $record
-     * @param  string $columnName
-     * @return string - the HTML for the column
-     */
-    public function getColumnContent($gridField, $record, $columnName)
-    {
-        // No permission checks - handled through GridFieldDetailForm
-        // which can make the form readonly if no edit permissions are available.
+	/**
+	 * @param  GridField $gridField
+	 * @param  DataObject $record
+	 * @param  string $columnName
+	 * @return string - the HTML for the column
+	 */
+	public function getColumnContent($gridField, $record, $columnName)
+	{
+		// No permission checks - handled through GridFieldDetailForm
+		// which can make the form readonly if no edit permissions are available.
 
-        $data = ArrayData::create(
-            ['Link' => $record->CMSEditLink()]
-        );
+		$data = ArrayData::create(
+			['Link' => $record->CMSEditLink()]
+		);
 
-        return $data->renderWith(GridFieldEditButton::class);
-    }
+		return $data->renderWith(GridFieldEditButton::class);
+	}
 }

tests/Stub/SiteTree/LumberjackShownStub.php

Indentation +1 added lines, -1 removed lines

@@ -6,5 +6,5 @@
 
 class LumberjackShownStub extends LumberjackHiddenStub implements TestOnly
 {
-    private static $show_in_sitetree = true;
+	private static $show_in_sitetree = true;
 }

tests/Stub/SiteTree/LumberjackHiddenStub.php

Indentation +1 added lines, -1 removed lines

@@ -6,5 +6,5 @@
 
 class LumberjackHiddenStub extends LumberjackStub implements TestOnly
 {
-    private static $show_in_sitetree = false;
+	private static $show_in_sitetree = false;
 }

tests/Stub/SiteTree/LumberjackStub.php

Indentation +1 added lines, -1 removed lines

@@ -8,5 +8,5 @@
 
 class LumberjackStub extends SiteTree implements TestOnly
 {
-    private static $extensions = [Lumberjack::class];
+	private static $extensions = [Lumberjack::class];
 }

src/Model/Lumberjack.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\CMS\Model\SiteTreeExtension;
 use SilverStripe\Control\Controller;
-use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\GridField\GridField;

Indentation +142 added lines, -142 removed lines

@@ -25,158 +25,158 @@
  */
 class Lumberjack extends SiteTreeExtension
 {
-    /**
-     * Loops through subclasses of the owner (intended to be SiteTree) and checks if they've been hidden.
-     *
-     * @return array
-     **/
-    public function getExcludedSiteTreeClassNames()
-    {
-        $classes = array();
-        $siteTreeClasses = $this->owner->allowedChildren();
-        foreach ($siteTreeClasses as $class) {
-            if (Config::inst()->get($class, 'show_in_sitetree') === false) {
-                $classes[$class] = $class;
-            }
-        }
-        return $classes;
-    }
+	/**
+	 * Loops through subclasses of the owner (intended to be SiteTree) and checks if they've been hidden.
+	 *
+	 * @return array
+	 **/
+	public function getExcludedSiteTreeClassNames()
+	{
+		$classes = array();
+		$siteTreeClasses = $this->owner->allowedChildren();
+		foreach ($siteTreeClasses as $class) {
+			if (Config::inst()->get($class, 'show_in_sitetree') === false) {
+				$classes[$class] = $class;
+			}
+		}
+		return $classes;
+	}
 
-    /**
-     * This is responsible for adding the child pages tab and gridfield.
-     *
-     * @param FieldList $fields
-     */
-    public function updateCMSFields(FieldList $fields)
-    {
-        $excluded = $this->owner->getExcludedSiteTreeClassNames();
-        if (!empty($excluded)) {
-            $pages = $this->getLumberjackPagesForGridfield($excluded);
-            $gridField = GridField::create(
-                'ChildPages',
-                $this->getLumberjackTitle(),
-                $pages,
-                $this->getLumberjackGridFieldConfig()
-            );
+	/**
+	 * This is responsible for adding the child pages tab and gridfield.
+	 *
+	 * @param FieldList $fields
+	 */
+	public function updateCMSFields(FieldList $fields)
+	{
+		$excluded = $this->owner->getExcludedSiteTreeClassNames();
+		if (!empty($excluded)) {
+			$pages = $this->getLumberjackPagesForGridfield($excluded);
+			$gridField = GridField::create(
+				'ChildPages',
+				$this->getLumberjackTitle(),
+				$pages,
+				$this->getLumberjackGridFieldConfig()
+			);
 
-            $tab = Tab::create('ChildPages', $this->getLumberjackTitle(), $gridField);
-            $fields->insertAfter($tab, 'Main');
-        }
-    }
+			$tab = Tab::create('ChildPages', $this->getLumberjackTitle(), $gridField);
+			$fields->insertAfter($tab, 'Main');
+		}
+	}
 
-    /**
-     * Augments (@link Hierarchy::stageChildren()}
-     *
-     * @param boolean $showAll Include all of the elements, even those not shown in the menus.
-     *   (only applicable when extension is applied to {@link SiteTree}).
-     * @return DataList
-     */
-    public function stageChildren($showAll = false)
-    {
-        $baseClass = $this->owner->baseClass();
-        $staged = $baseClass::get()
-            ->filter('ParentID', (int)$this->owner->ID)
-            ->exclude('ID', (int)$this->owner->ID);
-        if (!$showAll && $this->owner->dbObject('ShowInMenus')) {
-            $staged = $staged->filter('ShowInMenus', 1);
-        }
-        $this->owner->extend('augmentStageChildren', $staged, $showAll);
+	/**
+	 * Augments (@link Hierarchy::stageChildren()}
+	 *
+	 * @param boolean $showAll Include all of the elements, even those not shown in the menus.
+	 *   (only applicable when extension is applied to {@link SiteTree}).
+	 * @return DataList
+	 */
+	public function stageChildren($showAll = false)
+	{
+		$baseClass = $this->owner->baseClass();
+		$staged = $baseClass::get()
+			->filter('ParentID', (int)$this->owner->ID)
+			->exclude('ID', (int)$this->owner->ID);
+		if (!$showAll && $this->owner->dbObject('ShowInMenus')) {
+			$staged = $staged->filter('ShowInMenus', 1);
+		}
+		$this->owner->extend('augmentStageChildren', $staged, $showAll);
 
-        if ($this->shouldFilter()) {
-            // Filter the SiteTree
-            return $staged->exclude('ClassName', $this->owner->getExcludedSiteTreeClassNames());
-        }
-        return $staged;
-    }
+		if ($this->shouldFilter()) {
+			// Filter the SiteTree
+			return $staged->exclude('ClassName', $this->owner->getExcludedSiteTreeClassNames());
+		}
+		return $staged;
+	}
 
-    /**
-     * Augments (@link Hierarchy::liveChildren()} by hiding excluded child classnames
-     *
-     * @param boolean $showAll Include all of the elements, even those not shown in the menus.
-     *   (only applicable when extension is applied to {@link SiteTree}).
-     * @param boolean $onlyDeletedFromStage Only return items that have been deleted from stage
-     * @return SS_List
-     */
-    public function liveChildren($showAll = false, $onlyDeletedFromStage = false)
-    {
-        $baseClass = $this->owner->baseClass();
-        $children = $baseClass::get()
-            ->filter('ParentID', (int)$this->owner->ID)
-            ->exclude('ID', (int)$this->owner->ID)
-            ->setDataQueryParam(array(
-                'Versioned.mode' => $onlyDeletedFromStage ? 'stage_unique' : 'stage',
-                'Versioned.stage' => 'Live'
-            ));
+	/**
+	 * Augments (@link Hierarchy::liveChildren()} by hiding excluded child classnames
+	 *
+	 * @param boolean $showAll Include all of the elements, even those not shown in the menus.
+	 *   (only applicable when extension is applied to {@link SiteTree}).
+	 * @param boolean $onlyDeletedFromStage Only return items that have been deleted from stage
+	 * @return SS_List
+	 */
+	public function liveChildren($showAll = false, $onlyDeletedFromStage = false)
+	{
+		$baseClass = $this->owner->baseClass();
+		$children = $baseClass::get()
+			->filter('ParentID', (int)$this->owner->ID)
+			->exclude('ID', (int)$this->owner->ID)
+			->setDataQueryParam(array(
+				'Versioned.mode' => $onlyDeletedFromStage ? 'stage_unique' : 'stage',
+				'Versioned.stage' => 'Live'
+			));
 
-        if (!$showAll) {
-            $children = $children->filter('ShowInMenus', 1);
-        }
+		if (!$showAll) {
+			$children = $children->filter('ShowInMenus', 1);
+		}
 
-        if ($this->shouldFilter()) {
-            // Filter the SiteTree
-            return $children->exclude('ClassName', $this->owner->getExcludedSiteTreeClassNames());
-        }
-        return $children;
-    }
+		if ($this->shouldFilter()) {
+			// Filter the SiteTree
+			return $children->exclude('ClassName', $this->owner->getExcludedSiteTreeClassNames());
+		}
+		return $children;
+	}
 
-    /**
-     * This returns the title for the tab and GridField. This can be overwritten
-     * in the owner class.
-     *
-     * @return string
-     */
-    protected function getLumberjackTitle()
-    {
-        if (method_exists($this->owner, 'getLumberjackTitle')) {
-            return $this->owner->getLumberjackTitle();
-        }
-        return _t('Lumberjack.TabTitle', 'Child Pages');
-    }
+	/**
+	 * This returns the title for the tab and GridField. This can be overwritten
+	 * in the owner class.
+	 *
+	 * @return string
+	 */
+	protected function getLumberjackTitle()
+	{
+		if (method_exists($this->owner, 'getLumberjackTitle')) {
+			return $this->owner->getLumberjackTitle();
+		}
+		return _t('Lumberjack.TabTitle', 'Child Pages');
+	}
 
-    /**
-     * This returns the gird field config for the lumberjack gridfield.
-     *
-     * @return GridFieldConfig
-     */
-    protected function getLumberjackGridFieldConfig()
-    {
-        if (method_exists($this->owner, 'getLumberjackGridFieldConfig')) {
-            return $this->owner->getLumberjackGridFieldConfig();
-        }
-        return GridFieldConfig_Lumberjack::create();
-    }
+	/**
+	 * This returns the gird field config for the lumberjack gridfield.
+	 *
+	 * @return GridFieldConfig
+	 */
+	protected function getLumberjackGridFieldConfig()
+	{
+		if (method_exists($this->owner, 'getLumberjackGridFieldConfig')) {
+			return $this->owner->getLumberjackGridFieldConfig();
+		}
+		return GridFieldConfig_Lumberjack::create();
+	}
 
-    /**
-     * Checks if we're on a controller where we should filter. ie. Are we loading the SiteTree?
-     *
-     * @return bool
-     */
-    protected function shouldFilter()
-    {
-        $controller = Controller::curr();
-        return $controller instanceof LeftAndMain
-            && in_array($controller->getAction(), array('treeview', 'listview', 'getsubtree'));
-    }
+	/**
+	 * Checks if we're on a controller where we should filter. ie. Are we loading the SiteTree?
+	 *
+	 * @return bool
+	 */
+	protected function shouldFilter()
+	{
+		$controller = Controller::curr();
+		return $controller instanceof LeftAndMain
+			&& in_array($controller->getAction(), array('treeview', 'listview', 'getsubtree'));
+	}
 
-    /**
-     * Returns list of pages for the CMS gridfield
-     *
-     * This also allows the owner class to override this method, e.g. to provide custom ordering.
-     *
-     * @var array $excluded     List of class names excluded from the SiteTree
-     * @return DataList
-     */
-    public function getLumberjackPagesForGridfield($excluded = array())
-    {
-        if (method_exists($this->owner, 'getLumberjackPagesForGridfield')) {
-            return $this->owner->getLumberjackPagesForGridfield($excluded);
-        }
+	/**
+	 * Returns list of pages for the CMS gridfield
+	 *
+	 * This also allows the owner class to override this method, e.g. to provide custom ordering.
+	 *
+	 * @var array $excluded     List of class names excluded from the SiteTree
+	 * @return DataList
+	 */
+	public function getLumberjackPagesForGridfield($excluded = array())
+	{
+		if (method_exists($this->owner, 'getLumberjackPagesForGridfield')) {
+			return $this->owner->getLumberjackPagesForGridfield($excluded);
+		}
 
-        return SiteTree::get()->filter(
-            array(
-                'ParentID' => $this->owner->ID,
-                'ClassName' => $excluded,
-            )
-        );
-    }
+		return SiteTree::get()->filter(
+			array(
+				'ParentID' => $this->owner->ID,
+				'ClassName' => $excluded,
+			)
+		);
+	}
 }