Completed
Pull Request — master (#173)
by Robbie
01:56
created
code/search/FullTextSearch.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use SilverStripe\Core\ClassInfo;
5 5
 use SilverStripe\Core\Config\Config;
6
-use SilverStripe\ORM\DataObject;
7 6
 use SilverStripe\FullTextSearch\Search\Indexes\SearchIndex;
8 7
 use ReflectionClass;
9 8
 
Please login to merge, or discard this patch.
code/search/updaters/SearchUpdater.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use SilverStripe\Core\Config\Configurable;
6 6
 use SilverStripe\Core\Injector\Injector;
7
-use SilverStripe\Dev\SapphireTest;
8 7
 use SilverStripe\ORM\DataObject;
9 8
 use SilverStripe\ORM\DB;
10 9
 use SilverStripe\FullTextSearch\Search\FullTextSearch;
Please login to merge, or discard this patch.
code/search/variants/SearchVariant.php 2 patches
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -151,6 +151,7 @@  discard block
 block discarded – undo
151 151
      * A shortcut to with when calling without passing in a class,
152 152
      *
153 153
      * SearchVariant::call(...) ==== SearchVariant::with()->call(...);
154
+     * @param string $method
154 155
      */
155 156
     public static function call($method, &$a1 = null, &$a2 = null, &$a3 = null, &$a4 = null, &$a5 = null, &$a6 = null, &$a7 = null)
156 157
     {
@@ -160,6 +161,7 @@  discard block
 block discarded – undo
160 161
     /**
161 162
      * Get the current state of every variant
162 163
      * @static
164
+     * @param string $class
163 165
      * @return array
164 166
      */
165 167
     public static function current_state($class = null, $includeSubclasses = true)
@@ -193,7 +195,7 @@  discard block
 block discarded – undo
193 195
      * @static
194 196
      * @param string $class - The class name to get variants for
195 197
      * @param bool $includeSubclasses - True if variants should be included if they apply to at least one subclass of $class
196
-     * @return SearchVariant_ReindexStateIteratorRet - The iterator to foreach loop over
198
+     * @return \Traversable - The iterator to foreach loop over
197 199
      */
198 200
     public static function reindex_states($class = null, $includeSubclasses = true)
199 201
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\FullTextSearch\Search\Variants;
4 4
 
5
-use SilverStripe\ORM\DataObject;
6 5
 use SilverStripe\Core\ClassInfo;
7 6
 use SilverStripe\FullTextSearch\Utils\CombinationsArrayIterator;
8 7
 use ReflectionClass;
Please login to merge, or discard this patch.
code/search/variants/SearchVariantSubsites.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@  discard block
 block discarded – undo
19 19
         return class_exists('Subsite');
20 20
     }
21 21
 
22
+    /**
23
+     * @param boolean $includeSubclasses
24
+     */
22 25
     public function appliesTo($class, $includeSubclasses)
23 26
     {
24 27
         // Include all DataExtensions that contain a SubsiteID.
@@ -135,7 +138,7 @@  discard block
 block discarded – undo
135 138
     /**
136 139
      * Determine if a field with a certain name is filtered by the search query or on the index
137 140
      * This is the equivalent of saying "show me the results that do ONLY contain this value"
138
-     * @param $field string name of the field being filtered
141
+     * @param string $field string name of the field being filtered
139 142
      * @param $query SearchQuery currently being executed
140 143
      * @param $index SearchIndex which specifies a filter field
141 144
      * @return bool true if $field is being filtered, false if it is not being filtered
Please login to merge, or discard this patch.
code/search/variants/SearchVariantVersioned.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -10,6 +10,9 @@
 block discarded – undo
10 10
 
11 11
 class SearchVariantVersioned extends SearchVariant
12 12
 {
13
+    /**
14
+     * @param boolean $includeSubclasses
15
+     */
13 16
     public function appliesTo($class, $includeSubclasses)
14 17
     {
15 18
         return SearchIntrospection::has_extension($class, Versioned::class, $includeSubclasses);
Please login to merge, or discard this patch.
code/solr/services/Solr4Service_Core.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -38,6 +38,7 @@
 block discarded – undo
38 38
     /**
39 39
      * Solr 4.0 compat http://wiki.apache.org/solr/UpdateXmlMessages#Optional_attributes_for_.22add.22
40 40
      * Remove allowDups, overwritePending and overwriteComitted
41
+     * @param \Apache_Solr_Document[] $documents
41 42
      */
42 43
     public function addDocuments(
43 44
         $documents,
Please login to merge, or discard this patch.
code/solr/SolrIndex.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
      * @param string $forceType The type to force this field as (required in some cases, when not
291 291
      * detectable from metadata)
292 292
      * @param array $extraOptions Dependent on search implementation
293
-     * @param float $boost Numeric boosting value (defaults to 2)
293
+     * @param integer $boost Numeric boosting value (defaults to 2)
294 294
      */
295 295
     public function addBoostedField($field, $forceType = null, $extraOptions = array(), $boost = 2)
296 296
     {
@@ -299,6 +299,9 @@  discard block
 block discarded – undo
299 299
     }
300 300
 
301 301
 
302
+    /**
303
+     * @param string $field
304
+     */
302 305
     public function fieldData($field, $forceType = null, $extraOptions = array())
303 306
     {
304 307
         // Ensure that 'boost' is recorded here without being captured by solr
@@ -558,6 +561,9 @@  discard block
 block discarded – undo
558 561
         }
559 562
     }
560 563
 
564
+    /**
565
+     * @param string $base
566
+     */
561 567
     protected function _addAs($object, $base, $options)
562 568
     {
563 569
         $includeSubs = $options['include_children'];
Please login to merge, or discard this patch.
code/solr/tasks/Solr_Reindex.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 use ReflectionClass;
5 5
 use SilverStripe\Core\ClassInfo;
6 6
 use SilverStripe\Core\Injector\Injector;
7
-use SilverStripe\Dev\Debug;
8 7
 use SilverStripe\FullTextSearch\Search\Variants\SearchVariant;
9 8
 use SilverStripe\ORM\DataList;
10 9
 use SilverStripe\FullTextSearch\Solr\Reindex\Handlers\SolrReindexHandler;
Please login to merge, or discard this patch.
code/utils/WebDAV.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -3,6 +3,9 @@  discard block
 block discarded – undo
3 3
 
4 4
 class WebDAV
5 5
 {
6
+    /**
7
+     * @param string $method
8
+     */
6 9
     public static function curl_init($url, $method)
7 10
     {
8 11
         $ch = curl_init($url);
@@ -46,6 +49,9 @@  discard block
 block discarded – undo
46 49
         return $code == 201;
47 50
     }
48 51
 
52
+    /**
53
+     * @param resource $handle
54
+     */
49 55
     public static function put($handle, $url)
50 56
     {
51 57
         $ch = curl_init($url);
@@ -70,6 +76,9 @@  discard block
 block discarded – undo
70 76
         return self::put($fh, $url);
71 77
     }
72 78
 
79
+    /**
80
+     * @param string $url
81
+     */
73 82
     public static function upload_from_file($string, $url)
74 83
     {
75 84
         return self::put(fopen($string, 'rb'), $url);
Please login to merge, or discard this patch.