Completed
Pull Request — master (#5173)
by Damian
16:27 queued 04:55
created
control/RequestHandler.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,6 +121,7 @@  discard block
 block discarded – undo
121 121
 
122 122
 	/**
123 123
 	 * Set the DataModel for this request.
124
+	 * @param DataModel $model
124 125
 	 */
125 126
 	public function setDataModel($model) {
126 127
 		$this->model = $model;
@@ -238,6 +239,9 @@  discard block
 block discarded – undo
238 239
 		return $this;
239 240
 	}
240 241
 
242
+	/**
243
+	 * @param SS_HTTPRequest $request
244
+	 */
241 245
 	protected function findAction($request) {
242 246
 		$handlerClass = ($this->class) ? $this->class : get_class($this);
243 247
 
@@ -271,7 +275,7 @@  discard block
 block discarded – undo
271 275
 	 *
272 276
 	 * Must not raise SS_HTTPResponse_Exceptions - instead it should return
273 277
 	 *
274
-	 * @param $request
278
+	 * @param SS_HTTPRequest $request
275 279
 	 * @param $action
276 280
 	 * @return SS_HTTPResponse
277 281
 	 */
@@ -384,6 +388,7 @@  discard block
 block discarded – undo
384 388
 
385 389
 	/**
386 390
 	 * Return the class that defines the given action, so that we know where to check allowed_actions.
391
+	 * @return string|null
387 392
 	 */
388 393
 	protected function definingClassForAction($actionOrigCasing) {
389 394
 		$action = strtolower($actionOrigCasing);
@@ -493,6 +498,7 @@  discard block
 block discarded – undo
493 498
 	 * or {@link handleRequest()}, but in some based we want to set it manually.
494 499
 	 *
495 500
 	 * @param SS_HTTPRequest
501
+	 * @param SS_HTTPRequest $request
496 502
 	 */
497 503
 	public function setRequest($request) {
498 504
 		$this->request = $request;
Please login to merge, or discard this patch.