Completed
Pull Request — master (#7037)
by Damian
10:59
created
src/Core/Manifest/ClassManifest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@
 block discarded – undo
259 259
      * Returns an array containing all the descendants (direct and indirect)
260 260
      * of a class.
261 261
      *
262
-     * @param  string|object $class
262
+     * @param  string $class
263 263
      * @return array
264 264
      */
265 265
     public function getDescendantsOf($class)
Please login to merge, or discard this patch.
src/Security/BasicAuth.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
      * @param string|array $permissionCode Optional
60 60
      * @param boolean $tryUsingSessionLogin If true, then the method with authenticate against the
61 61
      *  session log-in if those credentials are disabled.
62
-     * @return bool|Member
62
+     * @return null|Member
63 63
      * @throws HTTPResponse_Exception
64 64
      */
65 65
     public static function requireLogin(
Please login to merge, or discard this patch.
src/Control/Email/Email.php 1 patch
Doc Comments   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -201,12 +201,12 @@  discard block
 block discarded – undo
201 201
 
202 202
     /**
203 203
      * Email constructor.
204
-     * @param string|array|null $from
205
-     * @param string|array|null $to
204
+     * @param string $from
205
+     * @param string $to
206 206
      * @param string|null $subject
207 207
      * @param string|null $body
208
-     * @param string|array|null $cc
209
-     * @param string|array|null $bcc
208
+     * @param string $cc
209
+     * @param string $bcc
210 210
      * @param string|null $returnPath
211 211
      */
212 212
     public function __construct(
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
     }
293 293
 
294 294
     /**
295
-     * @param string|array $address
295
+     * @param string $address
296 296
      * @param string|null $name
297 297
      * @return $this
298 298
      */
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
     }
370 370
 
371 371
     /**
372
-     * @param string|array $address
372
+     * @param string $address
373 373
      * @param string|null $name
374 374
      * @return $this
375 375
      */
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     }
402 402
 
403 403
     /**
404
-     * @param string|array $address
404
+     * @param string $address
405 405
      * @param string|null $name
406 406
      * @return $this
407 407
      */
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
     }
434 434
 
435 435
     /**
436
-     * @param string|array $address
436
+     * @param string $address
437 437
      * @param string|null $name
438 438
      * @return $this
439 439
      */
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
     }
451 451
 
452 452
     /**
453
-     * @param string|array $address
453
+     * @param string $address
454 454
      * @param string|null $name
455 455
      * @return $this
456 456
      */
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
     }
463 463
 
464 464
     /**
465
-     * @param string|array $address
465
+     * @param string $address
466 466
      * @param string|null $name
467 467
      * @return $this
468 468
      */
@@ -568,7 +568,7 @@  discard block
 block discarded – undo
568 568
     }
569 569
 
570 570
     /**
571
-     * @param string|array $name The data name to add or array to names => value
571
+     * @param string $name The data name to add or array to names => value
572 572
      * @param string|null $value The value of the data to add
573 573
      * @return $this
574 574
      */
@@ -739,7 +739,7 @@  discard block
 block discarded – undo
739 739
     }
740 740
 
741 741
     /**
742
-     * @return array|bool
742
+     * @return boolean
743 743
      */
744 744
     public function sendPlain()
745 745
     {
@@ -795,7 +795,7 @@  discard block
 block discarded – undo
795 795
     }
796 796
 
797 797
     /**
798
-     * @return Swift_MimePart|false
798
+     * @return \Swift_Mime_MimeEntity
799 799
      */
800 800
     public function findPlainPart()
801 801
     {
Please login to merge, or discard this patch.
src/Core/Startup/ParameterConfirmationToken.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
      */
48 48
     protected $token = null;
49 49
 
50
+    /**
51
+     * @param string $token
52
+     */
50 53
     protected function pathForToken($token)
51 54
     {
52 55
         return TEMP_FOLDER.'/token_'.preg_replace('/[^a-z0-9]+/', '', $token);
@@ -222,7 +225,7 @@  discard block
 block discarded – undo
222 225
      * Given a list of token names, suppress all tokens that have not been validated, and
223 226
      * return the non-validated token with the highest priority
224 227
      *
225
-     * @param array $keys List of token keys in ascending priority (low to high)
228
+     * @param string[] $keys List of token keys in ascending priority (low to high)
226 229
      * @param HTTPRequest $request
227 230
      * @return ParameterConfirmationToken The token container for the unvalidated $key given with the highest priority
228 231
      */
Please login to merge, or discard this patch.
src/Dev/BulkLoader.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -141,6 +141,10 @@
 block discarded – undo
141 141
 	 *
142 142
 	 * @return BulkLoader_Result See {@link self::processAll()}
143 143
 	 */
144
+
145
+    /**
146
+     * @param string $filepath
147
+     */
144 148
     public function load($filepath)
145 149
     {
146 150
         Environment::increaseTimeLimitTo(3600);
Please login to merge, or discard this patch.
src/Dev/Install/Installer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -284,6 +284,9 @@
 block discarded – undo
284 284
         return $this->errors;
285 285
     }
286 286
 
287
+    /**
288
+     * @param string $filename
289
+     */
287 290
     public function writeToFile($filename, $content)
288 291
     {
289 292
         $base = $this->getBaseDir();
Please login to merge, or discard this patch.
src/Dev/Install/InstallRequirements.php 1 patch
Doc Comments   +76 added lines, -2 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 
152 152
     /**
153 153
      * Find the webserver software running on the PHP host.
154
-     * @return string|boolean Server software or boolean FALSE
154
+     * @return false|string Server software or boolean FALSE
155 155
      */
156 156
     public function findWebserver()
157 157
     {
@@ -447,6 +447,10 @@  discard block
 block discarded – undo
447 447
         return $this->errors;
448 448
     }
449 449
 
450
+    /**
451
+     * @param string $settingName
452
+     * @param string[] $testDetails
453
+     */
450 454
     public function suggestPHPSetting($settingName, $settingValues, $testDetails)
451 455
     {
452 456
         $this->testing($testDetails);
@@ -465,6 +469,11 @@  discard block
 block discarded – undo
465 469
         }
466 470
     }
467 471
 
472
+    /**
473
+     * @param string $settingName
474
+     * @param false[] $settingValues
475
+     * @param string[] $testDetails
476
+     */
468 477
     public function requirePHPSetting($settingName, $settingValues, $testDetails)
469 478
     {
470 479
         $this->testing($testDetails);
@@ -475,6 +484,10 @@  discard block
 block discarded – undo
475 484
         }
476 485
     }
477 486
 
487
+    /**
488
+     * @param string $class
489
+     * @param string[] $testDetails
490
+     */
478 491
     public function suggestClass($class, $testDetails)
479 492
     {
480 493
         $this->testing($testDetails);
@@ -484,6 +497,10 @@  discard block
 block discarded – undo
484 497
         }
485 498
     }
486 499
 
500
+    /**
501
+     * @param string $class
502
+     * @param string[] $testDetails
503
+     */
487 504
     public function suggestFunction($class, $testDetails)
488 505
     {
489 506
         $this->testing($testDetails);
@@ -493,6 +510,9 @@  discard block
 block discarded – undo
493 510
         }
494 511
     }
495 512
 
513
+    /**
514
+     * @param string[] $testDetails
515
+     */
496 516
     public function requireDateTimezone($testDetails)
497 517
     {
498 518
         $this->testing($testDetails);
@@ -503,6 +523,11 @@  discard block
 block discarded – undo
503 523
         }
504 524
     }
505 525
 
526
+    /**
527
+     * @param integer $min
528
+     * @param integer $recommended
529
+     * @param string[] $testDetails
530
+     */
506 531
     public function requireMemory($min, $recommended, $testDetails)
507 532
     {
508 533
         $_SESSION['forcemem'] = false;
@@ -617,6 +642,10 @@  discard block
 block discarded – undo
617 642
         }
618 643
     }
619 644
 
645
+    /**
646
+     * @param string $funcName
647
+     * @param string[] $testDetails
648
+     */
620 649
     public function requireFunction($funcName, $testDetails)
621 650
     {
622 651
         $this->testing($testDetails);
@@ -628,6 +657,10 @@  discard block
 block discarded – undo
628 657
         return true;
629 658
     }
630 659
 
660
+    /**
661
+     * @param string $className
662
+     * @param string[] $testDetails
663
+     */
631 664
     public function requireClass($className, $testDetails)
632 665
     {
633 666
         $this->testing($testDetails);
@@ -674,6 +707,10 @@  discard block
 block discarded – undo
674 707
         return true;
675 708
     }
676 709
 
710
+    /**
711
+     * @param string $recommendedVersion
712
+     * @param string $requiredVersion
713
+     */
677 714
     public function requirePHPVersion($recommendedVersion, $requiredVersion, $testDetails)
678 715
     {
679 716
         $this->testing($testDetails);
@@ -717,7 +754,7 @@  discard block
 block discarded – undo
717 754
      * to ensure the module directory is intact.
718 755
      *
719 756
      * @param string $dirname
720
-     * @param array $testDetails
757
+     * @param string[] $testDetails
721 758
      */
722 759
     public function requireModule($dirname, $testDetails)
723 760
     {
@@ -733,6 +770,10 @@  discard block
 block discarded – undo
733 770
         }
734 771
     }
735 772
 
773
+    /**
774
+     * @param string $filename
775
+     * @param string[] $testDetails
776
+     */
736 777
     public function requireFile($filename, $testDetails)
737 778
     {
738 779
         $this->testing($testDetails);
@@ -743,6 +784,9 @@  discard block
 block discarded – undo
743 784
         }
744 785
     }
745 786
 
787
+    /**
788
+     * @param string $filename
789
+     */
746 790
     public function requireWriteable($filename, $testDetails, $absolute = false)
747 791
     {
748 792
         $this->testing($testDetails);
@@ -851,6 +895,10 @@  discard block
 block discarded – undo
851 895
         }
852 896
     }
853 897
 
898
+    /**
899
+     * @param string $moduleName
900
+     * @param string[] $testDetails
901
+     */
854 902
     public function requireApacheRewriteModule($moduleName, $testDetails)
855 903
     {
856 904
         $this->testing($testDetails);
@@ -871,6 +919,10 @@  discard block
 block discarded – undo
871 919
         return ($this->testApacheRewriteExists() || $this->testIISRewriteModuleExists());
872 920
     }
873 921
 
922
+    /**
923
+     * @param string $moduleName
924
+     * @param string[] $testDetails
925
+     */
874 926
     public function requireIISRewriteModule($moduleName, $testDetails)
875 927
     {
876 928
         $this->testing($testDetails);
@@ -898,6 +950,9 @@  discard block
 block discarded – undo
898 950
         return DatabaseAdapterRegistry::getDatabaseConfigurationHelper($databaseClass);
899 951
     }
900 952
 
953
+    /**
954
+     * @param string[] $testDetails
955
+     */
901 956
     public function requireDatabaseFunctions($databaseConfig, $testDetails)
902 957
     {
903 958
         $this->testing($testDetails);
@@ -915,6 +970,9 @@  discard block
 block discarded – undo
915 970
         }
916 971
     }
917 972
 
973
+    /**
974
+     * @param string[] $testDetails
975
+     */
918 976
     public function requireDatabaseConnection($databaseConfig, $testDetails)
919 977
     {
920 978
         $this->testing($testDetails);
@@ -929,6 +987,9 @@  discard block
 block discarded – undo
929 987
         }
930 988
     }
931 989
 
990
+    /**
991
+     * @param string[] $testDetails
992
+     */
932 993
     public function requireDatabaseVersion($databaseConfig, $testDetails)
933 994
     {
934 995
         $this->testing($testDetails);
@@ -961,6 +1022,9 @@  discard block
 block discarded – undo
961 1022
         }
962 1023
     }
963 1024
 
1025
+    /**
1026
+     * @param string[] $testDetails
1027
+     */
964 1028
     public function requireDatabaseOrCreatePermissions($databaseConfig, $testDetails)
965 1029
     {
966 1030
         $this->testing($testDetails);
@@ -986,6 +1050,9 @@  discard block
 block discarded – undo
986 1050
         }
987 1051
     }
988 1052
 
1053
+    /**
1054
+     * @param string[] $testDetails
1055
+     */
989 1056
     public function requireDatabaseAlterPermissions($databaseConfig, $testDetails)
990 1057
     {
991 1058
         $this->testing($testDetails);
@@ -1001,6 +1068,10 @@  discard block
 block discarded – undo
1001 1068
         }
1002 1069
     }
1003 1070
 
1071
+    /**
1072
+     * @param string[] $varNames
1073
+     * @param string[] $testDetails
1074
+     */
1004 1075
     public function requireServerVariables($varNames, $testDetails)
1005 1076
     {
1006 1077
         $this->testing($testDetails);
@@ -1022,6 +1093,9 @@  discard block
 block discarded – undo
1022 1093
     }
1023 1094
 
1024 1095
 
1096
+    /**
1097
+     * @param string[] $testDetails
1098
+     */
1025 1099
     public function requirePostSupport($testDetails)
1026 1100
     {
1027 1101
         $this->testing($testDetails);
Please login to merge, or discard this patch.
src/Dev/SapphireTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -775,7 +775,7 @@  discard block
 block discarded – undo
775 775
      * @param string $expectedSQL
776 776
      * @param string $actualSQL
777 777
      * @param string $message
778
-     * @param float|int $delta
778
+     * @param integer $delta
779 779
      * @param integer $maxDepth
780 780
      * @param boolean $canonicalize
781 781
      * @param boolean $ignoreCase
@@ -1074,7 +1074,7 @@  discard block
 block discarded – undo
1074 1074
      * Create a member and group with the given permission code, and log in with it.
1075 1075
      * Returns the member ID.
1076 1076
      *
1077
-     * @param string|array $permCode Either a permission, or list of permissions
1077
+     * @param string $permCode Either a permission, or list of permissions
1078 1078
      * @return int Member ID
1079 1079
      */
1080 1080
     public function logInWithPermission($permCode = "ADMIN")
Please login to merge, or discard this patch.
src/includes/functions.php 1 patch
Doc Comments   -6 removed lines patch added patch discarded remove patch
@@ -53,12 +53,6 @@
 block discarded – undo
53 53
  * @param string $entity Entity that identifies the string. It must be in the form
54 54
  * "Namespace.Entity" where Namespace will be usually the class name where this
55 55
  * string is used and Entity identifies the string inside the namespace.
56
- * @param mixed $arg,... Additional arguments are parsed as such:
57
- *  - Next string argument is a default. Pass in a `|` pipe-delimeted value with `{count}`
58
- *    to do pluralisation.
59
- *  - Any other string argument after default is context for i18nTextCollector
60
- *  - Any array argument in any order is an injection parameter list. Pass in a `count`
61
- *    injection parameter to pluralise.
62 56
  * @return string
63 57
  */
64 58
 function _t($entity, $arg = null)
Please login to merge, or discard this patch.