Completed
Pull Request — master (#6518)
by Loz
08:07
created
src/ORM/ArrayList.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      * Returns an Iterator for this ArrayList.
81 81
      * This function allows you to use ArrayList in foreach loops
82 82
      *
83
-     * @return ArrayIterator
83
+     * @return \Generator
84 84
      */
85 85
     public function getIterator()
86 86
     {
@@ -746,7 +746,7 @@  discard block
 block discarded – undo
746 746
     /**
747 747
      * Returns item stored in list with index $key
748 748
      *
749
-     * @param mixed $offset
749
+     * @param integer $offset
750 750
      * @return DataObject
751 751
      */
752 752
     public function offsetGet($offset)
Please login to merge, or discard this patch.
src/ORM/Map.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,6 +46,7 @@  discard block
 block discarded – undo
46 46
      * Set the key field for this map.
47 47
      *
48 48
      * @var string $keyField
49
+     * @param string $keyField
49 50
      */
50 51
     public function setKeyField($keyField)
51 52
     {
@@ -56,6 +57,7 @@  discard block
 block discarded – undo
56 57
      * Set the value field for this map.
57 58
      *
58 59
      * @var string $valueField
60
+     * @param string $valueField
59 61
      */
60 62
     public function setValueField($valueField)
61 63
     {
@@ -105,6 +107,7 @@  discard block
 block discarded – undo
105 107
      *
106 108
      * @var string $key
107 109
      * @var mixed $value
110
+     * @param string $value
108 111
      * @return $this
109 112
      */
110 113
     public function unshift($key, $value)
@@ -126,6 +129,7 @@  discard block
 block discarded – undo
126 129
      *
127 130
      * @var string $key
128 131
      * @var mixed $value
132
+     * @param string $value
129 133
      * @return $this
130 134
      */
131 135
     public function push($key, $value)
@@ -255,7 +259,7 @@  discard block
 block discarded – undo
255 259
      *
256 260
      * Satisfies the IteratorAggreagte interface.
257 261
      *
258
-     * @return Map_Iterator
262
+     * @return \Generator
259 263
      */
260 264
     public function getIterator()
261 265
     {
Please login to merge, or discard this patch.
src/ORM/DataList.php 1 patch
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -541,7 +541,7 @@  discard block
 block discarded – undo
541 541
      * Check if the given field specification could be interpreted as an unquoted relation name
542 542
      *
543 543
      * @param string $field
544
-     * @return bool
544
+     * @return integer
545 545
      */
546 546
     protected function isValidRelationName($field)
547 547
     {
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
654 654
      * @param int $order A numerical index to control the order that joins are added to the query; lower order values
655 655
      * will cause the query to appear first. The default is 20, and joins created automatically by the
656 656
      * ORM have a value of 10.
657
-     * @param array $parameters Any additional parameters if the join is a parameterised subquery
657
+     * @param string[] $parameters Any additional parameters if the join is a parameterised subquery
658 658
      * @return static
659 659
      */
660 660
     public function innerJoin($table, $onClause, $alias = null, $order = 20, $parameters = array())
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
      * @param int $order A numerical index to control the order that joins are added to the query; lower order values
674 674
      * will cause the query to appear first. The default is 20, and joins created automatically by the
675 675
      * ORM have a value of 10.
676
-     * @param array $parameters Any additional parameters if the join is a parameterised subquery
676
+     * @param string[] $parameters Any additional parameters if the join is a parameterised subquery
677 677
      * @return static
678 678
      */
679 679
     public function leftJoin($table, $onClause, $alias = null, $order = 20, $parameters = array())
@@ -799,7 +799,7 @@  discard block
 block discarded – undo
799 799
      * Returns an Iterator for this DataList.
800 800
      * This function allows you to use DataLists in foreach loops
801 801
      *
802
-     * @return Generator
802
+     * @return \Generator
803 803
      */
804 804
     public function getIterator()
805 805
     {
@@ -822,7 +822,7 @@  discard block
 block discarded – undo
822 822
      * Return the maximum value of the given field in this DataList
823 823
      *
824 824
      * @param string $fieldName
825
-     * @return mixed
825
+     * @return string
826 826
      */
827 827
     public function max($fieldName)
828 828
     {
@@ -833,7 +833,7 @@  discard block
 block discarded – undo
833 833
      * Return the minimum value of the given field in this DataList
834 834
      *
835 835
      * @param string $fieldName
836
-     * @return mixed
836
+     * @return string
837 837
      */
838 838
     public function min($fieldName)
839 839
     {
@@ -844,7 +844,7 @@  discard block
 block discarded – undo
844 844
      * Return the average value of the given field in this DataList
845 845
      *
846 846
      * @param string $fieldName
847
-     * @return mixed
847
+     * @return string
848 848
      */
849 849
     public function avg($fieldName)
850 850
     {
@@ -855,7 +855,7 @@  discard block
 block discarded – undo
855 855
      * Return the sum of the values of the given field in this DataList
856 856
      *
857 857
      * @param string $fieldName
858
-     * @return mixed
858
+     * @return string
859 859
      */
860 860
     public function sum($fieldName)
861 861
     {
@@ -914,7 +914,7 @@  discard block
 block discarded – undo
914 914
     /**
915 915
      * Restrict the columns to fetch into this DataList
916 916
      *
917
-     * @param array $queriedColumns
917
+     * @param string[] $queriedColumns
918 918
      * @return static
919 919
      */
920 920
     public function setQueriedColumns($queriedColumns)
@@ -1160,7 +1160,7 @@  discard block
 block discarded – undo
1160 1160
     /**
1161 1161
      * Returns item stored in list with index $key
1162 1162
      *
1163
-     * @param mixed $key
1163
+     * @param integer $key
1164 1164
      * @return DataObject
1165 1165
      */
1166 1166
     public function offsetGet($key)
Please login to merge, or discard this patch.