Completed
Push — pulls/3/auto-index-sort ( 593032...8a6bcc )
by Daniel
14:57 queued 05:58
created
model/DataObject.php 1 patch
Doc Comments   +14 added lines, -6 removed lines patch added patch discarded remove patch
@@ -385,6 +385,7 @@  discard block
 block discarded – undo
385 385
 	/**
386 386
 	 * Returns a list of all the composite if the given db field on the class is a composite field.
387 387
 	 * Will check all applicable ancestor classes and aggregate results.
388
+	 * @param string $class
388 389
 	 */
389 390
 	public static function composite_fields($class, $aggregated = true) {
390 391
 		if(!isset(DataObject::$_cache_composite_fields[$class])) self::cache_composite_fields($class);
@@ -552,7 +553,7 @@  discard block
 block discarded – undo
552 553
 	 * The destinationObject must be written to the database already and have an ID. Writing is performed
553 554
 	 * automatically when adding the new relations.
554 555
 	 *
555
-	 * @param $sourceObject the source object to duplicate from
556
+	 * @param DataObject $sourceObject the source object to duplicate from
556 557
 	 * @param $destinationObject the destination object to populate with the duplicated relations
557 558
 	 * @return DataObject with the new many_many relations copied in
558 559
 	 */
@@ -959,6 +960,7 @@  discard block
 block discarded – undo
959 960
 	 * @param $includeRelations Boolean Merge any existing relations (optional)
960 961
 	 * @param $overwriteWithEmpty Boolean Overwrite existing left values with empty right values.
961 962
 	 *                            Only applicable with $priority='right'. (optional)
963
+	 * @param DataObject|null $rightObj
962 964
 	 * @return Boolean
963 965
 	 */
964 966
 	public function merge($rightObj, $priority = 'right', $includeRelations = true, $overwriteWithEmpty = false) {
@@ -1582,10 +1584,10 @@  discard block
 block discarded – undo
1582 1584
 	 *
1583 1585
 	 * @param string $componentName Name of the component
1584 1586
 	 * @param string|null $filter Deprecated. A filter to be inserted into the WHERE clause
1585
-	 * @param string|null|array $sort Deprecated. A sort expression to be inserted into the ORDER BY clause. If omitted,
1587
+	 * @param string $sort Deprecated. A sort expression to be inserted into the ORDER BY clause. If omitted,
1586 1588
 	 *                                the static field $default_sort on the component class will be used.
1587 1589
 	 * @param string $join Deprecated, use leftJoin($table, $joinClause) instead
1588
-	 * @param string|null|array $limit Deprecated. A limit expression to be inserted into the LIMIT clause
1590
+	 * @param string $limit Deprecated. A limit expression to be inserted into the LIMIT clause
1589 1591
 	 *
1590 1592
 	 * @return HasManyList The components of the one-to-many relationship.
1591 1593
 	 */
@@ -2211,6 +2213,7 @@  discard block
 block discarded – undo
2211 2213
 	 *
2212 2214
 	 * This is experimental, and is currently only a Postgres-specific enhancement.
2213 2215
 	 *
2216
+	 * @param string $class
2214 2217
 	 * @return array or false
2215 2218
 	 */
2216 2219
 	public function database_extensions($class){
@@ -2678,7 +2681,7 @@  discard block
 block discarded – undo
2678 2681
 	 * can be saved into the Image table.
2679 2682
 	 *
2680 2683
 	 * @param string $fieldName Name of the field
2681
-	 * @param mixed $value New field value
2684
+	 * @param mixed $val New field value
2682 2685
 	 * @return DataObject $this
2683 2686
 	 */
2684 2687
 	public function setCastedField($fieldName, $val) {
@@ -2698,6 +2701,7 @@  discard block
 block discarded – undo
2698 2701
 
2699 2702
 	/**
2700 2703
 	 * {@inheritdoc}
2704
+	 * @param string $field
2701 2705
 	 */
2702 2706
 	public function castingHelper($field) {
2703 2707
 		if ($fieldSpec = $this->db($field)) {
@@ -3062,6 +3066,7 @@  discard block
 block discarded – undo
3062 3066
 	 * The path to the related field is specified with dot separated syntax (eg: Parent.Child.Child.FieldName)
3063 3067
 	 *
3064 3068
 	 * @param $fieldPath string
3069
+	 * @param string $fieldName
3065 3070
 	 * @return string | null - will return null on a missing value
3066 3071
 	 */
3067 3072
 	public function relField($fieldName) {
@@ -3130,7 +3135,7 @@  discard block
 block discarded – undo
3130 3135
 	 * @param string $callerClass The class of objects to be returned
3131 3136
 	 * @param string|array $filter A filter to be inserted into the WHERE clause.
3132 3137
 	 * Supports parameterised queries. See SQLQuery::addWhere() for syntax examples.
3133
-	 * @param string|array $sort A sort expression to be inserted into the ORDER
3138
+	 * @param string $sort A sort expression to be inserted into the ORDER
3134 3139
 	 * BY clause.  If omitted, self::$default_sort will be used.
3135 3140
 	 * @param string $join Deprecated 3.0 Join clause. Use leftJoin($table, $joinClause) instead.
3136 3141
 	 * @param string|array $limit A limit expression to be inserted into the LIMIT clause.
@@ -3181,6 +3186,7 @@  discard block
 block discarded – undo
3181 3186
 
3182 3187
 	/**
3183 3188
 	 * @deprecated
3189
+	 * @param string $class
3184 3190
 	 */
3185 3191
 	public function Aggregate($class = null) {
3186 3192
 		Deprecation::notice('4.0', 'Call aggregate methods on a DataList directly instead. In templates'
@@ -3202,6 +3208,7 @@  discard block
 block discarded – undo
3202 3208
 
3203 3209
 	/**
3204 3210
 	 * @deprecated
3211
+	 * @param string $relationship
3205 3212
 	 */
3206 3213
 	public function RelationshipAggregate($relationship) {
3207 3214
 		Deprecation::notice('4.0', 'Call aggregate methods on a relationship directly instead.');
@@ -3370,6 +3377,7 @@  discard block
 block discarded – undo
3370 3377
 
3371 3378
 	/**
3372 3379
 	 * @see $sourceQueryParams
3380
+	 * @param string $key
3373 3381
 	 * @return Mixed
3374 3382
 	 */
3375 3383
 	public function getSourceQueryParam($key) {
@@ -3433,7 +3441,7 @@  discard block
 block discarded – undo
3433 3441
 	 * Parses a specified column into a sort field and direction
3434 3442
 	 *
3435 3443
 	 * @param string $column String to parse containing the column name
3436
-	 * @return array Resolved table and column.
3444
+	 * @return string[] Resolved table and column.
3437 3445
 	 */
3438 3446
 	protected function parseSortColumn($column) {
3439 3447
 		// Parse column specification, considering possible ansi sql quoting
Please login to merge, or discard this patch.