Completed
Pull Request — master (#6829)
by Sam
19:37 queued 04:58
created
src/Security/MemberAuthenticator/Authenticator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,8 +50,8 @@
 block discarded – undo
50 50
      * Attempt to find and authenticate member if possible from the given data
51 51
      *
52 52
      * @param array $data
53
-     * @param Form $form
54 53
      * @param bool &$success Success flag
54
+     * @param string $message
55 55
      * @return Member Found member, regardless of successful login
56 56
      */
57 57
     protected function authenticateMember($data, &$message, &$success)
Please login to merge, or discard this patch.
src/Security/MemberAuthenticator/LoginHandler.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -130,6 +130,7 @@
 block discarded – undo
130 130
      * )
131 131
      *
132 132
      * @param array $data
133
+     * @param LoginHandler $formHandler
133 134
      * @return HTTPResponse
134 135
      */
135 136
     protected function logInUserAndRedirect($data, $formHandler)
Please login to merge, or discard this patch.
src/Security/MemberAuthenticator/LostPasswordHandler.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,6 +55,7 @@  discard block
 block discarded – undo
55 55
     /**
56 56
      * Return a link to this request handler.
57 57
      * The link returned is supplied in the constructor
58
+     * @param string $action
58 59
      * @return string
59 60
      */
60 61
     public function link($action = null)
@@ -115,7 +116,7 @@  discard block
 block discarded – undo
115 116
      * Factory method for the lost password form
116 117
      *
117 118
      * @skipUpgrade
118
-     * @return Form Returns the lost password form
119
+     * @return LoginForm Returns the lost password form
119 120
      */
120 121
     public function lostPasswordForm()
121 122
     {
@@ -247,6 +248,8 @@  discard block
 block discarded – undo
247 248
 
248 249
     /**
249 250
      * @todo copypaste from FormRequestHandler - refactor
251
+     * @param string $link
252
+     * @return string
250 253
      */
251 254
     protected function addBackURLParam($link)
252 255
     {
Please login to merge, or discard this patch.
src/Security/Security.php 1 patch
Doc Comments   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -565,8 +565,7 @@  discard block
 block discarded – undo
565 565
     /**
566 566
      * Combine the given forms into a formset with a tabbed interface
567 567
      *
568
-     * @param array $authenticators List of Authenticator instances
569
-     * @return string
568
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
570 569
      */
571 570
     protected function generateLoginFormSet($forms)
572 571
     {
@@ -756,7 +755,7 @@  discard block
 block discarded – undo
756 755
 
757 756
     /**
758 757
      * Render the given fragments into a security page controller with the given title.
759
-     * @param $title string The title to give the security page
758
+     * @param string $title string The title to give the security page
760 759
      * @param $fragments A map of objects to render into the page, e.g. "Form"
761 760
      * @param $templates An array of templates to use for the render
762 761
      */
@@ -923,7 +922,7 @@  discard block
 block discarded – undo
923 922
      * Factory method for the lost password form
924 923
      *
925 924
      * @skipUpgrade
926
-     * @return ChangePasswordForm Returns the lost password form
925
+     * @return MemberAuthenticator\ChangePasswordForm Returns the lost password form
927 926
      */
928 927
     public function ChangePasswordForm()
929 928
     {
@@ -1234,7 +1233,7 @@  discard block
 block discarded – undo
1234 1233
     /**
1235 1234
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
1236 1235
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
1237
-     * @param $flag True or false
1236
+     * @param boolean $flag True or false
1238 1237
      */
1239 1238
     public static function set_ignore_disallowed_actions($flag)
1240 1239
     {
Please login to merge, or discard this patch.