silverstripe / silverstripe-framework

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -311,7 +311,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -336,7 +336,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Forms/DatetimeField.php

Doc Comments +7 added lines, -4 removed lines

@@ -140,7 +140,7 @@ 
     }
 
     /**
-     * @param $bool
+     * @param boolean $bool
      * @return $this
      */
     public function setHTML5($bool)
@@ -153,7 +153,7 @@ 
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -341,7 +341,7 @@ 
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
      * Falls back to an ISO 8601 string (with a whitespace separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -456,7 +456,7 @@ 
      * Tidy up the internal date representation (ISO 8601),
      * and fall back to strtotime() if there's parsing errors.
      *
-     * @param string $date Date in ISO 8601 or approximate form
+     * @param string $datetime
      * @return string ISO 8601 date, or null if not valid
      */
     public function tidyInternal($datetime)
@@ -551,6 +551,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);

src/Security/CMSSecurity.php

Doc Comments +6 added lines

@@ -49,6 +49,9 @@ 
         return parent::login($request, Authenticator::CMS_LOGIN); // TODO: Change the autogenerated stub
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         /** @skipUpgrade */
@@ -79,6 +82,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $title
+     */
     public function getResponseController($title)
     {
         // Use $this to prevent use of Page to render underlying templates

src/Security/MemberAuthenticator/Authenticator.php

Doc Comments +1 added lines

@@ -53,6 +53,7 @@
      * @param $message
      * @param bool &$success Success flag
      * @param null|Member $member If the parent method already identified the member, it can be passed in
+     * @param null|boolean $success
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$message, &$success, $member = null)

src/Security/MemberAuthenticator/LoginHandler.php

Doc Comments +2 added lines, -1 removed lines

@@ -135,7 +135,6 @@ 
      *   [Optional: 'Remember' => 1 ]
      * )
      *
-     * @param array $data
      * @return HTTPResponse
      */
     protected function redirectAfterSuccessfulLogin()
@@ -217,6 +216,7 @@ 
      * Try to authenticate the user
      *
      * @param array $data Submitted data
+     * @param Member $member
      * @return Member Returns the member object on successful authentication
      *                or NULL on failure.
      */
@@ -246,6 +246,7 @@ 
 
     /**
      * @todo copypaste from FormRequestHandler - refactor
+     * @param string $link
      */
     protected function addBackURLParam($link)
     {

src/Security/Security.php

Doc Comments +3 added lines, -3 removed lines

@@ -564,8 +564,7 @@ 
     /**
      * Combine the given forms into a formset with a tabbed interface
      *
-     * @param array $authenticators List of Authenticator instances
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -1204,6 +1203,7 @@ 
 
     /**
      * For the database_is_ready call to return a certain value - used for testing
+     * @param boolean $isReady
      */
     public static function force_database_is_ready($isReady)
     {
@@ -1247,7 +1247,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {