Completed
Pull Request — master (#6829)
by Simon
07:30
created
src/Security/MemberAuthenticator/LostPasswordHandler.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,6 +55,7 @@  discard block
 block discarded – undo
55 55
     /**
56 56
      * Return a link to this request handler.
57 57
      * The link returned is supplied in the constructor
58
+     * @param string $action
58 59
      * @return string
59 60
      */
60 61
     public function link($action = null)
@@ -115,7 +116,7 @@  discard block
 block discarded – undo
115 116
      * Factory method for the lost password form
116 117
      *
117 118
      * @skipUpgrade
118
-     * @return Form Returns the lost password form
119
+     * @return LoginForm Returns the lost password form
119 120
      */
120 121
     public function lostPasswordForm()
121 122
     {
@@ -247,6 +248,8 @@  discard block
 block discarded – undo
247 248
 
248 249
     /**
249 250
      * @todo copypaste from FormRequestHandler - refactor
251
+     * @param string $link
252
+     * @return string
250 253
      */
251 254
     protected function addBackURLParam($link)
252 255
     {
Please login to merge, or discard this patch.
src/Security/CMSSecurity.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -49,6 +49,9 @@  discard block
 block discarded – undo
49 49
         return parent::login($request, Authenticator::CMS_LOGIN); // TODO: Change the autogenerated stub
50 50
     }
51 51
 
52
+    /**
53
+     * @param string $action
54
+     */
52 55
     public function Link($action = null)
53 56
     {
54 57
         /** @skipUpgrade */
@@ -79,6 +82,9 @@  discard block
 block discarded – undo
79 82
         return null;
80 83
     }
81 84
 
85
+    /**
86
+     * @param string $title
87
+     */
82 88
     public function getResponseController($title)
83 89
     {
84 90
         // Use $this to prevent use of Page to render underlying templates
Please login to merge, or discard this patch.
src/Security/MemberAuthenticator/Authenticator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -53,6 +53,7 @@
 block discarded – undo
53 53
      * @param $message
54 54
      * @param bool &$success Success flag
55 55
      * @param null|Member $member If the parent method already identified the member, it can be passed in
56
+     * @param null|boolean $success
56 57
      * @return Member Found member, regardless of successful login
57 58
      */
58 59
     protected function authenticateMember($data, &$message, &$success, $member = null)
Please login to merge, or discard this patch.
src/Security/MemberAuthenticator/LoginHandler.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -135,7 +135,6 @@  discard block
 block discarded – undo
135 135
      *   [Optional: 'Remember' => 1 ]
136 136
      * )
137 137
      *
138
-     * @param array $data
139 138
      * @return HTTPResponse
140 139
      */
141 140
     protected function redirectAfterSuccessfulLogin()
@@ -217,6 +216,7 @@  discard block
 block discarded – undo
217 216
      * Try to authenticate the user
218 217
      *
219 218
      * @param array $data Submitted data
219
+     * @param Member $member
220 220
      * @return Member Returns the member object on successful authentication
221 221
      *                or NULL on failure.
222 222
      */
@@ -246,6 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
     /**
248 248
      * @todo copypaste from FormRequestHandler - refactor
249
+     * @param string $link
249 250
      */
250 251
     protected function addBackURLParam($link)
251 252
     {
Please login to merge, or discard this patch.
src/Security/Security.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -564,8 +564,7 @@  discard block
 block discarded – undo
564 564
     /**
565 565
      * Combine the given forms into a formset with a tabbed interface
566 566
      *
567
-     * @param array $authenticators List of Authenticator instances
568
-     * @return string
567
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
569 568
      */
570 569
     protected function generateLoginFormSet($forms)
571 570
     {
@@ -1204,6 +1203,7 @@  discard block
 block discarded – undo
1204 1203
 
1205 1204
     /**
1206 1205
      * For the database_is_ready call to return a certain value - used for testing
1206
+     * @param boolean $isReady
1207 1207
      */
1208 1208
     public static function force_database_is_ready($isReady)
1209 1209
     {
@@ -1247,7 +1247,7 @@  discard block
 block discarded – undo
1247 1247
     /**
1248 1248
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
1249 1249
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
1250
-     * @param $flag True or false
1250
+     * @param boolean $flag True or false
1251 1251
      */
1252 1252
     public static function set_ignore_disallowed_actions($flag)
1253 1253
     {
Please login to merge, or discard this patch.