Completed
Pull Request — master (#5232)
by Loz
10:25
created
view/ViewableData.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	/**
145 145
 	 * Get the current failover object if set
146 146
 	 *
147
-	 * @return ViewableData|null
147
+	 * @return ViewableData
148 148
 	 */
149 149
 	public function getFailover() {
150 150
 		return $this->failover;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 	 *  - castingHelper: the casting helper for casting the field (e.g. "return new Varchar($fieldName)")
248 248
 	 *
249 249
 	 * @param string $field
250
-	 * @return array
250
+	 * @return string
251 251
 	 */
252 252
 	public function castingHelperPair($field) {
253 253
 		Deprecation::notice('2.5', 'use castingHelper() instead');
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 	 *
340 340
 	 * @param string|array|SSViewer $template the template to render into
341 341
 	 * @param array $customFields fields to customise() the object with before rendering
342
-	 * @return HTMLText
342
+	 * @return DBField
343 343
 	 */
344 344
 	public function renderWith($template, $customFields = null) {
345 345
 		if(!is_object($template)) {
@@ -499,6 +499,7 @@  discard block
 block discarded – undo
499 499
 	
500 500
 	/**
501 501
 	 * Return the value of a field in an SQL-safe format.
502
+	 * @param string $field
502 503
 	 */
503 504
 	public function SQL_val($field, $arguments = null, $cache = true) {
504 505
 		return Convert::raw2sql($this->RAW_val($field, $arguments, $cache));
@@ -506,6 +507,7 @@  discard block
 block discarded – undo
506 507
 	
507 508
 	/**
508 509
 	 * Return the value of a field in a JavaScript-save format.
510
+	 * @param string $field
509 511
 	 */
510 512
 	public function JS_val($field, $arguments = null, $cache = true) {
511 513
 		return Convert::raw2js($this->RAW_val($field, $arguments, $cache));
@@ -513,6 +515,7 @@  discard block
 block discarded – undo
513 515
 	
514 516
 	/**
515 517
 	 * Return the value of a field escaped suitable to be inserted into an XML node attribute.
518
+	 * @param string $field
516 519
 	 */
517 520
 	public function ATT_val($field, $arguments = null, $cache = true) {
518 521
 		return Convert::raw2att($this->RAW_val($field, $arguments, $cache));
@@ -523,7 +526,6 @@  discard block
 block discarded – undo
523 526
 	/**
524 527
 	 * Get an array of XML-escaped values by field name
525 528
 	 *
526
-	 * @param array $elements an array of field names
527 529
 	 * @return array
528 530
 	 */
529 531
 	public function getXMLValues($fields) {
Please login to merge, or discard this patch.