Completed
Pull Request — master (#3926)
by Daniel
11:58
created
control/RequestHandler.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -121,6 +121,7 @@  discard block
 block discarded – undo
121 121
 	
122 122
 	/**
123 123
 	 * Set the DataModel for this request.
124
+	 * @param DataModel $model
124 125
 	 */
125 126
 	public function setDataModel($model) {
126 127
 		$this->model = $model;
@@ -238,6 +239,9 @@  discard block
 block discarded – undo
238 239
 		return $this;
239 240
 	}
240 241
 
242
+	/**
243
+	 * @param SS_HTTPRequest $request
244
+	 */
241 245
 	protected function findAction($request) {
242 246
 		$handlerClass = ($this->class) ? $this->class : get_class($this);
243 247
 
@@ -384,6 +388,7 @@  discard block
 block discarded – undo
384 388
 
385 389
 	/**
386 390
 	 * Return the class that defines the given action, so that we know where to check allowed_actions.
391
+	 * @return string|null
387 392
 	 */
388 393
 	protected function definingClassForAction($actionOrigCasing) {
389 394
 		$action = strtolower($actionOrigCasing);
Please login to merge, or discard this patch.
control/Controller.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -132,6 +132,7 @@  discard block
 block discarded – undo
132 132
 	 * {@inheritdoc}
133 133
 	 *
134 134
 	 * Also set the URLParams
135
+	 * @param SS_HTTPRequest $request
135 136
 	 */
136 137
 	public function setRequest($request) {
137 138
 		$return = parent::setRequest($request);
@@ -496,7 +497,7 @@  discard block
 block discarded – undo
496 497
 	 *
497 498
 	 * @param array $params
498 499
 	 *
499
-	 * @return string
500
+	 * @return HTMLText
500 501
 	 */
501 502
 	public function render($params = null) {
502 503
 		$template = $this->getViewer($this->getAction());
@@ -661,7 +662,7 @@  discard block
 block discarded – undo
661 662
 	 * Tests whether a redirection has been requested. If redirect() has been called, it will return
662 663
 	 * the URL redirected to. Otherwise, it will return null.
663 664
 	 *
664
-	 * @return null|string
665
+	 * @return boolean
665 666
 	 */
666 667
 	public function redirectedTo() {
667 668
 		return $this->getResponse() && $this->getResponse()->getHeader('Location');
Please login to merge, or discard this patch.