Completed
Pull Request — master (#5875)
by Damian
40:28 queued 29:49
created
ORM/DataQuery.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	/**
91 91
 	 * Remove a filter from the query
92 92
 	 *
93
-	 * @param string|array $fieldExpression The predicate of the condition to remove
93
+	 * @param string|null $fieldExpression The predicate of the condition to remove
94 94
 	 * (ignoring parameters). The expression will be considered a match if it's
95 95
 	 * contained within any other predicate.
96 96
 	 * @return DataQuery Self reference
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	/**
170 170
 	 * Ensure that the query is ready to execute.
171 171
 	 *
172
-	 * @param array|null $queriedColumns Any columns to filter the query by
172
+	 * @param string[] $queriedColumns Any columns to filter the query by
173 173
 	 * @return SQLSelect The finalised sql query
174 174
 	 */
175 175
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -1033,6 +1033,9 @@  discard block
 block discarded – undo
1033 1033
 	 */
1034 1034
 	protected $whereQuery;
1035 1035
 
1036
+	/**
1037
+	 * @param string $connective
1038
+	 */
1036 1039
 	public function __construct(DataQuery $base, $connective) {
1037 1040
 		parent::__construct($base->dataClass);
1038 1041
 		$this->query = $base->query;
@@ -1042,6 +1045,9 @@  discard block
 block discarded – undo
1042 1045
 		$base->where($this);
1043 1046
 	}
1044 1047
 
1048
+	/**
1049
+	 * @param string $filter
1050
+	 */
1045 1051
 	public function where($filter) {
1046 1052
 		if($filter) {
1047 1053
 			$this->whereQuery->addWhere($filter);
Please login to merge, or discard this patch.