silverstripe / silverstripe-framework

Completed

Push — master ( e2b0c5...f862ce )

by Sam

created 2017-04-18 04:58 UTC

Changes

	94 issues (26 major, 56 minor, 12 informational) were introduced. 95 issues were fixed.
	2 added classes/operations
		A	CMSMemberLoginForm::getAuthenticatorName() added
		A	MemberLoginForm::getAuthenticatorName() added
A	↘	B	Security::getAuthenticator() got worse

6.89

▶ ± 0

Head	Simon Erkelens 2017-04-14 15:30 GMT+1200 Pass the AuthenticationMethod to the controller Resolves issue #6788 The AuthenticationMethed is passed in via hidden field as per usual, but due to changes, the fallback authenticator was always the MemberAuthenticator and the actual passed in authenticator was defaulting to an empty string. This causes an issue when there are multiple authenticators and the default authenticator is _not_ in the allowed authenticators, but is still the default. It caused the getAuthenticator method to return the default MemberAuthenticator to be returned, despite it being disabled. A second issue around multiple authenticators, was the template using a no-longer used method `getAuthenticatorName`. This method returned a null on the default MemberLoginForm (as nothing was set), causing a Warning. Because the getAuthenticator and getAuthenticatorName are no longer in use, I've opted to replace these with a translatable string `getAuthenticatorName`, to display the title of the form on the tabs, as per the tabset on Security_MultiAuthenticatorLogin template.
Base	Damian Mooyman 2017-04-17 23:24 UTC Merge pull request #6791 from caffeineinc/master