Completed
Pull Request — master (#4748)
by Michael
12:56
created
core/Config.php 1 patch
Doc Comments   +17 added lines, -10 removed lines patch added patch discarded remove patch
@@ -470,11 +470,17 @@  discard block
 block discarded – undo
470 470
 
471 471
 	protected $extraConfigSources = array();
472 472
 
473
+	/**
474
+	 * @param string $class
475
+	 */
473 476
 	public function extraConfigSourcesChanged($class) {
474 477
 		unset($this->extraConfigSources[$class]);
475 478
 		$this->cache->clean("__{$class}");
476 479
 	}
477 480
 
481
+	/**
482
+	 * @param integer $sourceOptions
483
+	 */
478 484
 	protected function getUncached($class, $name, $sourceOptions, &$result, $suppress, &$tags) {
479 485
 		$tags[] = "__{$class}";
480 486
 		$tags[] = "__{$class}__{$name}";
@@ -647,15 +653,6 @@  discard block
 block discarded – undo
647 653
 	 *
648 654
 	 * @param string $class The class to remove a configuration value from
649 655
 	 * @param string $name The configuration name
650
-	 * @param mixed $key An optional key to filter against.
651
-	 *   If referenced config value is an array, only members of that array that match this key will be removed
652
-	 *   Must also match value if provided to be removed
653
-	 * @param mixed $value And optional value to filter against.
654
-	 *   If referenced config value is an array, only members of that array that match this value will be removed
655
-	 *   If referenced config value is not an array, value will be removed only if it matches this argument
656
-	 *   Must also match key if provided and referenced config value is an array to be removed
657
-	 *
658
-	 * Matching is always by "==", not by "==="
659 656
 	 */
660 657
 	public function remove($class, $name /*,$key = null*/ /*,$value = null*/) {
661 658
 		$argc = func_num_args();
@@ -734,6 +731,10 @@  discard block
 block discarded – undo
734 731
 		$this->cache = $cloned;
735 732
 	}
736 733
 
734
+	/**
735
+	 * @param integer $key
736
+	 * @param integer $val
737
+	 */
737 738
 	public function set($key, $val, $tags = array()) {
738 739
 		// Find an index to set at
739 740
 		$replacing = null;
@@ -769,6 +770,9 @@  discard block
 block discarded – undo
769 770
 		return $this->miss ? ($this->hit / $this->miss) : 0;
770 771
 	}
771 772
 
773
+	/**
774
+	 * @param integer $key
775
+	 */
772 776
 	public function get($key) {
773 777
 		if (isset($this->indexing[$key])) {
774 778
 			$this->hit++;
@@ -782,6 +786,9 @@  discard block
 block discarded – undo
782 786
 		return false;
783 787
 	}
784 788
 
789
+	/**
790
+	 * @param string $tag
791
+	 */
785 792
 	public function clean($tag = null) {
786 793
 		if ($tag) {
787 794
 			foreach ($this->cache as $i => $v) {
@@ -938,7 +945,7 @@  discard block
 block discarded – undo
938 945
 	 *
939 946
 	 * @param string $key
940 947
 	 *
941
-	 * @return bool
948
+	 * @return boolean|null
942 949
 	 */
943 950
 	protected function disablePersistentCache($key) {
944 951
 		$this->disabledPersistentCache[$key] = true;
Please login to merge, or discard this patch.