Completed
Pull Request — master (#5943)
by Ingo
11:58
created
admin/code/LeftAndMain.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 	/**
259 259
 	 * Gets the combined configuration of all LeafAndMain subclasses required by the client app.
260 260
 	 *
261
-	 * @return array
261
+	 * @return string
262 262
 	 *
263 263
 	 * WARNING: Experimental API
264 264
 	 */
@@ -691,7 +691,7 @@  discard block
 block discarded – undo
691 691
 	 *
692 692
 	 * @param string $url
693 693
 	 * @param int $code
694
-	 * @return SS_HTTPResponse|string
694
+	 * @return string|null
695 695
 	 */
696 696
 	public function redirect($url, $code=302) {
697 697
 		if($this->getRequest()->isAjax()) {
@@ -969,7 +969,7 @@  discard block
 block discarded – undo
969 969
 	 * {@link SSViewer::get_templates_by_class()}
970 970
 	 *
971 971
 	 * @param string $suffix
972
-	 * @return array
972
+	 * @return string
973 973
 	 */
974 974
 	public function getTemplatesWithSuffix($suffix) {
975 975
 		$templates = SSViewer::get_templates_by_class(get_class($this), $suffix, __CLASS__);
@@ -2039,7 +2039,7 @@  discard block
 block discarded – undo
2039 2039
 	}
2040 2040
 
2041 2041
 	/**
2042
-	 * @return String
2042
+	 * @return DBField
2043 2043
 	 */
2044 2044
 	public function Locale() {
2045 2045
 		return DBField::create_field('Locale', i18n::get_locale());
Please login to merge, or discard this patch.
api/RSSFeed.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -227,6 +227,7 @@
 block discarded – undo
227 227
 	 * via the standard template inclusion process.
228 228
 	 *
229 229
 	 * @param string
230
+	 * @param string|null $template
230 231
 	 */
231 232
 	public function setTemplate($template) {
232 233
 		$this->template = $template;
Please login to merge, or discard this patch.
core/ClassInfo.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,6 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
 	/**
48 48
 	 * @todo Move this to SS_Database or DB
49
+	 * @param string $class
49 50
 	 */
50 51
 	public static function hasTable($class) {
51 52
 		// Cache the list of all table names to reduce on DB traffic
@@ -87,7 +88,7 @@  discard block
 block discarded – undo
87 88
 	 *
88 89
 	 * @todo Move this into {@see DataObjectSchema}
89 90
 	 *
90
-	 * @param string|object $nameOrObject Class or object instance
91
+	 * @param string $nameOrObject Class or object instance
91 92
 	 * @return array
92 93
 	 */
93 94
 	public static function dataClassesFor($nameOrObject) {
@@ -214,6 +215,7 @@  discard block
 block discarded – undo
214 215
 
215 216
 	/**
216 217
 	 * Returns true if the given class implements the given interface
218
+	 * @param string $interfaceName
217 219
 	 */
218 220
 	public static function classImplements($className, $interfaceName) {
219 221
 		return in_array($className, self::implementorsOf($interfaceName));
@@ -264,6 +266,9 @@  discard block
 block discarded – undo
264 266
 
265 267
 	private static $method_from_cache = array();
266 268
 
269
+	/**
270
+	 * @param string $method
271
+	 */
267 272
 	public static function has_method_from($class, $method, $compclass) {
268 273
 		$lClass = strtolower($class);
269 274
 		$lMethod = strtolower($method);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldEditButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 	 * Which columns are handled by this component
57 57
 	 *
58 58
 	 * @param GridField $gridField
59
-	 * @return array
59
+	 * @return string[]
60 60
 	 */
61 61
 	public function getColumnsHandled($gridField) {
62 62
 		return array('Actions');
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 * @param GridField $gridField
77 77
 	 * @param DataObject $record
78 78
 	 * @param string $columnName
79
-	 * @return string The HTML for the column
79
+	 * @return DBHTMLText The HTML for the column
80 80
 	 */
81 81
 	public function getColumnContent($gridField, $record, $columnName) {
82 82
 		// No permission checks, handled through GridFieldDetailForm,
Please login to merge, or discard this patch.
view/SSViewer.php 1 patch
Doc Comments   +12 added lines, -3 removed lines patch added patch discarded remove patch
@@ -370,7 +370,6 @@  discard block
 block discarded – undo
370 370
 	/**
371 371
 	 * Returns the modulus of the numerical position of the item in the data set.
372 372
 	 * The count starts from $startIndex, which defaults to 1.
373
-	 * @param int $Mod The number to perform Mod operation to.
374 373
 	 * @param int $startIndex Number to start count from.
375 374
 	 * @return int
376 375
 	 */
@@ -444,6 +443,10 @@  discard block
 block discarded – undo
444 443
 		$this->underlay = $underlay ? $underlay : array();
445 444
 	}
446 445
 
446
+	/**
447
+	 * @param string $interfaceToQuery
448
+	 * @param string $variableMethod
449
+	 */
447 450
 	protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false) {
448 451
 		$implementers = ClassInfo::implementorsOf($interfaceToQuery);
449 452
 		if($implementers) foreach($implementers as $implementer) {
@@ -1259,7 +1262,7 @@  discard block
 block discarded – undo
1259 1262
 	 * @param string $template Template name
1260 1263
 	 * @param mixed $data Data context
1261 1264
 	 * @param array $arguments Additional arguments
1262
-	 * @return string Evaluated result
1265
+	 * @return DBHTMLText Evaluated result
1263 1266
 	 */
1264 1267
 	public static function execute_template($template, $data, $arguments = null, $scope = null) {
1265 1268
 		$v = new SSViewer($template);
@@ -1285,6 +1288,9 @@  discard block
 block discarded – undo
1285 1288
 		return $v->process($data, $arguments);
1286 1289
 	}
1287 1290
 
1291
+	/**
1292
+	 * @param string $content
1293
+	 */
1288 1294
 	public function parseTemplateContent($content, $template="") {
1289 1295
 		return $this->getParser()->compileString(
1290 1296
 			$content,
@@ -1314,7 +1320,7 @@  discard block
 block discarded – undo
1314 1320
 	 * Return an appropriate base tag for the given template.
1315 1321
 	 * It will be closed on an XHTML document, and unclosed on an HTML document.
1316 1322
 	 *
1317
-	 * @param $contentGeneratedSoFar The content of the template generated so far; it should contain
1323
+	 * @param string $contentGeneratedSoFar The content of the template generated so far; it should contain
1318 1324
 	 * the DOCTYPE declaration.
1319 1325
 	 */
1320 1326
 	public static function get_base_tag($contentGeneratedSoFar) {
@@ -1355,6 +1361,9 @@  discard block
 block discarded – undo
1355 1361
 	 */
1356 1362
 	protected $cacheTemplate;
1357 1363
 
1364
+	/**
1365
+	 * @param string $content
1366
+	 */
1358 1367
 	public function __construct($content, TemplateParser $parser = null) {
1359 1368
 		if ($parser) {
1360 1369
 			$this->setParser($parser);
Please login to merge, or discard this patch.