Completed
Pull Request — 3 (#8086)
by Ingo
09:31 queued 34s
created
control/HTTP.php 1 patch
Doc Comments   +12 added lines, -2 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param string|callable $code Either a string that can evaluate to an expression
100 100
 	 * to rewrite links (depreciated), or a callable that takes a single
101 101
 	 * parameter and returns the rewritten URL
102
-	 * @return The content with all links rewritten as per the logic specified in $code
102
+	 * @return string content with all links rewritten as per the logic specified in $code
103 103
 	 */
104 104
 	public static function urlRewriter($content, $code) {
105 105
 		if(!is_callable($code)) {
@@ -243,6 +243,9 @@  discard block
 block discarded – undo
243 243
 		return count($result) ? $result : null;
244 244
 	}
245 245
 
246
+	/**
247
+	 * @param string $content
248
+	 */
246 249
 	public static function getLinksIn($content) {
247 250
 		return self::findByTagAndAttribute($content, array("a" => "href"));
248 251
 	}
@@ -285,6 +288,7 @@  discard block
 block discarded – undo
285 288
 
286 289
 	/**
287 290
 	 * Set the maximum age of this page in web caches, in seconds
291
+	 * @param integer $age
288 292
 	 */
289 293
 	public static function set_cache_age($age) {
290 294
 		self::$cache_age = $age;
@@ -297,11 +301,17 @@  discard block
 block discarded – undo
297 301
 			self::$modification_date = $timestamp;
298 302
 	}
299 303
 
304
+	/**
305
+	 * @param integer $timestamp
306
+	 */
300 307
 	public static function register_modification_timestamp($timestamp) {
301 308
 		if($timestamp > self::$modification_date)
302 309
 			self::$modification_date = $timestamp;
303 310
 	}
304 311
 
312
+	/**
313
+	 * @param string $etag
314
+	 */
305 315
 	public static function register_etag($etag) {
306 316
 		if (0 !== strpos($etag, '"')) {
307 317
 			$etag = sprintf('"%s"', $etag);
@@ -473,7 +483,7 @@  discard block
 block discarded – undo
473 483
 	}
474 484
 
475 485
 	/**
476
-	 * @param SS_HTTPResponse|string $response
486
+	 * @param null|SS_HTTPResponse $response
477 487
 	 *
478 488
 	 * @return string|false
479 489
 	 */
Please login to merge, or discard this patch.