Completed
Pull Request — master (#6126)
by Simon
11:00
created
Assets/File.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 	 * Check if this file can be modified
413 413
 	 *
414 414
 	 * @param Member $member
415
-	 * @return boolean
415
+	 * @return boolean|string
416 416
 	 */
417 417
 	public function canEdit($member = null) {
418 418
 		if(!$member) {
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
 	 *
433 433
 	 * @param Member $member
434 434
 	 * @param array $context
435
-	 * @return boolean
435
+	 * @return boolean|string
436 436
 	 */
437 437
 	public function canCreate($member = null, $context = array()) {
438 438
 		if(!$member) {
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 	 * Check if this file can be deleted
452 452
 	 *
453 453
 	 * @param Member $member
454
-	 * @return boolean
454
+	 * @return boolean|string
455 455
 	 */
456 456
 	public function canDelete($member = null) {
457 457
 		if(!$member) {
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
 	 *
648 648
 	 * @param string $condition The PHP condition to be evaluated.  The page will be called $item
649 649
 	 * @param array $collator An array, passed by reference, to collect all of the matching descendants.
650
-	 * @return true|null
650
+	 * @return boolean|null
651 651
 	 */
652 652
 	public function collateDescendants($condition, &$collator) {
653 653
 		if($children = $this->Children()) {
@@ -1020,6 +1020,7 @@  discard block
 block discarded – undo
1020 1020
 	 *
1021 1021
 	 * @param String File extension, without dot prefix. Use an asterisk ('*')
1022 1022
 	 * to specify a generic fallback if no mapping is found for an extension.
1023
+	 * @param string $ext
1023 1024
 	 * @return String Classname for a subclass of {@link File}
1024 1025
 	 */
1025 1026
 	public static function get_class_for_file_extension($ext) {
@@ -1163,7 +1164,6 @@  discard block
 block discarded – undo
1163 1164
 	 * Note that the result will not have a leading slash, and should not be used
1164 1165
 	 * with local file paths.
1165 1166
 	 *
1166
-	 * @param string $part,... Parts
1167 1167
 	 * @return string
1168 1168
 	 */
1169 1169
 	public static function join_paths($part = null) {
Please login to merge, or discard this patch.
Forms/HTMLEditor/HTMLEditorField.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	/**
69 69
 	 * Assign a new configuration instance or identifier
70 70
 	 *
71
-	 * @param string|HTMLEditorConfig $config
71
+	 * @param string $config
72 72
 	 * @return $this
73 73
 	 */
74 74
 	public function setEditorConfig($config) {
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	 *
83 83
 	 * @param string $name The internal field name, passed to forms.
84 84
 	 * @param string $title The human-readable field label.
85
-	 * @param mixed $value The value of the field.
85
+	 * @param integer $value The value of the field.
86 86
 	 * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
87 87
 	 */
88 88
 	public function __construct($name, $title = null, $value = '', $config = null) {
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
 		$record->{$this->name} = $htmlValue->getContent();
128 128
 	}
129 129
 
130
+	/**
131
+	 * @param string|null $value
132
+	 */
130 133
 	public function setValue($value) {
131 134
 		// Regenerate links prior to preview, so that the editor can see them.
132 135
 		$value = Image::regenerate_html_links($value);
Please login to merge, or discard this patch.
View/Parsers/EmbedShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	/**
23 23
 	 * Gets the list of shortcodes provided by this handler
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string[]
26 26
 	 */
27 27
 	public static function get_shortcodes()
28 28
 	{
Please login to merge, or discard this patch.
Assets/FileShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	/**
23 23
 	 * Gets the list of shortcodes provided by this handler
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string
26 26
 	 */
27 27
 	public static function get_shortcodes()
28 28
 	{
Please login to merge, or discard this patch.
Assets/ImageShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	/**
23 23
 	 * Gets the list of shortcodes provided by this handler
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string[]
26 26
 	 */
27 27
 	public static function get_shortcodes()
28 28
 	{
Please login to merge, or discard this patch.