Completed
Pull Request — master (#6126)
by Simon
11:00
created
admin/code/LeftAndMain.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     /**
253 253
      * Gets the combined configuration of all LeafAndMain subclasses required by the client app.
254 254
      *
255
-     * @return array
255
+     * @return string
256 256
      *
257 257
      * WARNING: Experimental API
258 258
      */
@@ -639,7 +639,7 @@  discard block
 block discarded – undo
639 639
      *
640 640
      * @param string $url
641 641
      * @param int $code
642
-     * @return HTTPResponse|string
642
+     * @return string|null
643 643
      */
644 644
     public function redirect($url, $code=302) {
645 645
         if($this->getRequest()->isAjax()) {
@@ -917,7 +917,7 @@  discard block
 block discarded – undo
917 917
      * {@link SSViewer::get_templates_by_class()}
918 918
      *
919 919
      * @param string $suffix
920
-     * @return array
920
+     * @return string
921 921
      */
922 922
     public function getTemplatesWithSuffix($suffix) {
923 923
         $templates = SSViewer::get_templates_by_class(get_class($this), $suffix, __CLASS__);
@@ -2000,7 +2000,7 @@  discard block
 block discarded – undo
2000 2000
     }
2001 2001
 
2002 2002
     /**
2003
-     * @return String
2003
+     * @return DBField
2004 2004
      */
2005 2005
     public function Locale() {
2006 2006
         return DBField::create_field('Locale', i18n::get_locale());
Please login to merge, or discard this patch.
View/Parsers/EmbedShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	/**
23 23
 	 * Gets the list of shortcodes provided by this handler
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string[]
26 26
 	 */
27 27
 	public static function get_shortcodes()
28 28
 	{
Please login to merge, or discard this patch.
Assets/FileShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	/**
23 23
 	 * Gets the list of shortcodes provided by this handler
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string
26 26
 	 */
27 27
 	public static function get_shortcodes()
28 28
 	{
Please login to merge, or discard this patch.
Assets/ImageShortcodeProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 	/**
23 23
 	 * Gets the list of shortcodes provided by this handler
24 24
 	 *
25
-	 * @return mixed
25
+	 * @return string[]
26 26
 	 */
27 27
 	public static function get_shortcodes()
28 28
 	{
Please login to merge, or discard this patch.
src/Assets/File.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
      * Check if this file can be modified
424 424
      *
425 425
      * @param Member $member
426
-     * @return boolean
426
+     * @return boolean|string
427 427
      */
428 428
     public function canEdit($member = null)
429 429
     {
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
      *
445 445
      * @param Member $member
446 446
      * @param array $context
447
-     * @return boolean
447
+     * @return boolean|string
448 448
      */
449 449
     public function canCreate($member = null, $context = array())
450 450
     {
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
      * Check if this file can be deleted
465 465
      *
466 466
      * @param Member $member
467
-     * @return boolean
467
+     * @return boolean|string
468 468
      */
469 469
     public function canDelete($member = null)
470 470
     {
@@ -697,7 +697,7 @@  discard block
 block discarded – undo
697 697
      *
698 698
      * @param string $condition The PHP condition to be evaluated.  The page will be called $item
699 699
      * @param array $collator An array, passed by reference, to collect all of the matching descendants.
700
-     * @return true|null
700
+     * @return boolean|null
701 701
      */
702 702
     public function collateDescendants($condition, &$collator)
703 703
     {
@@ -1089,6 +1089,7 @@  discard block
 block discarded – undo
1089 1089
      *
1090 1090
      * @param String File extension, without dot prefix. Use an asterisk ('*')
1091 1091
      * to specify a generic fallback if no mapping is found for an extension.
1092
+     * @param string $ext
1092 1093
      * @return String Classname for a subclass of {@link File}
1093 1094
      */
1094 1095
     public static function get_class_for_file_extension($ext)
@@ -1248,7 +1249,6 @@  discard block
 block discarded – undo
1248 1249
      * Note that the result will not have a leading slash, and should not be used
1249 1250
      * with local file paths.
1250 1251
      *
1251
-     * @param string $part,... Parts
1252 1252
      * @return string
1253 1253
      */
1254 1254
     public static function join_paths($part = null)
Please login to merge, or discard this patch.
src/Assets/Flysystem/AssetAdapter.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@
 block discarded – undo
41 41
         ]
42 42
     );
43 43
 
44
+    /**
45
+     * @param string $root
46
+     */
44 47
     public function __construct($root = null, $writeFlags = LOCK_EX, $linkHandling = self::DISALLOW_LINKS)
45 48
     {
46 49
         // Get root path
Please login to merge, or discard this patch.
src/Assets/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
      * Find the given folder or create it as a database record
63 63
      *
64 64
      * @param string $folderPath Directory path relative to assets root
65
-     * @return Folder|null
65
+     * @return null|\SilverStripe\ORM\DataObject
66 66
      */
67 67
     public static function find_or_make($folderPath)
68 68
     {
Please login to merge, or discard this patch.
src/Assets/GDBackend.php 1 patch
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
      * Check if this image has previously crashed GD when attempting to open it - if it's opened
199 199
      * successfully, the manipulation's cache key is removed.
200 200
      *
201
-     * @param string $arg,... Any number of args that identify this image
201
+     * @param string $arg
202 202
      * @return bool True if failed
203 203
      */
204 204
     public function failedResample($arg = null)
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
     /**
211 211
      * Mark a file as failed
212 212
      *
213
-     * @param string $arg,... Any number of args that identify this image
213
+     * @param string $arg
214 214
      */
215 215
     protected function markFailed($arg = null)
216 216
     {
@@ -221,7 +221,6 @@  discard block
 block discarded – undo
221 221
     /**
222 222
      * Mark a file as succeeded
223 223
      *
224
-     * @param string $arg,... Any number of args that identify this image
225 224
      */
226 225
     protected function markSucceeded($arg = null)
227 226
     {
@@ -378,7 +377,7 @@  discard block
 block discarded – undo
378 377
      * using built-in function. Used when imagerotate function is not available(i.e. Ubuntu)
379 378
      *
380 379
      * @param float $angle Angle in degrees
381
-     * @return static
380
+     * @return null|resource
382 381
      */
383 382
     public function rotatePixelByPixel($angle)
384 383
     {
Please login to merge, or discard this patch.
src/Assets/ImageManipulation.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -804,7 +804,6 @@
 block discarded – undo
804 804
      * Name a variant based on a format with arbitrary parameters
805 805
      *
806 806
      * @param string $format The format name.
807
-     * @param mixed $arg,... Additional arguments
808 807
      * @return string
809 808
      * @throws InvalidArgumentException
810 809
      */
Please login to merge, or discard this patch.