silverstripe / silverstripe-framework

src/Security/MemberAuthenticator/Authenticator.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,8 +50,8 @@
      * Attempt to find and authenticate member if possible from the given data
      *
      * @param array $data
-     * @param Form $form
      * @param bool &$success Success flag
+     * @param string $message
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$message, &$success)

src/Security/MemberAuthenticator/LostPasswordHandler.php

Doc Comments +4 added lines, -1 removed lines

@@ -55,6 +55,7 @@ 
     /**
      * Return a link to this request handler.
      * The link returned is supplied in the constructor
+     * @param string $action
      * @return string
      */
     public function link($action = null)
@@ -115,7 +116,7 @@ 
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return Form Returns the lost password form
+     * @return LoginForm Returns the lost password form
      */
     public function lostPasswordForm()
     {
@@ -247,6 +248,8 @@ 
 
     /**
      * @todo copypaste from FormRequestHandler - refactor
+     * @param string $link
+     * @return string
      */
     protected function addBackURLParam($link)
     {

src/Security/Security.php

Doc Comments +4 added lines, -5 removed lines

@@ -565,8 +565,7 @@ 
     /**
      * Combine the given forms into a formset with a tabbed interface
      *
-     * @param array $authenticators List of Authenticator instances
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -756,7 +755,7 @@ 
 
     /**
      * Render the given fragments into a security page controller with the given title.
-     * @param $title string The title to give the security page
+     * @param string $title string The title to give the security page
      * @param $fragments A map of objects to render into the page, e.g. "Form"
      * @param $templates An array of templates to use for the render
      */
@@ -923,7 +922,7 @@ 
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return ChangePasswordForm Returns the lost password form
+     * @return MemberAuthenticator\ChangePasswordForm Returns the lost password form
      */
     public function ChangePasswordForm()
     {
@@ -1234,7 +1233,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {

src/Security/MemberAuthenticator/LoginHandler.php

Doc Comments -1 removed lines

@@ -133,7 +133,6 @@
      *   [Optional: 'Remember' => 1 ]
      * )
      *
-     * @param array $data
      * @return HTTPResponse
      */
     protected function redirectAfterSuccessfulLogin()