silverstripe / silverstripe-framework

src/Security/MemberAuthenticator/LostPasswordHandler.php

Doc Comments +4 added lines, -1 removed lines

@@ -55,6 +55,7 @@ 
     /**
      * Return a link to this request handler.
      * The link returned is supplied in the constructor
+     * @param string $action
      * @return string
      */
     public function link($action = null)
@@ -115,7 +116,7 @@ 
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return Form Returns the lost password form
+     * @return LoginForm Returns the lost password form
      */
     public function lostPasswordForm()
     {
@@ -247,6 +248,8 @@ 
 
     /**
      * @todo copypaste from FormRequestHandler - refactor
+     * @param string $link
+     * @return string
      */
     protected function addBackURLParam($link)
     {

src/Security/MemberAuthenticator/Authenticator.php

Doc Comments +2 added lines, -1 removed lines

@@ -51,8 +51,8 @@ 
      * Attempt to find and authenticate member if possible from the given data
      *
      * @param array $data
-     * @param Form $form
      * @param bool &$success Success flag
+     * @param string $message
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$message, &$success)
@@ -192,6 +192,7 @@ 
 
     /**
      * @inherit
+     * @param string $link
      */
     public function getLoginHandler($link)
     {

src/Security/Security.php

Doc Comments +9 added lines, -5 removed lines

@@ -573,8 +573,7 @@ 
     /**
      * Combine the given forms into a formset with a tabbed interface
      *
-     * @param array $authenticators List of Authenticator instances
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -640,7 +639,7 @@ 
      * For multiple authenticators, Security_MultiAuthenticatorLogin is used.
      * See getTemplatesFor and getIncludeTemplate for how to override template logic
      *
-     * @param $request
+     * @param HTTPRequest $request
      * @return HTTPResponse|string Returns the "login" page as HTML code.
      * @throws HTTPResponse_Exception
      */
@@ -672,6 +671,10 @@ 
         $handlers = $authenticators;
         array_walk(
             $handlers,
+
+            /**
+             * @param HTTPRequest $auth
+             */
             function (&$auth, $name) use ($link) {
                 $auth = $auth->getLoginHandler(Controller::join_links($link, $name));
             }
@@ -927,7 +930,7 @@ 
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return ChangePasswordForm Returns the lost password form
+     * @return MemberAuthenticator\ChangePasswordForm Returns the lost password form
      */
     public function ChangePasswordForm()
     {
@@ -1212,6 +1215,7 @@ 
 
     /**
      * For the database_is_ready call to return a certain value - used for testing
+     * @param boolean $isReady
      */
     public static function force_database_is_ready($isReady)
     {
@@ -1255,7 +1259,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {

src/Security/MemberAuthenticator/LoginHandler.php

Doc Comments -2 removed lines

@@ -91,7 +91,6 @@ 
      * This method is called when the user clicks on "Log in"
      *
      * @param array $data Submitted data
-     * @param LoginHandler $formHandler
      * @return HTTPResponse
      */
     public function doLogin($data, $form)
@@ -136,7 +135,6 @@ 
      *   [Optional: 'Remember' => 1 ]
      * )
      *
-     * @param array $data
      * @return HTTPResponse
      */
     protected function redirectAfterSuccessfulLogin()