SilverStripe\Forum\Pages\ForumHolder::new_posts_available()

Complexity

Conditions	15
Paths	528

Size

Total Lines	60
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function new_posts_available($id, &$data = array(), $lastVisit = null, $lastPostID = null, $forumID = null, $threadID = null)
    {
        $filter = array();

        // last post viewed
        $filter[] = "\"ForumPage\".\"ParentID\" = '". Convert::raw2sql($id) ."'";
        if ($lastPostID) {

The expression $lastPostID of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $filter[] = "\"Post\".\"ID\" > '". Convert::raw2sql($lastPostID) ."'";
        }
        if ($lastVisit) {

The expression $lastVisit of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $filter[] = "\"Post\".\"Created\" > '". Convert::raw2sql($lastVisit) ."'";
        }
        if ($forumID) {
            $filter[] = "\"Post\".\"ForumID\" = '". Convert::raw2sql($forumID) ."'";
        }
        if ($threadID) {
            $filter[] = "\"ThreadID\" = '". Convert::raw2sql($threadID) ."'";
        }

        $filter = implode(" AND ", $filter);

        $version = DB::query("
			SELECT MAX(\"Post\".\"ID\") AS \"LastID\", MAX(\"Post\".\"Created\") AS \"LastCreated\"
			FROM \"Post\"
			JOIN \"" . ForumHolder::baseForumTable() . "\" AS \"ForumPage\" ON \"Post\".\"ForumID\"=\"ForumPage\".\"ID\"
			WHERE $filter")->first();

        if ($version == false) {
            return false;
        }

        if ($data) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $data['last_id'] = (int)$version['LastID'];
            $data['last_created'] = strtotime($version['LastCreated']);
        }

        $lastVisit = (int) $lastVisit;

        if ($lastVisit <= 0) {
            $lastVisit = false;
        }

        $lastPostID = (int)$lastPostID;
        if ($lastPostID <= 0) {
            $lastPostID = false;
        }

        if (!$lastVisit && !$lastPostID) {

The expression $lastVisit of type false|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

The expression $lastPostID of type false|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            return true;
        }
        if ($lastVisit && (strtotime($version['LastCreated']) > $lastVisit)) {

The expression $lastVisit of type false|integer is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            return true;
        }

        if ($lastPostID && ((int)$version['LastID'] > $lastPostID)) {

The expression $lastPostID of type false|integer is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            return true;
        }

        return false;
    }