View GitHub Repository silverstripe-forum

Schedule Inspection
Subscribe

Code Duplication    Length = 8-8 lines in 2 locations

src/Pages/ForumHolder.php 2 locations

@@ 731-738 (lines=8) @@
728 
                        ->sort('"Member"."Created" ASC')
729 
                        ->limit($SQL_start . ',100');
730 
                break;
731 
            case "name":
732 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID'", "\"Member\".\"Nickname\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
733 
                $members = Member::get()
734 
                        ->filter('Member.GroupID', $forumGroupID)
735 
                        ->leftJoin('Group_Members', '"Member"."ID" = "Group_Members"."MemberID"')
736 
                        ->sort('"Member"."Nickname" ASC')
737 
                        ->limit($SQL_start . ',100');
738 
                break;
739 
            case "country":
740 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID' AND \"Member\".\"CountryPublic\" = TRUE", "\"Member\".\"Country\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
741 
                $members = Member::get()
@@ 739-746 (lines=8) @@
736 
                        ->sort('"Member"."Nickname" ASC')
737 
                        ->limit($SQL_start . ',100');
738 
                break;
739 
            case "country":
740 
//				$members = DataObject::get("Member", "\"GroupID\" = '$forumGroupID' AND \"Member\".\"CountryPublic\" = TRUE", "\"Member\".\"Country\" ASC", "LEFT JOIN \"Group_Members\" ON \"Member\".\"ID\" = \"Group_Members\".\"MemberID\"", "{$SQL_start},100");
741 
                $members = Member::get()
742 
                        ->filter(array('Member.GroupID' => $forumGroupID, 'Member.CountryPublic' => true))
743 
                        ->leftJoin('Group_Members', '"Member"."ID" = "Group_Members"."MemberID"')
744 
                        ->sort('"Member"."Nickname" ASC')
745 
                        ->limit($SQL_start . ',100');
746 
                break;
747 
            case "posts":
748 
                $query = singleton('SilverStripe\\Security\\Member')->extendedSQL('', "\"NumPosts\" DESC", "{$SQL_start},100");
749 
                $query->select[] = "(SELECT COUNT(*) FROM \"Post\" WHERE \"Post\".\"AuthorID\" = \"Member\".\"ID\") AS \"NumPosts\"";