silverstripe / silverstripe-dms

code/model/DMSDocument_versions.php

Doc Comments +2 added lines, -2 removed lines

@@ -197,8 +197,8 @@ 
      * Creates a new filename for the current Document's file when replacing the
      * current file with a new file.
      *
-     * @param DMSDocument $filename The original filename
      *
+     * @param integer $versionCounter
      * @return string The new filename
      */
     protected function generateVersionedFilename(DMSDocument $doc, $versionCounter)
@@ -242,7 +242,7 @@ 
     /**
      * Return the size of the file associated with the document.
      *
-     * @return string
+     * @return integer
      */
     public function getAbsoluteSize()
     {

code/tools/ShortCodeRelationFinder.php

Doc Comments +4 added lines

@@ -32,6 +32,9 @@ 
         return $found;
     }
 
+    /**
+     * @param integer $number
+     */
     public function findPageCount($number)
     {
         $list = $this->getList($number);
@@ -63,6 +66,7 @@ 
      * Returns a filtered list of fields which could contain shortcodes.
      *
      * @param String
+     * @param string $class
      * @return Array Map of class names to an array of field names on these classes.
      */
     public function getShortcodeFields($class)

code/cms/DMSDocumentAddExistingField.php

Doc Comments +4 added lines

@@ -4,6 +4,10 @@
 {
     public $useFieldContext = true;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null)
     {
         $this->name = $name;

tests/Stub/StubRelatedDocumentExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     /**
      * For method {@link DMSDocumentSet::getDocuments}
      *
-     * @param  ArrayList $relatedDocuments
+     * @param  ArrayList $documents
      * @return ArrayList
      */
     public function updateDocuments($documents)

code/cms/DMSUploadField.php

Doc Comments +5 added lines, -1 removed lines

@@ -28,6 +28,7 @@ 
      * Override the default behaviour of the UploadField and take the uploaded file (uploaded to assets) and
      * add it into the DMS storage, deleting the old/uploaded file.
      * @param File
+     * @param File $file
      */
     protected function attachFile($file)
     {
@@ -54,6 +55,9 @@ 
         return $doc;
     }
 
+    /**
+     * @param string $validator
+     */
     public function validate($validator)
     {
         return true;
@@ -63,7 +67,7 @@ 
      * Action to handle upload of a single file
      *
      * @param SS_HTTPRequest $request
-     * @return string json
+     * @return SS_HTTPResponse json
      */
     public function upload(SS_HTTPRequest $request)
     {

code/interface/DMSDocumentInterface.php

Doc Comments +2 added lines, -1 removed lines

@@ -14,6 +14,7 @@ 
 
     /**
      * Return the extension of the file associated with the document
+     * @return string
      */
     public function getExtension();
 
@@ -36,7 +37,7 @@ 
      * Takes a File object or a String (path to a file) and copies it into the DMS, replacing the original document file
      * but keeping the rest of the document unchanged.
      * @param $file File object, or String that is path to a file to store
-     * @return DMSDocumentInstance Document object that we replaced the file in
+     * @return DMSDocument Document object that we replaced the file in
      */
     public function replaceDocument($file);
 

code/model/DMSDocument.php

Doc Comments +6 added lines, -2 removed lines

@@ -98,6 +98,9 @@ 
         'permissions' => 'Permissions'
     );
 
+    /**
+     * @param DataObject $member
+     */
     public function canView($member = null)
     {
         if (!$member || !(is_a($member, 'Member')) || is_numeric($member)) {
@@ -656,7 +659,7 @@ 
      * DMS, replacing the original document file but keeping the rest of the
      * document unchanged.
      *
-     * @param File|string $file path to a file to store
+     * @param File $file path to a file to store
      *
      * @return DMSDocument object that we replaced the file in
      */
@@ -1043,7 +1046,7 @@ 
     /**
      * Return the size of the file associated with the document.
      *
-     * @return string
+     * @return integer|null
      */
     public function getAbsoluteSize()
     {
@@ -1062,6 +1065,7 @@ 
 
 
     /**
+     * @param integer $relationListCount
      * @return FieldList
      */
     protected function getFieldsForFile($relationListCount)

code/DMSShortcodeHandler.php

Doc Comments +4 added lines

@@ -8,6 +8,10 @@
  */
 class DMSShortcodeHandler
 {
+    /**
+     * @param string $content
+     * @param string $tag
+     */
     public static function handle($arguments, $content, ShortcodeParser $parser, $tag, array $extra = array())
     {
         if (!empty($arguments['id'])) {

code/cms/DMSGridFieldEditButton.php

Doc Comments +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
      * @param DataObject $record
      * @param string $columnName
      *
-     * @return string - the HTML for the column
+     * @return HTMLText - the HTML for the column
      */
     public function getColumnContent($gridField, $record, $columnName)
     {