silverstripe / silverstripe-dms

code/model/DMSDocument_versions.php

Doc Comments +2 added lines, -2 removed lines

@@ -197,8 +197,8 @@ 
      * Creates a new filename for the current Document's file when replacing the
      * current file with a new file.
      *
-     * @param DMSDocument $filename The original filename
      *
+     * @param integer $versionCounter
      * @return string The new filename
      */
     protected function generateVersionedFilename(DMSDocument $doc, $versionCounter)
@@ -242,7 +242,7 @@ 
     /**
      * Return the size of the file associated with the document.
      *
-     * @return string
+     * @return integer
      */
     public function getAbsoluteSize()
     {

code/tools/ShortCodeRelationFinder.php

Doc Comments +4 added lines

@@ -32,6 +32,9 @@ 
         return $found;
     }
 
+    /**
+     * @param integer $number
+     */
     public function findPageCount($number)
     {
         $list = $this->getList($number);
@@ -63,6 +66,7 @@ 
      * Returns a filtered list of fields which could contain shortcodes.
      *
      * @param String
+     * @param string $class
      * @return Array Map of class names to an array of field names on these classes.
      */
     public function getShortcodeFields($class)

code/cms/DMSDocumentAddExistingField.php

Doc Comments +4 added lines

@@ -4,6 +4,10 @@
 {
     public $useFieldContext = true;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null)
     {
         $this->name = $name;

code/cms/DMSUploadField.php

Doc Comments +2 added lines, -1 removed lines

@@ -28,6 +28,7 @@ 
      * Override the default behaviour of the UploadField and take the uploaded file (uploaded to assets) and
      * add it into the DMS storage, deleting the old/uploaded file.
      * @param File
+     * @param File $file
      */
     protected function attachFile($file)
     {
@@ -63,7 +64,7 @@ 
      * Action to handle upload of a single file
      *
      * @param SS_HTTPRequest $request
-     * @return string json
+     * @return SS_HTTPResponse json
      */
     public function upload(SS_HTTPRequest $request)
     {

code/DMS.php

Doc Comments +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
 
     /**
      * Creates a storage folder for the given path
-     * @param $path Path to create a folder for
+     * @param string $path Path to create a folder for
      */
     public static function create_storage_folder($path)
     {

code/model/DMSDocument.php

Doc Comments +1 added lines, -5 removed lines

@@ -1409,8 +1409,4 @@
             $valid->error("Selecting 'Only these people' from a editors list needs at least one group selected.");
         }
 
-        return $valid;
-    }
-
-
-}
+        return $valid
\ No newline at end of file

tests/DMSGridFieldAddNewButtonTest.php

Doc Comments +1 added lines, -3 removed lines

@@ -48,6 +48,4 @@
 
         $fragments = $this->button->getHTMLFragments($this->gridField);
         $result = array_pop($fragments)->getValue();
-        $this->assertContains('?ID=123', $result);
-    }
-}
+        $this->assertContains('?ID=123', $result
\ No newline at end of file