silverstripe / silverstripe-dms

code/DMS.php

Doc Comments +5 added lines, -1 removed lines

@@ -36,6 +36,9 @@ 
         return BASE_PATH . DIRECTORY_SEPARATOR . self::$dmsFolder;
     }
 
+    /**
+     * @return string
+     */
     public static function transform_file_to_file_path($file)
     {
         //confirm we have a file
@@ -110,7 +113,7 @@ 
 
     /**
      * Creates a storage folder for the given path
-     * @param $path Path to create a folder for
+     * @param string $path Path to create a folder for
      */
     public static function create_storage_folder($path)
     {
@@ -121,6 +124,7 @@ 
 
     /**
      * Calculates the storage path from a database DMSDocument ID
+     * @param integer $id
      */
     public static function get_storage_folder($id)
     {

code/model/DMSDocument_versions.php

Doc Comments +2 added lines, -2 removed lines

@@ -197,8 +197,8 @@ 
      * Creates a new filename for the current Document's file when replacing the
      * current file with a new file.
      *
-     * @param DMSDocument $filename The original filename
      *
+     * @param integer $versionCounter
      * @return string The new filename
      */
     protected function generateVersionedFilename(DMSDocument $doc, $versionCounter)
@@ -242,7 +242,7 @@ 
     /**
      * Return the size of the file associated with the document.
      *
-     * @return string
+     * @return integer
      */
     public function getAbsoluteSize()
     {

code/tools/ShortCodeRelationFinder.php

Doc Comments +4 added lines

@@ -32,6 +32,9 @@ 
         return $found;
     }
 
+    /**
+     * @param integer $number
+     */
     public function findPageCount($number)
     {
         $list = $this->getList($number);
@@ -63,6 +66,7 @@ 
      * Returns a filtered list of fields which could contain shortcodes.
      *
      * @param String
+     * @param string $class
      * @return Array Map of class names to an array of field names on these classes.
      */
     public function getShortcodeFields($class)

tests/DMSEmbargoTest.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
         self::$is_running_test = $this->originalIsRunningTest;
     }
 
+    /**
+     * @param integer $id
+     */
     public function createFakeHTTPRequest($id)
     {
         $r = new SS_HTTPRequest('GET', 'index/'.$id);

code/cms/DMSDocumentAddExistingField.php

Doc Comments +4 added lines

@@ -4,6 +4,10 @@
 {
     public $useFieldContext = true;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null)
     {
         $this->name = $name;

code/cms/DMSUploadField.php

Doc Comments +6 added lines, -1 removed lines

@@ -20,6 +20,10 @@ 
 
     protected $folderName = 'DMSTemporaryUploads';
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, SS_List $items = null)
     {
         parent::__construct($name, $title, $items);
@@ -33,6 +37,7 @@ 
      * Override the default behaviour of the UploadField and take the uploaded file (uploaded to assets) and
      * add it into the DMS storage, deleting the old/uploaded file.
      * @param File
+     * @param File $file
      */
     protected function attachFile($file)
     {
@@ -76,7 +81,7 @@ 
      * Action to handle upload of a single file
      *
      * @param SS_HTTPRequest $request
-     * @return string json
+     * @return SS_HTTPResponse json
      */
     public function upload(SS_HTTPRequest $request)
     {

code/interface/DMSDocumentInterface.php

Doc Comments +6 added lines, -5 removed lines

@@ -40,7 +40,7 @@ 
      * not exist.
      * @abstract
      * @param $pageObject Page object to remove the association to
-     * @return mixed
+     * @return DMSDocument
      */
     public function removePage($pageObject);
 
@@ -69,7 +69,7 @@ 
      * same category can occur multiple times)
      * @abstract
      * @param $category String of a metadata category to add (required)
-     * @param $value String of a metadata value to add (required)
+     * @param string $value String of a metadata value to add (required)
      * @param bool $multiValue Boolean that determines if the category is multi-value or single-value (optional)
      * @return null
      */
@@ -80,7 +80,7 @@ 
      * tries to fetch that specific tag.
      * @abstract
      * @param $category String of the metadata category to get
-     * @param null $value String of the value of the tag to get
+     * @param string|null $value String of the value of the tag to get
      * @return array of Strings of all the tags or null if there is no match found
      */
     public function getTagsList($category, $value = null);
@@ -91,7 +91,7 @@ 
      * Nothing happens if the category or the value do not exist.
      * @abstract
      * @param $category Category to remove (required)
-     * @param null $value Value to remove (optional)
+     * @param string|null $value Value to remove (optional)
      * @return null
      */
     public function removeTag($category, $value = null);
@@ -112,6 +112,7 @@ 
 
     /**
      * Return the extension of the file associated with the document
+     * @return string
      */
     public function getExtension();
 
@@ -134,7 +135,7 @@ 
      * Takes a File object or a String (path to a file) and copies it into the DMS, replacing the original document file
      * but keeping the rest of the document unchanged.
      * @param $file File object, or String that is path to a file to store
-     * @return DMSDocumentInstance Document object that we replaced the file in
+     * @return DMSDocument Document object that we replaced the file in
      */
     public function replaceDocument($file);
 

code/model/DMSDocument.php

Doc Comments +4 added lines, -3 removed lines

@@ -837,7 +837,7 @@ 
      * DMS, replacing the original document file but keeping the rest of the
      * document unchanged.
      *
-     * @param File|string $file path to a file to store
+     * @param File $file path to a file to store
      *
      * @return DMSDocument object that we replaced the file in
      */
@@ -1198,7 +1198,7 @@ 
     /**
      * Return the size of the file associated with the document.
      *
-     * @return string
+     * @return integer|null
      */
     public function getAbsoluteSize()
     {
@@ -1217,7 +1217,8 @@ 
 
 
     /**
-     * @return FieldList
+     * @param integer $relationListCount
+     * @return FieldGroup
      */
     protected function getFieldsForFile($relationListCount)
     {