Completed
Push — master ( 02d548...e42a4c )
by Damian
02:25
created
code/model/Comment.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	/**
317 317
 	 * Checks if the comment can be edited.
318 318
 	 *
319
-	 * @param null|int|Member $member
319
+	 * @param DataObject|null $member
320 320
 	 *
321 321
 	 * @return Boolean
322 322
 	 */
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 	/**
347 347
 	 * Checks if the comment can be deleted.
348 348
 	 *
349
-	 * @param null|int|Member $member
349
+	 * @param Member|null $member
350 350
 	 *
351 351
 	 * @return Boolean
352 352
 	 */
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 	 * Resolves Member object.
370 370
 	 *
371 371
 	 * @param Member|int|null $member
372
-	 * @return Member|null
372
+	 * @return DataObject|null
373 373
 	 */
374 374
 	protected function getMember($member = null) {
375 375
 		if(!$member) {
Please login to merge, or discard this patch.
code/controllers/CommentingController.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	 * Get the commenting option for the current state
121 121
 	 *
122 122
 	 * @param string $key
123
-	 * @return mixed Result if the setting is available, or null otherwise
123
+	 * @return integer Result if the setting is available, or null otherwise
124 124
 	 */
125 125
 	public function getOption($key) {
126 126
 		// If possible use the current record
@@ -280,6 +280,7 @@  discard block
 block discarded – undo
280 280
      * Redirect back to referer if available, ensuring that only site URLs
281 281
      * are allowed to avoid phishing.  If it's an AJAX request render the
282 282
      * comment in it's new state
283
+     * @param DataObject $comment
283 284
      */
284 285
     private function renderChangedCommentState($comment) {
285 286
         $referer = $this->request->getHeader('Referer');
Please login to merge, or discard this patch.
code/Commenting.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,6 +23,7 @@  discard block
 block discarded – undo
23 23
 	 * @param string classname to add commenting to
24 24
 	 * @param array $settings Settings. See {@link self::$default_config} for
25 25
 	 *			available settings
26
+	 * @param string $class
26 27
 	 * 
27 28
 	 * @throws InvalidArgumentException
28 29
 	 */
@@ -72,7 +73,7 @@  discard block
 block discarded – undo
72 73
 	 * @param string $class Class to set the value on. Passing 'all' will set it to all 
73 74
 	 *			active mappings
74 75
 	 * @param string $key setting to change
75
-	 * @param mixed $value value of the setting
76
+	 * @param string $value value of the setting
76 77
 	 */
77 78
 	public static function set_config_value($class, $key, $value = false) {
78 79
 		Deprecation::notice('2.0', 'Commenting::set_config_value is deprecated. Use the config api instead');
@@ -116,7 +117,7 @@  discard block
 block discarded – undo
116 117
 	 * @param string $class
117 118
 	 * @param string $key
118 119
 	 * @param string $value Expected value
119
-	 * @return boolean
120
+	 * @return boolean|null
120 121
 	 */
121 122
 	public static function config_value_equals($class, $key, $value) {
122 123
 		$check = self::get_config_value($class, $key);
Please login to merge, or discard this patch.
tests/CommentAdminTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -43,6 +43,9 @@
 block discarded – undo
43 43
         $form = $commentAdmin->getEditForm();
44 44
 	}
45 45
 
46
+    /**
47
+     * @param Form $form
48
+     */
46 49
     private function getFormFieldNames($form) {
47 50
         $result = array();
48 51
         $fields = $form->Fields();
Please login to merge, or discard this patch.
tests/CommentsTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1196,6 +1196,9 @@
 block discarded – undo
1196 1196
     }
1197 1197
 
1198 1198
 
1199
+    /**
1200
+     * @param string $name
1201
+     */
1199 1202
     protected static function getMethod($name) {
1200 1203
         $class = new ReflectionClass('Comment');
1201 1204
         $method = $class->getMethod($name);
Please login to merge, or discard this patch.