silverstripe / silverstripe-comments

code/admin/CommentsGridFieldBulkAction.php

<?php

/**
 * @package comments
 */
class CommentsGridFieldBulkAction extends GridFieldBulkActionHandler {

}

/**
 * A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
 *
 * @package comments
 */
class CommentsGridFieldBulkAction_Handlers extends CommentsGridFieldBulkAction {

	private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

		'spam',
		'approve',
	);

	private static $url_handlers = array(

Consider using a different property name as you override a private property of the parent class.

		'spam' => 'spam',
		'approve' => 'approve',
	);


	public function spam(SS_HTTPRequest $request) {

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

		$ids = array();

		foreach($this->getRecords() as $record) {
			array_push($ids, $record->ID);
			$record->markSpam();
		}

		$response = new SS_HTTPResponse(Convert::raw2json(array(
			'done' => true,
			'records' => $ids
		)));

		$response->addHeader('Content-Type', 'text/json');

		return $response;
	}


	public function approve(SS_HTTPRequest $request) {

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

		$ids = array();

		foreach($this->getRecords() as $record) {
			array_push($ids, $record->ID);
			$record->markApproved();
		}

		$response = new SS_HTTPResponse(Convert::raw2json(array(
			'done' => true,
			'records' => $ids
		)));

		$response->addHeader('Content-Type', 'text/json');

		return $response;
	}
}