CommentsGridFieldBulkAction_Handlers::approve() - Code Metrics - Inspection of "Merge pull request #167 from gordonbanderson/issue..." - silverstripe/silverstripe-comments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b1bf62...c2fee6 )

by Damian

created 2016-02-15 20:43 UTC

CommentsGridFieldBulkAction_Handlers::approve() A

↳ Parent: CommentsGridFieldBulkAction_Handlers

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	17
Ratio	100 %

Metric	Value
dl	17
loc	17
rs	9.4285
cc	2
eloc	10
nc	2
nop	1

<?php

/**
 * @package comments
 */
class CommentsGridFieldBulkAction extends GridFieldBulkActionHandler {

}

/**
 * A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
 *
 * @package comments
 */
class CommentsGridFieldBulkAction_Handlers extends CommentsGridFieldBulkAction {

	private static $allowed_actions = array(

		'spam',
		'approve',
	);

	private static $url_handlers = array(

		'spam' => 'spam',
		'approve' => 'approve',
	);


	public function spam(SS_HTTPRequest $request) {

		$ids = array();

		foreach($this->getRecords() as $record) {
			array_push($ids, $record->ID);
			$record->markSpam();
		}

		$response = new SS_HTTPResponse(Convert::raw2json(array(
			'done' => true,
			'records' => $ids
		)));

		$response->addHeader('Content-Type', 'text/json');

		return $response;
	}


	public function approve(SS_HTTPRequest $request) {

		$ids = array();

		foreach($this->getRecords() as $record) {
			array_push($ids, $record->ID);
			$record->markApproved();
		}

		$response = new SS_HTTPResponse(Convert::raw2json(array(
			'done' => true,
			'records' => $ids
		)));

		$response->addHeader('Content-Type', 'text/json');

		return $response;
	}
}

1		<?php
2
3		/**
4		* @package comments
5		*/
6		class CommentsGridFieldBulkAction extends GridFieldBulkActionHandler {
7
8		}
9
10		/**
11		* A {@link GridFieldBulkActionHandler} for bulk marking comments as spam
12		*
13		* @package comments
14		*/
15		class CommentsGridFieldBulkAction_Handlers extends CommentsGridFieldBulkAction {
16
17		private static $allowed_actions = array(
		0 ignored issues – show Comprehensibility introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
18		'spam',
19		'approve',
20		);
21
22		private static $url_handlers = array(
		0 ignored issues – show Comprehensibility introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
23		'spam' => 'spam',
24		'approve' => 'approve',
25		);
26
27
28	View Code Duplication	public function spam(SS_HTTPRequest $request) {
		0 ignored issues – show Unused Code introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$ids = array();
30
31		foreach($this->getRecords() as $record) {
32		array_push($ids, $record->ID);
33		$record->markSpam();
34		}
35
36		$response = new SS_HTTPResponse(Convert::raw2json(array(
37		'done' => true,
38		'records' => $ids
39		)));
40
41		$response->addHeader('Content-Type', 'text/json');
42
43		return $response;
44		}
45
46
47	View Code Duplication	public function approve(SS_HTTPRequest $request) {
		0 ignored issues – show Unused Code introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2015-11-20 23:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		$ids = array();
49
50		foreach($this->getRecords() as $record) {
51		array_push($ids, $record->ID);
52		$record->markApproved();
53		}
54
55		$response = new SS_HTTPResponse(Convert::raw2json(array(
56		'done' => true,
57		'records' => $ids
58		)));
59
60		$response->addHeader('Content-Type', 'text/json');
61
62		return $response;
63		}
64		}

silverstripe / silverstripe-comments

Push — master ( b1bf62...c2fee6 )

CommentsGridFieldBulkAction_Handlers::approve() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like