Completed
Pull Request — master (#1488)
by Hamish
02:41
created
code/controllers/AssetAdmin.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -538,6 +538,10 @@
 block discarded – undo
538 538
 		return new Folder();
539 539
 	}
540 540
 
541
+	/**
542
+	 * @param string $childrenMethod
543
+	 * @param string $numChildrenMethod
544
+	 */
541 545
 	public function getSiteTreeFor($className, $rootID = null, $childrenMethod = null, $numChildrenMethod = null, $filterFunction = null, $minNodeCount = 30) {
542 546
 		if (!$childrenMethod) $childrenMethod = 'ChildFolders';
543 547
 		if (!$numChildrenMethod) $numChildrenMethod = 'numChildFolders';
Please login to merge, or discard this patch.
code/forms/SiteTreeURLSegmentField.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,6 +89,7 @@  discard block
 block discarded – undo
89 89
 	
90 90
 	/**
91 91
 	 * @param the url that prefixes the page url segment field
92
+	 * @param string $url
92 93
 	 */
93 94
 	public function setURLPrefix($url){
94 95
 		$this->urlPrefix = $url;
@@ -96,7 +97,7 @@  discard block
 block discarded – undo
96 97
 	}
97 98
 	
98 99
 	/**
99
-	 * @return the url prefixes the page url segment field to show in template
100
+	 * @return string url prefixes the page url segment field to show in template
100 101
 	 */
101 102
 	public function getURLPrefix(){
102 103
 		return $this->urlPrefix;
@@ -107,7 +108,7 @@  discard block
 block discarded – undo
107 108
 	}
108 109
 
109 110
 	/**
110
-	 * @return Indicator for UI to respond to changes accurately,
111
+	 * @return string for UI to respond to changes accurately,
111 112
 	 * and auto-update the field value if changes to the default occur.
112 113
 	 * Does not set the field default value.
113 114
 	 */
@@ -115,6 +116,9 @@  discard block
 block discarded – undo
115 116
 		return $this->defaultUrl;
116 117
 	}
117 118
 	
119
+	/**
120
+	 * @param string $url
121
+	 */
118 122
 	public function setDefaultURL($url) {
119 123
 		$this->defaultUrl = $url;
120 124
 		return $this;
Please login to merge, or discard this patch.
tasks/UpgradeSiteTreePermissionSchemaTask.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@
 block discarded – undo
19 19
 		See http://open.silverstripe.com/ticket/2847
20 20
 	";
21 21
 	
22
+	/**
23
+	 * @param SS_HTTPRequest $request
24
+	 */
22 25
 	public function run($request) {
23 26
 		// transfer values for changed column name
24 27
 		foreach(array('SiteTree','SiteTree_Live','SiteTree_versions') as $table) {
Please login to merge, or discard this patch.
code/model/ErrorPage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 	/**
253 253
 	 * Write out the published version of the page to the filesystem
254 254
 	 *
255
-	 * @return true if the page write was successful
255
+	 * @return boolean if the page write was successful
256 256
 	 */
257 257
 	public function writeStaticPage() {
258 258
 		if(!self::config()->enable_static_file) {
Please login to merge, or discard this patch.
code/controllers/ContentController.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -222,6 +222,7 @@
 block discarded – undo
222 222
 
223 223
 	/**
224 224
 	 * Returns the associated database record
225
+	 * @return SiteTree
225 226
 	 */
226 227
 	public function data() {
227 228
 		return $this->dataRecord;
Please login to merge, or discard this patch.
code/model/VirtualPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -341,6 +341,9 @@
 block discarded – undo
341 341
 		}
342 342
 	}
343 343
 
344
+	/**
345
+	 * @param string $field
346
+	 */
344 347
 	public function getField($field) {
345 348
 		if($this->isFieldVirtualised($field)) {
346 349
 			return $this->CopyContentFrom()->getField($field);
Please login to merge, or discard this patch.
code/controllers/CMSMain.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -661,7 +661,7 @@  discard block
 block discarded – undo
661 661
 
662 662
 	/**
663 663
 	 * @param SS_HTTPRequest $request
664
-	 * @return string HTML
664
+	 * @return SilverStripe\Model\FieldType\DBField HTML
665 665
 	 */
666 666
 	public function treeview($request) {
667 667
 		return $this->renderWith($this->getTemplatesWithSuffix('_TreeView'));
@@ -669,7 +669,7 @@  discard block
 block discarded – undo
669 669
 
670 670
 	/**
671 671
 	 * @param SS_HTTPRequest $request
672
-	 * @return string HTML
672
+	 * @return SilverStripe\Model\FieldType\DBField HTML
673 673
 	 */
674 674
 	public function listview($request) {
675 675
 		return $this->renderWith($this->getTemplatesWithSuffix('_ListView'));
@@ -982,7 +982,7 @@  discard block
 block discarded – undo
982 982
 	 * Actually perform the publication step
983 983
 	 *
984 984
 	 * @param Versioned|DataObject $record
985
-	 * @return mixed
985
+	 * @return SS_HTTPResponse|null
986 986
 	 */
987 987
 	public function performPublish($record) {
988 988
 		if($record && !$record->canPublish()) {
@@ -1136,7 +1136,7 @@  discard block
 block discarded – undo
1136 1136
 	}
1137 1137
 
1138 1138
 	/**
1139
-	 * @return array
1139
+	 * @return SS_HTTPResponse|null
1140 1140
 	 */
1141 1141
 	public function rollback() {
1142 1142
 		return $this->doRollback(array(
Please login to merge, or discard this patch.
code/controllers/CMSPageHistoryController.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
 	/**
42 42
 	 * @param SS_HTTPRequest $request
43
-	 * @return array
43
+	 * @return SS_HTTPResponse
44 44
 	 */
45 45
 	public function show($request) {
46 46
 		$form = $this->ShowVersionForm($request->param('VersionID'));
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
 	/**
61 61
 	 * @param SS_HTTPRequest $request
62
-	 * @return array
62
+	 * @return SS_HTTPResponse
63 63
 	 */
64 64
 	public function compare($request) {
65 65
 		$form = $this->CompareVersionsForm(
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
 	 * @param array
279 279
 	 * @param Form
280 280
 	 *
281
-	 * @return html
281
+	 * @return null|SilverStripe\Model\FieldType\DBField
282 282
 	 */
283 283
 	public function doCompare($data, $form) {
284 284
 		$versions = $data['Versions'];
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 	 * @param array
316 316
 	 * @param Form
317 317
 	 *
318
-	 * @return html
318
+	 * @return null|SilverStripe\Model\FieldType\DBField
319 319
 	 */
320 320
 	public function doShowVersion($data, $form) {
321 321
 		$versionID = null;
Please login to merge, or discard this patch.
code/model/SiteTree.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -661,7 +661,7 @@  discard block
 block discarded – undo
661 661
 	 * @param boolean $unlinked Whether to link page titles.
662 662
 	 * @param boolean|string $stopAtPageType ClassName of a page to stop the upwards traversal.
663 663
 	 * @param boolean $showHidden Include pages marked with the attribute ShowInMenus = 0
664
-	 * @return HTMLText The breadcrumb trail.
664
+	 * @return SilverStripe\Model\FieldType\DBField The breadcrumb trail.
665 665
 	 */
666 666
 	public function Breadcrumbs($maxDepth = 20, $unlinked = false, $stopAtPageType = false, $showHidden = false) {
667 667
 		$pages = $this->getBreadcrumbItems($maxDepth, $stopAtPageType, $showHidden);
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
 	/**
1199 1199
 	 * Get the 'can edit' information for a number of SiteTree pages.
1200 1200
 	 *
1201
-	 * @param array $ids       An array of IDs of the SiteTree pages to look up
1201
+	 * @param integer[] $ids       An array of IDs of the SiteTree pages to look up
1202 1202
 	 * @param int   $memberID  ID of member
1203 1203
 	 * @param bool  $useCached Return values from the permission cache if they exist
1204 1204
 	 * @return array
@@ -1271,7 +1271,7 @@  discard block
 block discarded – undo
1271 1271
 	 *
1272 1272
 	 * @param string $condition The PHP condition to be evaluated. The page will be called $item
1273 1273
 	 * @param array  $collator  An array, passed by reference, to collect all of the matching descendants.
1274
-	 * @return bool
1274
+	 * @return boolean|null
1275 1275
 	 */
1276 1276
 	public function collateDescendants($condition, &$collator) {
1277 1277
 		if($children = $this->Children()) {
Please login to merge, or discard this patch.