Completed
Pull Request — master (#1393)
by Scott
02:22
created
code/controllers/AssetAdmin.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -538,6 +538,10 @@
 block discarded – undo
538 538
 		return new Folder();
539 539
 	}
540 540
 
541
+	/**
542
+	 * @param string $childrenMethod
543
+	 * @param string $numChildrenMethod
544
+	 */
541 545
 	public function getSiteTreeFor($className, $rootID = null, $childrenMethod = null, $numChildrenMethod = null, $filterFunction = null, $minNodeCount = 30) {
542 546
 		if (!$childrenMethod) $childrenMethod = 'ChildFolders';
543 547
 		if (!$numChildrenMethod) $numChildrenMethod = 'numChildFolders';
Please login to merge, or discard this patch.
code/controllers/CMSPageHistoryController.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
 	/**
42 42
 	 * @param SS_HTTPRequest $request
43
-	 * @return array
43
+	 * @return SS_HTTPResponse
44 44
 	 */
45 45
 	public function show($request) {
46 46
 		$form = $this->ShowVersionForm($request->param('VersionID'));
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
 	/**
61 61
 	 * @param SS_HTTPRequest $request
62
-	 * @return array
62
+	 * @return SS_HTTPResponse
63 63
 	 */
64 64
 	public function compare($request) {
65 65
 		$form = $this->CompareVersionsForm(
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
 	 * @param array
279 279
 	 * @param Form
280 280
 	 *
281
-	 * @return html
281
+	 * @return null|HTMLText
282 282
 	 */
283 283
 	public function doCompare($data, $form) {
284 284
 		$versions = $data['Versions'];
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 	 * @param array
316 316
 	 * @param Form
317 317
 	 *
318
-	 * @return html
318
+	 * @return null|HTMLText
319 319
 	 */
320 320
 	public function doShowVersion($data, $form) {
321 321
 		$versionID = null;
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
 
345 345
 	/**
346 346
 	 * @param int|null $versionID
347
-	 * @return Form
347
+	 * @return null|CMSForm
348 348
 	 */
349 349
 	public function ShowVersionForm($versionID = null) {
350 350
 		if(!$versionID) return null;
Please login to merge, or discard this patch.
code/forms/SiteTreeURLSegmentField.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,6 +89,7 @@  discard block
 block discarded – undo
89 89
 	
90 90
 	/**
91 91
 	 * @param the url that prefixes the page url segment field
92
+	 * @param string $url
92 93
 	 */
93 94
 	public function setURLPrefix($url){
94 95
 		$this->urlPrefix = $url;
@@ -96,7 +97,7 @@  discard block
 block discarded – undo
96 97
 	}
97 98
 	
98 99
 	/**
99
-	 * @return the url prefixes the page url segment field to show in template
100
+	 * @return string url prefixes the page url segment field to show in template
100 101
 	 */
101 102
 	public function getURLPrefix(){
102 103
 		return $this->urlPrefix;
@@ -107,7 +108,7 @@  discard block
 block discarded – undo
107 108
 	}
108 109
 
109 110
 	/**
110
-	 * @return Indicator for UI to respond to changes accurately,
111
+	 * @return string for UI to respond to changes accurately,
111 112
 	 * and auto-update the field value if changes to the default occur.
112 113
 	 * Does not set the field default value.
113 114
 	 */
@@ -115,6 +116,9 @@  discard block
 block discarded – undo
115 116
 		return $this->defaultUrl;
116 117
 	}
117 118
 	
119
+	/**
120
+	 * @param string $url
121
+	 */
118 122
 	public function setDefaultURL($url) {
119 123
 		$this->defaultUrl = $url;
120 124
 		return $this;
Please login to merge, or discard this patch.
code/model/SiteTreeFileExtension.php 1 patch
Doc Comments   -4 removed lines patch added patch discarded remove patch
@@ -51,10 +51,6 @@
 block discarded – undo
51 51
 	/**
52 52
 	 * Extend through {@link updateBackLinkTracking()} in your own {@link Extension}.
53 53
 	 *
54
-	 * @param string|array $filter
55
-	 * @param string $sort
56
-	 * @param string $join
57
-	 * @param string $limit
58 54
 	 * @return ManyManyList
59 55
 	 */
60 56
 	public function BackLinkTracking() {
Please login to merge, or discard this patch.
code/model/VirtualPage.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -374,6 +374,7 @@
 block discarded – undo
374 374
 	
375 375
 	/**
376 376
 	 * Ensure we have an up-to-date version of everything.
377
+	 * @param DataObject $source
377 378
 	 */
378 379
 	public function copyFrom($source, $updateImageTracking = true) {
379 380
 		if($source) {
Please login to merge, or discard this patch.
tasks/UpgradeSiteTreePermissionSchemaTask.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@
 block discarded – undo
19 19
 		See http://open.silverstripe.com/ticket/2847
20 20
 	";
21 21
 	
22
+	/**
23
+	 * @param SS_HTTPRequest $request
24
+	 */
22 25
 	public function run($request) {
23 26
 		// transfer values for changed column name
24 27
 		foreach(array('SiteTree','SiteTree_Live','SiteTree_versions') as $table) {
Please login to merge, or discard this patch.
code/model/ErrorPage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 	/**
253 253
 	 * Write out the published version of the page to the filesystem
254 254
 	 *
255
-	 * @return true if the page write was successful
255
+	 * @return boolean if the page write was successful
256 256
 	 */
257 257
 	public function writeStaticPage() {
258 258
 		if(!self::config()->enable_static_file) {
Please login to merge, or discard this patch.
code/controllers/CMSMain.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -701,7 +701,7 @@  discard block
 block discarded – undo
701 701
 
702 702
 	/**
703 703
 	 * @param SS_HTTPRequest $request
704
-	 * @return string HTML
704
+	 * @return HTMLText HTML
705 705
 	 */
706 706
 	public function treeview($request) {
707 707
 		return $this->renderWith($this->getTemplatesWithSuffix('_TreeView'));
@@ -709,7 +709,7 @@  discard block
 block discarded – undo
709 709
 
710 710
 	/**
711 711
 	 * @param SS_HTTPRequest $request
712
-	 * @return string HTML
712
+	 * @return HTMLText HTML
713 713
 	 */
714 714
 	public function listview($request) {
715 715
 		return $this->renderWith($this->getTemplatesWithSuffix('_ListView'));
@@ -1161,7 +1161,7 @@  discard block
 block discarded – undo
1161 1161
 	}
1162 1162
 
1163 1163
 	/**
1164
-	 * @return array
1164
+	 * @return SS_HTTPResponse|null
1165 1165
 	 */
1166 1166
 	public function rollback() {
1167 1167
 		return $this->doRollback(array(
@@ -1176,7 +1176,7 @@  discard block
 block discarded – undo
1176 1176
 	 * @param array
1177 1177
 	 * @param Form
1178 1178
 	 *
1179
-	 * @return html
1179
+	 * @return SS_HTTPResponse|null
1180 1180
 	 */
1181 1181
 	public function doRollback($data, $form) {
1182 1182
 		$this->extend('onBeforeRollback', $data['ID']);
Please login to merge, or discard this patch.
code/controllers/ContentController.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -222,6 +222,7 @@
 block discarded – undo
222 222
 
223 223
 	/**
224 224
 	 * Returns the associated database record
225
+	 * @return SiteTree
225 226
 	 */
226 227
 	public function data() {
227 228
 		return $this->dataRecord;
Please login to merge, or discard this patch.