Completed
Pull Request — master (#1458)
by Sam
04:45 queued 02:13
created
code/model/ErrorPage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 	/**
253 253
 	 * Write out the published version of the page to the filesystem
254 254
 	 *
255
-	 * @return true if the page write was successful
255
+	 * @return boolean if the page write was successful
256 256
 	 */
257 257
 	public function writeStaticPage() {
258 258
 		if(!self::config()->enable_static_file) {
Please login to merge, or discard this patch.
code/model/VirtualPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -341,6 +341,9 @@
 block discarded – undo
341 341
 		}
342 342
 	}
343 343
 
344
+	/**
345
+	 * @param string $field
346
+	 */
344 347
 	public function getField($field) {
345 348
 		if($this->isFieldVirtualised($field)) {
346 349
 			return $this->CopyContentFrom()->getField($field);
Please login to merge, or discard this patch.
code/controllers/ModelAsController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	/**
44 44
 	 * @uses ModelAsController::getNestedController()
45 45
 	 * @param SS_HTTPRequest $request
46
-	 * @param DataModel $model
46
+	 * @param null|DataModel $model
47 47
 	 * @return SS_HTTPResponse
48 48
 	 */
49 49
 	public function handleRequest(SS_HTTPRequest $request, DataModel $model) {
Please login to merge, or discard this patch.
code/model/SiteTree.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1271,7 +1271,7 @@
 block discarded – undo
1271 1271
 	 *
1272 1272
 	 * @param string $condition The PHP condition to be evaluated. The page will be called $item
1273 1273
 	 * @param array  $collator  An array, passed by reference, to collect all of the matching descendants.
1274
-	 * @return bool
1274
+	 * @return boolean|null
1275 1275
 	 */
1276 1276
 	public function collateDescendants($condition, &$collator) {
1277 1277
 		if($children = $this->Children()) {
Please login to merge, or discard this patch.