Completed
Pull Request — master (#1677)
by Ed
04:32
created
code/Forms/SiteTreeURLSegmentField.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -118,6 +118,9 @@
 block discarded – undo
118 118
 		return $this->defaultUrl;
119 119
 	}
120 120
 
121
+	/**
122
+	 * @param string $url
123
+	 */
121 124
 	public function setDefaultURL($url) {
122 125
 		$this->defaultUrl = $url;
123 126
 		return $this;
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use SilverStripe\Control\HTTPRequest;
8 8
 use SilverStripe\Core\Convert;
9 9
 use SilverStripe\Forms\TextField;
10
-use SilverStripe\View\Requirements;
11 10
 
12 11
 /**
13 12
  * Used to edit the SiteTree->URLSegment property, and suggest input based on the serverside rules
Please login to merge, or discard this patch.
code/Model/ErrorPage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 	/**
253 253
 	 * Write out the published version of the page to the filesystem
254 254
 	 *
255
-	 * @return true if the page write was successful
255
+	 * @return boolean if the page write was successful
256 256
 	 */
257 257
 	public function writeStaticPage() {
258 258
 		if(!self::config()->enable_static_file) {
Please login to merge, or discard this patch.
code/Model/VirtualPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -341,6 +341,9 @@
 block discarded – undo
341 341
 		}
342 342
 	}
343 343
 
344
+	/**
345
+	 * @param string $field
346
+	 */
344 347
 	public function getField($field) {
345 348
 		if($this->isFieldVirtualised($field)) {
346 349
 			return $this->CopyContentFrom()->getField($field);
Please login to merge, or discard this patch.
code/Model/SiteTree.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -753,7 +753,7 @@
 block discarded – undo
753 753
 	 * @param boolean $unlinked Whether to link page titles.
754 754
 	 * @param boolean|string $stopAtPageType ClassName of a page to stop the upwards traversal.
755 755
 	 * @param boolean $showHidden Include pages marked with the attribute ShowInMenus = 0
756
-	 * @return string The breadcrumb trail.
756
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText The breadcrumb trail.
757 757
 	 */
758 758
 	public function Breadcrumbs($maxDepth = 20, $unlinked = false, $stopAtPageType = false, $showHidden = false) {
759 759
 		$pages = $this->getBreadcrumbItems($maxDepth, $stopAtPageType, $showHidden);
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	protected $record;
33 33
 
34 34
 	/**
35
-	 * @param DataObject|CMSPreviewable $record
35
+	 * @param CMSPreviewable $record
36 36
 	 */
37 37
 	public function __construct(CMSPreviewable $record) {
38 38
 		parent::__construct();
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigatorItem.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	protected $recordLink;
28 28
 
29 29
 	/**
30
-	 * @param DataObject|CMSPreviewable $record
30
+	 * @param CMSPreviewable $record
31 31
 	 */
32 32
 	public function __construct(CMSPreviewable $record)
33 33
 	{
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/**
79
-	 * @return DataObject
79
+	 * @return CMSPreviewable
80 80
 	 */
81 81
 	public function getRecord()
82 82
 	{
Please login to merge, or discard this patch.
code/Model/SiteTreeFileExtension.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SilverStripe\CMS\Model;
4 4
 
5 5
 use SilverStripe\Assets\File;
6
-use SilverStripe\Core\Convert;
7 6
 use SilverStripe\Forms\FieldList;
8 7
 use SilverStripe\Forms\ReadonlyField;
9 8
 use SilverStripe\ORM\DataExtension;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 	/**
60 60
 	 * Generate an HTML list which provides links to where a file is used.
61 61
 	 *
62
-	 * @return string
62
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText
63 63
 	 */
64 64
 	public function BackLinkHTMLList() {
65 65
 		$viewer = new SSViewer(["type" => "Includes", self::class . "_description"]);
Please login to merge, or discard this patch.
code/Controllers/CMSPageEditController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 	 *
43 43
 	 * @param array $data
44 44
 	 * @param Form $form
45
-	 * @return DBHTMLText|HTTPResponse
45
+	 * @return null|HTTPResponse
46 46
 	 */
47 47
 	public function addtocampaign($data, $form)
48 48
 	{
Please login to merge, or discard this patch.
code/Controllers/CMSPageHistoryController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
 	/**
59 59
 	 * @param HTTPRequest $request
60
-	 * @return array
60
+	 * @return HTTPResponse
61 61
 	 */
62 62
 	public function show($request) {
63 63
 		$form = $this->ShowVersionForm($request->param('VersionID'));
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
 	/**
78 78
 	 * @param HTTPRequest $request
79
-	 * @return array
79
+	 * @return HTTPResponse
80 80
 	 */
81 81
 	public function compare($request) {
82 82
 		$form = $this->CompareVersionsForm(
Please login to merge, or discard this patch.