Completed
Push — master ( cab21e...ed90cc )
by Daniel
02:43
created
code/Model/SiteTreeFileExtension.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SilverStripe\CMS\Model;
4 4
 
5 5
 use SilverStripe\Assets\File;
6
-use SilverStripe\Core\Convert;
7 6
 use SilverStripe\Forms\FieldList;
8 7
 use SilverStripe\Forms\ReadonlyField;
9 8
 use SilverStripe\ORM\DataExtension;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     /**
62 62
      * Generate an HTML list which provides links to where a file is used.
63 63
      *
64
-     * @return string
64
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
65 65
      */
66 66
     public function BackLinkHTMLList()
67 67
     {
Please login to merge, or discard this patch.
code/Forms/SiteTreeURLSegmentField.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use SilverStripe\Control\HTTPRequest;
8 8
 use SilverStripe\Core\Convert;
9 9
 use SilverStripe\Forms\TextField;
10
-use SilverStripe\View\Requirements;
11 10
 
12 11
 /**
13 12
  * Used to edit the SiteTree->URLSegment property, and suggest input based on the serverside rules
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -137,6 +137,9 @@
 block discarded – undo
137 137
         return $this->defaultUrl;
138 138
     }
139 139
 
140
+    /**
141
+     * @param string $url
142
+     */
140 143
     public function setDefaultURL($url)
141 144
     {
142 145
         $this->defaultUrl = $url;
Please login to merge, or discard this patch.
code/Controllers/CMSPageEditController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      *
44 44
      * @param array $data
45 45
      * @param Form $form
46
-     * @return DBHTMLText|HTTPResponse
46
+     * @return null|HTTPResponse
47 47
      */
48 48
     public function addtocampaign($data, $form)
49 49
     {
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigatorItem.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
     protected $recordLink;
26 26
 
27 27
     /**
28
-     * @param DataObject|CMSPreviewable $record
28
+     * @param CMSPreviewable $record
29 29
      */
30 30
     public function __construct(CMSPreviewable $record)
31 31
     {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     }
77 77
 
78 78
     /**
79
-     * @return DataObject
79
+     * @return CMSPreviewable
80 80
      */
81 81
     public function getRecord()
82 82
     {
Please login to merge, or discard this patch.
code/Model/VirtualPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -379,6 +379,9 @@
 block discarded – undo
379 379
         return null;
380 380
     }
381 381
 
382
+    /**
383
+     * @param string $field
384
+     */
382 385
     public function getField($field)
383 386
     {
384 387
         if ($this->isFieldVirtualised($field)) {
Please login to merge, or discard this patch.
code/Reports/RecentlyEditedReport.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use SilverStripe\CMS\Model\SiteTree;
6 6
 use SilverStripe\ORM\FieldType\DBDatetime;
7
-use SilverStripe\ORM\DataObject;
8 7
 use SilverStripe\Reports\Report;
9 8
 
10 9
 class RecentlyEditedReport extends Report
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
     protected $record;
29 29
 
30 30
     /**
31
-     * @param DataObject|\SilverStripe\ORM\CMSPreviewable $record
31
+     * @param CMSPreviewable $record
32 32
      */
33 33
     public function __construct(CMSPreviewable $record)
34 34
     {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     }
80 80
 
81 81
     /**
82
-     * @param DataObject|CMSPreviewable $record
82
+     * @param DataObject $record
83 83
      * @return array template data
84 84
      */
85 85
     public static function get_for_record($record)
Please login to merge, or discard this patch.
code/Controllers/CMSPageAddController.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@  discard block
 block discarded – undo
4 4
 
5 5
 use SilverStripe\CMS\Model\SiteTree;
6 6
 use SilverStripe\Control\Controller;
7
-use SilverStripe\Control\Session;
8 7
 use SilverStripe\Control\HTTPResponse;
9 8
 use SilverStripe\Forms\FieldList;
10 9
 use SilverStripe\Forms\Form;
@@ -17,7 +16,6 @@  discard block
 block discarded – undo
17 16
 use SilverStripe\ORM\DataObject;
18 17
 use SilverStripe\ORM\FieldType\DBField;
19 18
 use SilverStripe\ORM\ValidationResult;
20
-use SilverStripe\Security\Member;
21 19
 use SilverStripe\Security\Security;
22 20
 
23 21
 class CMSPageAddController extends CMSPageEditController
Please login to merge, or discard this patch.
code/Controllers/CMSMain.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@  discard block
 block discarded – undo
4 4
 
5 5
 use SilverStripe\Admin\AdminRootController;
6 6
 use SilverStripe\Admin\CMSBatchActionHandler;
7
-use SilverStripe\Admin\LeftAndMain_SearchFilter;
8 7
 use SilverStripe\Admin\LeftAndMainFormRequestHandler;
9 8
 use SilverStripe\CMS\Model\VirtualPage;
10 9
 use SilverStripe\Core\Environment;
@@ -20,7 +19,6 @@  discard block
 block discarded – undo
20 19
 use SilverStripe\CMS\Model\SiteTree;
21 20
 use SilverStripe\Control\Controller;
22 21
 use SilverStripe\Control\Director;
23
-use SilverStripe\Control\Session;
24 22
 use SilverStripe\Control\HTTPRequest;
25 23
 use SilverStripe\Control\HTTPResponse;
26 24
 use SilverStripe\Control\HTTPResponse_Exception;
Please login to merge, or discard this patch.
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -361,6 +361,9 @@  discard block
 block discarded – undo
361 361
         return 'edit';
362 362
     }
363 363
 
364
+    /**
365
+     * @param string $link
366
+     */
364 367
     public function LinkWithSearch($link)
365 368
     {
366 369
         // Whitelist to avoid side effects
@@ -501,7 +504,7 @@  discard block
 block discarded – undo
501 504
     /**
502 505
      * Get callback to determine template customisations for nodes
503 506
      *
504
-     * @return callable
507
+     * @return \Closure
505 508
      */
506 509
     protected function getTreeNodeCustomisations()
507 510
     {
@@ -1290,7 +1293,7 @@  discard block
 block discarded – undo
1290 1293
 
1291 1294
     /**
1292 1295
      * @param HTTPRequest $request
1293
-     * @return string HTML
1296
+     * @return HTTPResponse HTML
1294 1297
      */
1295 1298
     public function treeview($request)
1296 1299
     {
@@ -1299,7 +1302,7 @@  discard block
 block discarded – undo
1299 1302
 
1300 1303
     /**
1301 1304
      * @param HTTPRequest $request
1302
-     * @return string HTML
1305
+     * @return HTTPResponse HTML
1303 1306
      */
1304 1307
     public function listview($request)
1305 1308
     {
@@ -1652,7 +1655,7 @@  discard block
 block discarded – undo
1652 1655
      * Actually perform the publication step
1653 1656
      *
1654 1657
      * @param Versioned|DataObject $record
1655
-     * @return mixed
1658
+     * @return HTTPResponse|null
1656 1659
      */
1657 1660
     public function performPublish($record)
1658 1661
     {
Please login to merge, or discard this patch.