Completed
Push — master ( 91444b...ac9540 )
by Ingo
03:27
created
code/Model/ErrorPage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
 	/**
253 253
 	 * Write out the published version of the page to the filesystem
254 254
 	 *
255
-	 * @return true if the page write was successful
255
+	 * @return boolean if the page write was successful
256 256
 	 */
257 257
 	public function writeStaticPage() {
258 258
 		if(!self::config()->enable_static_file) {
Please login to merge, or discard this patch.
code/Model/VirtualPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -341,6 +341,9 @@
 block discarded – undo
341 341
 		}
342 342
 	}
343 343
 
344
+	/**
345
+	 * @param string $field
346
+	 */
344 347
 	public function getField($field) {
345 348
 		if($this->isFieldVirtualised($field)) {
346 349
 			return $this->CopyContentFrom()->getField($field);
Please login to merge, or discard this patch.
code/Controllers/CMSMain.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use FormField;
6 6
 use Injector;
7 7
 use ResetFormAction;
8
-use SilverStripe\ORM\FieldType\DBHTMLText;
9 8
 use SilverStripe\ORM\SS_List;
10 9
 use SilverStripe\ORM\Versioning\Versioned;
11 10
 use SilverStripe\ORM\HiddenClass;
Please login to merge, or discard this patch.
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
 
763 763
 	/**
764 764
 	 * @param SS_HTTPRequest $request
765
-	 * @return string HTML
765
+	 * @return DBHTMLText HTML
766 766
 	 */
767 767
 	public function treeview($request) {
768 768
 		return $this->renderWith($this->getTemplatesWithSuffix('_TreeView'));
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
 
771 771
 	/**
772 772
 	 * @param SS_HTTPRequest $request
773
-	 * @return string HTML
773
+	 * @return DBHTMLText HTML
774 774
 	 */
775 775
 	public function listview($request) {
776 776
 		return $this->renderWith($this->getTemplatesWithSuffix('_ListView'));
@@ -781,7 +781,7 @@  discard block
 block discarded – undo
781 781
 	 * Provides a slower but more precise response over SiteTreeHints
782 782
 	 *
783 783
 	 * @param SS_HTTPRequest $request
784
-	 * @return SS_HTTPResponse
784
+	 * @return \SS_HTTPResponse
785 785
 	 */
786 786
 	public function childfilter($request) {
787 787
 		// Check valid parent specified
@@ -961,7 +961,7 @@  discard block
 block discarded – undo
961 961
 	 *
962 962
 	 * @param array $data
963 963
 	 * @param Form $form
964
-	 * @return SS_HTTPResponse
964
+	 * @return \SS_HTTPResponse|null
965 965
 	 * @throws SS_HTTPResponse_Exception
966 966
 	 */
967 967
 	public function save($data, $form) {
@@ -1091,7 +1091,7 @@  discard block
 block discarded – undo
1091 1091
 	 * Actually perform the publication step
1092 1092
 	 *
1093 1093
 	 * @param Versioned|DataObject $record
1094
-	 * @return mixed
1094
+	 * @return \SS_HTTPResponse|null
1095 1095
 	 */
1096 1096
 	public function performPublish($record) {
1097 1097
 		if($record && !$record->canPublish()) {
@@ -1110,7 +1110,7 @@  discard block
 block discarded – undo
1110 1110
 	 *
1111 1111
 	 * @param array $data
1112 1112
 	 * @param Form $form
1113
-	 * @return SS_HTTPResponse
1113
+	 * @return \SS_HTTPResponse|null
1114 1114
 	 * @throws SS_HTTPResponse_Exception
1115 1115
 	 */
1116 1116
 	public function revert($data, $form) {
@@ -1160,7 +1160,7 @@  discard block
 block discarded – undo
1160 1160
 	 *
1161 1161
 	 * @param array $data
1162 1162
 	 * @param Form $form
1163
-	 * @return SS_HTTPResponse
1163
+	 * @return \SS_HTTPResponse|null
1164 1164
 	 * @throws SS_HTTPResponse_Exception
1165 1165
 	 */
1166 1166
 	public function delete($data, $form) {
@@ -1190,7 +1190,7 @@  discard block
 block discarded – undo
1190 1190
 	 *
1191 1191
 	 * @param array $data
1192 1192
 	 * @param Form $form
1193
-	 * @return SS_HTTPResponse
1193
+	 * @return \SS_HTTPResponse|null
1194 1194
 	 * @throws SS_HTTPResponse_Exception
1195 1195
 	 */
1196 1196
 	public function archive($data, $form) {
@@ -1245,7 +1245,7 @@  discard block
 block discarded – undo
1245 1245
 	}
1246 1246
 
1247 1247
 	/**
1248
-	 * @return SS_HTTPResponse
1248
+	 * @return \SS_HTTPResponse|null
1249 1249
 	 */
1250 1250
 	public function rollback() {
1251 1251
 		return $this->doRollback(array(
@@ -1259,7 +1259,7 @@  discard block
 block discarded – undo
1259 1259
 	 *
1260 1260
 	 * @param array $data
1261 1261
 	 * @param Form $form
1262
-	 * @return SS_HTTPResponse
1262
+	 * @return \SS_HTTPResponse|null
1263 1263
 	 */
1264 1264
 	public function doRollback($data, $form) {
1265 1265
 		$this->extend('onBeforeRollback', $data['ID']);
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigatorItem.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	protected $recordLink;
28 28
 
29 29
 	/**
30
-	 * @param DataObject|CMSPreviewable $record
30
+	 * @param CMSPreviewable $record
31 31
 	 */
32 32
 	public function __construct(CMSPreviewable $record)
33 33
 	{
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/**
79
-	 * @return DataObject
79
+	 * @return CMSPreviewable
80 80
 	 */
81 81
 	public function getRecord()
82 82
 	{
Please login to merge, or discard this patch.
code/Controllers/CMSPageEditController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 * Url handler for add to campaign form
71 71
 	 *
72 72
 	 * @param SS_HTTPRequest $request
73
-	 * @return Form
73
+	 * @return null|\Form
74 74
 	 */
75 75
 	public function AddToCampaignForm($request)
76 76
 	{
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
 	/**
83 83
 	 * @param int $id
84
-	 * @return Form
84
+	 * @return null|\Form
85 85
 	 */
86 86
 	public function getAddToCampaignForm($id)
87 87
 	{
Please login to merge, or discard this patch.
code/Controllers/CMSPageHistoryController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
 	/**
59 59
 	 * @param SS_HTTPRequest $request
60
-	 * @return array
60
+	 * @return \SS_HTTPResponse
61 61
 	 */
62 62
 	public function show($request) {
63 63
 		$form = $this->ShowVersionForm($request->param('VersionID'));
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
 	/**
78 78
 	 * @param SS_HTTPRequest $request
79
-	 * @return array
79
+	 * @return \SS_HTTPResponse
80 80
 	 */
81 81
 	public function compare($request) {
82 82
 		$form = $this->CompareVersionsForm(
Please login to merge, or discard this patch.
code/Controllers/OldPageRedirector.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\CMS\Controllers;
4 4
 
5
-use SilverStripe\ORM\Queries\SQLSelect;
6 5
 use SilverStripe\CMS\Model\SiteTree;
7 6
 use Extension;
8 7
 use Director;
Please login to merge, or discard this patch.
code/Controllers/SilverStripeNavigatorItem_ArchiveLink.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use Controller;
5 5
 use SilverStripe\CMS\Model\RedirectorPage;
6
-use SilverStripe\ORM\FieldType\DBDatetime;
7 6
 use SilverStripe\ORM\FieldType\DBField;
8 7
 use SilverStripe\ORM\Versioning\Versioned;
9 8
 
Please login to merge, or discard this patch.