silverstripe / silverstripe-cms

code/Forms/SiteTreeURLSegmentField.php

Doc Comments +3 added lines

@@ -118,6 +118,9 @@
 		return $this->defaultUrl;
 	}
 
+	/**
+	 * @param string $url
+	 */
 	public function setDefaultURL($url) {
 		$this->defaultUrl = $url;
 		return $this;

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Core\Convert;
 use SilverStripe\Forms\TextField;
-use SilverStripe\View\Requirements;
 
 /**
  * Used to edit the SiteTree->URLSegment property, and suggest input based on the serverside rules

code/Model/ErrorPage.php

Doc Comments +1 added lines, -1 removed lines

@@ -252,7 +252,7 @@
 	/**
 	 * Write out the published version of the page to the filesystem
 	 *
-	 * @return true if the page write was successful
+	 * @return boolean if the page write was successful
 	 */
 	public function writeStaticPage() {
 		if(!self::config()->enable_static_file) {

code/Model/SiteTree.php

Doc Comments +1 added lines, -1 removed lines

@@ -753,7 +753,7 @@
 	 * @param boolean $unlinked Whether to link page titles.
 	 * @param boolean|string $stopAtPageType ClassName of a page to stop the upwards traversal.
 	 * @param boolean $showHidden Include pages marked with the attribute ShowInMenus = 0
-	 * @return string The breadcrumb trail.
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText The breadcrumb trail.
 	 */
 	public function Breadcrumbs($maxDepth = 20, $unlinked = false, $stopAtPageType = false, $showHidden = false) {
 		$pages = $this->getBreadcrumbItems($maxDepth, $stopAtPageType, $showHidden);

code/Controllers/SilverStripeNavigatorItem.php

Doc Comments +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 	protected $recordLink;
 
 	/**
-	 * @param DataObject|CMSPreviewable $record
+	 * @param CMSPreviewable $record
 	 */
 	public function __construct(CMSPreviewable $record)
 	{
@@ -76,7 +76,7 @@ 
 	}
 
 	/**
-	 * @return DataObject
+	 * @return CMSPreviewable
 	 */
 	public function getRecord()
 	{

code/Model/SiteTreeFileExtension.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\CMS\Model;
 
 use SilverStripe\Assets\File;
-use SilverStripe\Core\Convert;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\ReadonlyField;
 use SilverStripe\ORM\DataExtension;

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 	/**
 	 * Generate an HTML list which provides links to where a file is used.
 	 *
-	 * @return string
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText
 	 */
 	public function BackLinkHTMLList() {
 		$viewer = new SSViewer(["type" => "Includes", self::class . "_description"]);

code/Controllers/CMSPageEditController.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 	 *
 	 * @param array $data
 	 * @param Form $form
-	 * @return DBHTMLText|HTTPResponse
+	 * @return null|HTTPResponse
 	 */
 	public function addtocampaign($data, $form)
 	{

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\HTTPResponse;
-use SilverStripe\Core\Convert;
 use SilverStripe\Forms\Form;
 use SilverStripe\ORM\FieldType\DBHTMLText;
 

code/Controllers/CMSPageHistoryController.php

Doc Comments +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
 
 	/**
 	 * @param HTTPRequest $request
-	 * @return array
+	 * @return HTTPResponse
 	 */
 	public function show($request) {
 		$form = $this->ShowVersionForm($request->param('VersionID'));
@@ -76,7 +76,7 @@ 
 
 	/**
 	 * @param HTTPRequest $request
-	 * @return array
+	 * @return HTTPResponse
 	 */
 	public function compare($request) {
 		$form = $this->CompareVersionsForm(

code/Controllers/CMSMain.php

Doc Comments +6 added lines, -3 removed lines

@@ -316,6 +316,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $link
+	 */
 	public function LinkWithSearch($link) {
 		// Whitelist to avoid side effects
 		$params = array(
@@ -799,7 +802,7 @@ 
 
 	/**
 	 * @param HTTPRequest $request
-	 * @return string HTML
+	 * @return HTTPResponse HTML
 	 */
 	public function treeview($request) {
 		return $this->getResponseNegotiator()->respond($request);
@@ -807,7 +810,7 @@ 
 
 	/**
 	 * @param HTTPRequest $request
-	 * @return string HTML
+	 * @return HTTPResponse HTML
 	 */
 	public function listview($request) {
 		return $this->getResponseNegotiator()->respond($request);
@@ -1149,7 +1152,7 @@ 
 	 * Actually perform the publication step
 	 *
 	 * @param Versioned|DataObject $record
-	 * @return mixed
+	 * @return HTTPResponse|null
 	 */
 	public function performPublish($record) {
 		if($record && !$record->canPublish()) {

code/Controllers/CMSPageAddController.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use SilverStripe\Forms\TreeDropdownField;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBField;
-use SilverStripe\ORM\ValidationException;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;