| Conditions | 1 |
| Paths | 1 |
| Total Lines | 19 |
| Code Lines | 10 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 13 | public function testTitleFilter() |
||
| 14 | { |
||
| 15 | $this->session()->set('loggedInAs', $this->idFromFixture(Member::class, 'admin')); |
||
| 16 | |||
| 17 | $this->get( |
||
| 18 | 'admin/pages/?' . |
||
| 19 | http_build_query([ |
||
| 20 | 'q' => [ |
||
| 21 | 'Term' => 'Page 10', |
||
| 22 | 'FilterClass' => CMSSiteTreeFilter_Search::class, |
||
| 23 | ] |
||
| 24 | ]) |
||
| 25 | ); |
||
| 26 | |||
| 27 | $titles = $this->getPageTitles(); |
||
| 28 | $this->assertEquals(count($titles), 1); |
||
| 29 | // For some reason the title gets split into two lines |
||
| 30 | |||
| 31 | $this->assertStringContainsString('Page 1', $titles[0]); |
||
| 32 | } |
||
| 46 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.