SilverStripe\CMS\Tests\Search\CMSMainSearchFormTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testTitleFilter()	0	19	1
A	getPageTitles()	0	10	3

<?php

namespace SilverStripe\CMS\Tests\Search;

use SilverStripe\CMS\Controllers\CMSSiteTreeFilter_Search;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\Security\Member;

class CMSMainSearchFormTest extends FunctionalTest
{
    protected static $fixture_file = '../Controllers/CMSMainTest.yml';

    public function testTitleFilter()
    {
        $this->session()->set('loggedInAs', $this->idFromFixture(Member::class, 'admin'));

        $this->get(
            'admin/pages/?' .
            http_build_query([
                'q' => [
                    'Term' => 'Page 10',
                    'FilterClass' => CMSSiteTreeFilter_Search::class,
                ]
            ])
        );

        $titles = $this->getPageTitles();
        $this->assertEquals(count($titles), 1);
        // For some reason the title gets split into two lines

        $this->assertStringContainsString('Page 1', $titles[0]);
    }

    protected function getPageTitles()
    {
        $titles = [];
        $links = $this->cssParser()->getBySelector('.col-getTreeTitle span.item');
        if ($links) {

The expression $links of type SimpleXMLElement[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($links as $link) {
                $titles[] = preg_replace('/\n/', ' ', $link->asXML());
            }
        }
        return $titles;
    }
}