silverstripe / silverstripe-campaign-admin

tests/php/CampaignAdminTest.php

Spacing +10 added lines, -10 removed lines

@@ -94,7 +94,7 @@ 
         $results = $this->callProtectedMethod($admin, 'getListItems');
         $this->assertDOSEquals(
             [
-                [ 'Name' => 'changeset 1' ],
+                ['Name' => 'changeset 1'],
             ],
             $results
         );
@@ -104,8 +104,8 @@ 
         $results = $this->callProtectedMethod($admin, 'getListItems');
         $this->assertDOSEquals(
             [
-                [ 'Name' => 'changeset 1' ],
-                [ 'Name' => 'changeset 2' ],
+                ['Name' => 'changeset 1'],
+                ['Name' => 'changeset 2'],
             ],
             $results
         );
@@ -115,10 +115,10 @@ 
         $results = $this->callProtectedMethod($admin, 'getListItems');
         $this->assertDOSEquals(
             [
-                [ 'Name' => 'changeset 1' ],
-                [ 'Name' => 'changeset 2' ],
-                [ 'Name' => 'changeset 3' ],
-                [ 'Name' => 'changeset 4' ],
+                ['Name' => 'changeset 1'],
+                ['Name' => 'changeset 2'],
+                ['Name' => 'changeset 3'],
+                ['Name' => 'changeset 4'],
             ],
             $results
         );
@@ -128,8 +128,8 @@ 
         $results = $this->callProtectedMethod($admin, 'getListItems');
         $this->assertDOSEquals(
             [
-                [ 'Name' => 'changeset 1' ],
-                [ 'Name' => 'changeset 3' ],
+                ['Name' => 'changeset 1'],
+                ['Name' => 'changeset 3'],
             ],
             $results
         );
@@ -177,7 +177,7 @@ 
         $user = $this->objFromFixture(Member::class, 'mock_user');
         $this->logInAs($user);
 
-        $request->setRouteParams([ 'ID' => '1', 'Name' => 'show']);
+        $request->setRouteParams(['ID' => '1', 'Name' => 'show']);
         $response = $campaignAdmin->readCampaign($request);
         $status = $response->getStatusCode();
 

src/CampaignAdmin.php

Spacing +21 added lines, -21 removed lines

@@ -167,7 +167,7 @@ 
         $form->addExtraClass('form--padded');
 
         // Set callback response
-        $form->setValidationResponseCallback(function () use ($form) {
+        $form->setValidationResponseCallback(function() use ($form) {
             $schemaId = $this->Link('schema/EditForm');
             return $this->getSchemaResponse($form, $schemaId);
         });
@@ -214,7 +214,7 @@ 
                 'baseClass' => DataObject::getSchema()->baseDataClass($class),
                 'singular' => $item->i18n_singular_name(),
                 'plural' => $item->i18n_plural_name(),
-                'noItemsText' => _t(__CLASS__.'.NOITEMSTEXT', 'Add items from the {section} section', [
+                'noItemsText' => _t(__CLASS__ . '.NOITEMSTEXT', 'Add items from the {section} section', [
                     'section' => $item->i18n_plural_name(),
                 ]),
                 'items' => []
@@ -282,7 +282,7 @@ 
             'Created' => $changeSet->Created,
             'LastEdited' => $changeSet->LastEdited,
             'State' => $changeSet->State,
-            'StateLabel' => [ 'html' => $stateLabel ],
+            'StateLabel' => ['html' => $stateLabel],
             'IsInferred' => $changeSet->IsInferred,
             'canEdit' => $changeSet->canEdit(),
             'canPublish' => false,
@@ -340,8 +340,8 @@ 
             return [];
         }
 
-        $thumbnailWidth = (int)$this->config()->get('thumbnail_width');
-        $thumbnailHeight = (int)$this->config()->get('thumbnail_height');
+        $thumbnailWidth = (int) $this->config()->get('thumbnail_width');
+        $thumbnailHeight = (int) $this->config()->get('thumbnail_height');
         $hal = [
             '_links' => [
                 'self' => [
@@ -421,7 +421,7 @@ 
             $changesets = $changesets->filter('IsInferred', 0);
         }
         return $changesets
-            ->filterByCallback(function ($item) {
+            ->filterByCallback(function($item) {
                 /** @var ChangeSet $item */
                 return ($item->canView());
             });
@@ -450,7 +450,7 @@ 
             /** @var ChangeSet $changeSet */
             $changeSet = ChangeSet::get()->filter('IsInferred', 0)->byID($request->param('ID'));
 
-            var_dump($request->param('ID'), " =====",  $changeSet);
+            var_dump($request->param('ID'), " =====", $changeSet);
 
             if (!$changeSet) {
                 return (new HTTPResponse(null, 404));
@@ -631,19 +631,19 @@ 
             'campaignEditForm',
             $fields,
             FieldList::create(
-                FormAction::create('save', _t(__CLASS__.'SAVE', 'Save'))
+                FormAction::create('save', _t(__CLASS__ . 'SAVE', 'Save'))
                     ->setIcon('save')
                     ->setSchemaState([
                         'data' => [
-                            'pristineTitle' => _t(__CLASS__.'SAVED', 'Saved'),
+                            'pristineTitle' => _t(__CLASS__ . 'SAVED', 'Saved'),
                             'pristineIcon' => 'tick',
-                            'dirtyTitle' => _t(__CLASS__.'SAVE', 'Save'),
+                            'dirtyTitle' => _t(__CLASS__ . 'SAVE', 'Save'),
                             'dirtyIcon' => 'save',
                             'pristineClass' => 'btn-outline-primary',
                             'dirtyClass' => '',
                         ],
                     ]),
-                FormAction::create('cancel', _t(__CLASS__.'.CANCEL', 'Cancel'))
+                FormAction::create('cancel', _t(__CLASS__ . '.CANCEL', 'Cancel'))
                     ->setUseButtonTag(true)
             ),
             new RequiredFields('Name')
@@ -654,12 +654,12 @@ 
 
         // Set form action handler with ID included
         $form->setRequestHandler(
-            LeftAndMainFormRequestHandler::create($form, [ $id ])
+            LeftAndMainFormRequestHandler::create($form, [$id])
         );
 
         // Configure form to respond to validation errors with form schema
         // if requested via react.
-        $form->setValidationResponseCallback(function (ValidationResult $errors) use ($form, $id, $record) {
+        $form->setValidationResponseCallback(function(ValidationResult $errors) use ($form, $id, $record) {
             $schemaId = Controller::join_links(
                 $this->Link('schema'),
                 'campaignEditForm',
@@ -706,9 +706,9 @@ 
             'campaignCreateForm',
             $fields,
             FieldList::create(
-                FormAction::create('save', _t(__CLASS__.'.CREATE', 'Create'))
+                FormAction::create('save', _t(__CLASS__ . '.CREATE', 'Create'))
                     ->setIcon('plus'),
-                FormAction::create('cancel', _t(__CLASS__.'.CANCEL', 'Cancel'))
+                FormAction::create('cancel', _t(__CLASS__ . '.CANCEL', 'Cancel'))
                     ->setUseButtonTag(true)
             ),
             new RequiredFields('Name')
@@ -721,7 +721,7 @@ 
 
         // Configure form to respond to validation errors with form schema
         // if requested via react.
-        $form->setValidationResponseCallback(function (ValidationResult $errors) use ($form, $record) {
+        $form->setValidationResponseCallback(function(ValidationResult $errors) use ($form, $record) {
             $schemaId = $this->Link('schema/campaignCreateForm');
             return $this->getSchemaResponse($schemaId, $form, $errors);
         });
@@ -750,7 +750,7 @@ 
                 return Security::permissionFailure($this);
             }
             if (!$record || !$record->ID) {
-                $this->httpError(404, "Bad record ID #" . (int)$id);
+                $this->httpError(404, "Bad record ID #" . (int) $id);
             }
         } else {
             if (!ChangeSet::singleton()->canCreate()) {
@@ -769,13 +769,13 @@ 
             $form->saveInto($record, true);
             $record->write();
             $this->extend('onAfterSave', $record);
-            $message = _t(__CLASS__.'.SAVEDUP', 'Saved.');
+            $message = _t(__CLASS__ . '.SAVEDUP', 'Saved.');
             $form->setMessage($message, ValidationResult::TYPE_GOOD);
         } else {
-            $nameDuplicateMsg = _t(__CLASS__ . '.ERROR_DUPLICATE_NAME', 'Name "{Name}" already exists', '', [ 'Name' => $data['Name']]);
+            $nameDuplicateMsg = _t(__CLASS__ . '.ERROR_DUPLICATE_NAME', 'Name "{Name}" already exists', '', ['Name' => $data['Name']]);
             $errors = new ValidationResult();
             $errors->addFieldMessage('Name', $nameDuplicateMsg);
-            $message = _t(__CLASS__.'.SAVEDERROR', 'Error.');
+            $message = _t(__CLASS__ . '.SAVEDERROR', 'Error.');
             // Need to set the form message or the field message won't show up at all
             $form->setMessage($message, ValidationResult::TYPE_ERROR);
         }
@@ -833,7 +833,7 @@ 
                 ),
                 'category' => _t('SilverStripe\\Security\\Permission.CMS_ACCESS_CATEGORY', 'CMS Access'),
                 'help' => _t(
-                    __CLASS__.'.ACCESS_HELP',
+                    __CLASS__ . '.ACCESS_HELP',
                     'Allow viewing of the campaign publishing section.'
                 )
             )