Completed
Pull Request — master (#500)
by Daniel
02:24 queued 10s
created
src/Forms/GridField/GridFieldAddByDBField.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      *
56 56
      * @param GridField $gridField
57 57
      *
58
-     * @return array
58
+     * @return string[]
59 59
      */
60 60
     public function getActions($gridField)
61 61
     {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      * @param $arguments mixed
73 73
      * @param $data array
74 74
      *
75
-     * @return null|SS_HTTPResponse
75
+     * @return \SilverStripe\Control\HTTPResponse|null
76 76
      *
77 77
      * @throws UnexpectedValueException
78 78
      */
Please login to merge, or discard this patch.
src/Model/BlogPostFilter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
     /**
26 26
      * Augment queries so that we don't fetch unpublished articles.
27 27
      *
28
-     * @param SQLQuery $query
28
+     * @param SQLSelect $query
29 29
      */
30 30
     public function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
31 31
     {
Please login to merge, or discard this patch.
src/Widgets/BlogTagsWidget.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use SilverStripe\Blog\Model\Blog;
10 10
 use SilverStripe\Core\Convert;
11 11
 use SilverStripe\Forms\DropdownField;
12
-use SilverStripe\Forms\FieldList;
13 12
 use SilverStripe\Forms\NumericField;
14 13
 use SilverStripe\Widgets\Model\Widget;
15 14
 
Please login to merge, or discard this patch.
src/Model/BlogPost.php 2 patches
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
     /**
376 376
      * @param null|int|Member $member
377 377
      *
378
-     * @return null|Member
378
+     * @return \SilverStripe\ORM\DataObject|null
379 379
      */
380 380
     protected function getMember($member = null)
381 381
     {
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
      *
396 396
      * @param null|int|Member $member
397 397
      *
398
-     * @return bool
398
+     * @return boolean|string
399 399
      */
400 400
     public function canCreateCategories($member = null)
401 401
     {
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
      *
420 420
      * @param null|int|Member $member
421 421
      *
422
-     * @return bool
422
+     * @return boolean|string
423 423
      */
424 424
     public function canCreateTags($member = null)
425 425
     {
@@ -514,6 +514,8 @@  discard block
 block discarded – undo
514 514
 
515 515
     /**
516 516
      * {@inheritdoc}
517
+     * @param Member $member
518
+     * @return boolean
517 519
      */
518 520
     public function canPublish($member = null)
519 521
     {
@@ -550,6 +552,7 @@  discard block
 block discarded – undo
550 552
 
551 553
     /**
552 554
      * {@inheritdoc}
555
+     * @param \SilverStripe\ORM\DataObject $member
553 556
      */
554 557
     public function canEdit($member = null)
555 558
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -12,8 +12,6 @@
 block discarded – undo
12 12
 use SilverStripe\Core\Config\Config;
13 13
 use SilverStripe\Core\Manifest\ModuleLoader;
14 14
 use SilverStripe\Forms\DatetimeField;
15
-use SilverStripe\Forms\HiddenField;
16
-use SilverStripe\Forms\HTMLEditor\HTMLEditorField;
17 15
 use SilverStripe\Forms\ListboxField;
18 16
 use SilverStripe\Forms\TextField;
19 17
 use SilverStripe\Forms\ToggleCompositeField;
Please login to merge, or discard this patch.
tests/BlogTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 use SilverStripe\Control\Session;
13 13
 use SilverStripe\Core\Config\Config;
14 14
 use SilverStripe\Dev\SapphireTest;
15
-use SilverStripe\ORM\DataModel;
16 15
 use SilverStripe\ORM\FieldType\DBDatetime;
17 16
 use SilverStripe\ORM\SS_List;
18 17
 use SilverStripe\Security\Member;
Please login to merge, or discard this patch.
src/Model/BlogObject.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SilverStripe\Blog\Model;
4 4
 
5 5
 use SilverStripe\Control\Controller;
6
-use SilverStripe\Core\ClassInfo;
7 6
 use SilverStripe\Forms\FieldList;
8 7
 use SilverStripe\Forms\Tab;
9 8
 use SilverStripe\Forms\TabSet;
Please login to merge, or discard this patch.
src/Model/Blog.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -195,6 +195,8 @@  discard block
 block discarded – undo
195 195
     }
196 196
     /**
197 197
      * {@inheritdoc}
198
+     * @param Member $member
199
+     * @return boolean
198 200
      */
199 201
     public function canEdit($member = null)
200 202
     {
@@ -210,7 +212,7 @@  discard block
 block discarded – undo
210 212
     /**
211 213
      * @param null|int|Member $member
212 214
      *
213
-     * @return null|Member
215
+     * @return DataObject|null
214 216
      */
215 217
     protected function getMember($member = null)
216 218
     {
@@ -329,6 +331,8 @@  discard block
 block discarded – undo
329 331
 
330 332
     /**
331 333
      * {@inheritdoc}
334
+     * @param Member $member
335
+     * @return boolean
332 336
      */
333 337
     public function canAddChildren($member = null)
334 338
     {
@@ -432,7 +436,7 @@  discard block
 block discarded – undo
432 436
     /**
433 437
      * Gets the list of user candidates to be assigned to assist with this blog.
434 438
      *
435
-     * @return SS_List
439
+     * @return \SilverStripe\ORM\SS_List
436 440
      */
437 441
     protected function getCandidateUsers()
438 442
     {
Please login to merge, or discard this patch.
src/Model/BlogController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     /**
91 91
      * Get the Member associated with the current URL segment.
92 92
      *
93
-     * @return null|Member
93
+     * @return \SilverStripe\ORM\DataObject|null
94 94
      */
95 95
     public function getCurrentProfile()
96 96
     {
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
     /**
496 496
      * Returns the current archive date.
497 497
      *
498
-     * @return null|DBDatetime
498
+     * @return BlogController|null
499 499
      */
500 500
     public function getArchiveDate()
501 501
     {
Please login to merge, or discard this patch.