Completed
Pull Request — master (#426)
by Ingo
02:14
created
code/Forms/UploadField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@
 block discarded – undo
137 137
     /**
138 138
      * Set upload type to multi / single
139 139
      *
140
-     * @param $multi
140
+     * @param boolean $multi
141 141
      * @return $this
142 142
      */
143 143
     public function setIsMultiUpload($multi)
Please login to merge, or discard this patch.
code/Controller/AssetAdmin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -902,7 +902,7 @@
 block discarded – undo
902 902
      *
903 903
      * @param array $data
904 904
      * @param Form $form
905
-     * @return DBHTMLText|HTTPResponse
905
+     * @return null|HTTPResponse
906 906
      */
907 907
     public function addtocampaign($data, $form)
908 908
     {
Please login to merge, or discard this patch.
code/GraphQL/FolderTypeCreator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use GraphQL\Type\Definition\ResolveInfo;
6 6
 use GraphQL\Type\Definition\Type;
7 7
 use SilverStripe\AssetAdmin\Controller\AssetAdminFile;
8
-use SilverStripe\AssetAdmin\Controller\AssetAdminFolder;
9 8
 use SilverStripe\Assets\File;
10 9
 use SilverStripe\Assets\Folder;
11 10
 use SilverStripe\ORM\Filterable;
Please login to merge, or discard this patch.
code/Controller/AssetAdminFile.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@
 block discarded – undo
208 208
      *
209 209
      * @param int $parentID
210 210
      * @param int $maxDepth Hard limit of max depth
211
-     * @return array List of parent IDs, including $parentID
211
+     * @return integer[] List of parent IDs, including $parentID
212 212
      */
213 213
     public static function nestedFolderIDs($parentID, $maxDepth = 5)
214 214
     {
Please login to merge, or discard this patch.
code/GraphQL/ReadFileQueryCreator.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -51,6 +51,9 @@
 block discarded – undo
51 51
             ->setConnectionResolver(array($this, 'resolveConnection'));
52 52
     }
53 53
 
54
+    /**
55
+     * @param \GraphQL\Type\Definition\ResolveInfo $info
56
+     */
54 57
     public function resolveConnection($object, array $args, $context, $info)
55 58
     {
56 59
         $filter = (!empty($args['filter'])) ? $args['filter'] : [];
Please login to merge, or discard this patch.
code/Forms/RemoteFileFormFactory.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -66,6 +66,10 @@  discard block
 block discarded – undo
66 66
         return ['type'];
67 67
     }
68 68
     
69
+    /**
70
+     * @param Controller $controller
71
+     * @param string $name
72
+     */
69 73
     protected function getFormFields($controller, $name, $context)
70 74
     {
71 75
         $fields = [];
@@ -130,6 +134,10 @@  discard block
 block discarded – undo
130 134
         return FieldList::create($fields);
131 135
     }
132 136
     
137
+    /**
138
+     * @param Controller $controller
139
+     * @param string $name
140
+     */
133 141
     protected function getFormActions($controller, $name, $context)
134 142
     {
135 143
         $actions = [];
Please login to merge, or discard this patch.
code/Forms/AssetFormFactory.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      * Get the validator for the form to be built
82 82
      *
83 83
      * @param $controller
84
-     * @param $formName
84
+     * @param string $formName
85 85
      * @param $context
86 86
      * @return RequiredFields
87 87
      */
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
     /**
151 151
      * @param Controller $controller
152
-     * @param $formName
152
+     * @param string $formName
153 153
      * @param array $context
154 154
      * @return FieldList
155 155
      */
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
      * Get actions that go into the Popover menu
229 229
      *
230 230
      * @param File $record
231
-     * @return array
231
+     * @return string|null
232 232
      */
233 233
     protected function getPopoverActions($record)
234 234
     {
Please login to merge, or discard this patch.