silverstripe / silverstripe-asset-admin

code/Controller/AssetAdmin.php

Doc Comments +1 added lines, -1 removed lines

@@ -902,7 +902,7 @@
      *
      * @param array $data
      * @param Form $form
-     * @return DBHTMLText|HTTPResponse
+     * @return null|HTTPResponse
      */
     public function addtocampaign($data, $form)
     {

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\HTTPResponse;
-use SilverStripe\Control\RequestHandler;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\Forms\Form;

code/GraphQL/FolderTypeCreator.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use GraphQL\Type\Definition\ResolveInfo;
 use GraphQL\Type\Definition\Type;
 use SilverStripe\AssetAdmin\Controller\AssetAdminFile;
-use SilverStripe\AssetAdmin\Controller\AssetAdminFolder;
 use SilverStripe\Assets\File;
 use SilverStripe\Assets\Folder;
 use SilverStripe\ORM\Filterable;

code/Controller/AssetAdminFile.php

Doc Comments +1 added lines, -1 removed lines

@@ -208,7 +208,7 @@
      *
      * @param int $parentID
      * @param int $maxDepth Hard limit of max depth
-     * @return array List of parent IDs, including $parentID
+     * @return integer[] List of parent IDs, including $parentID
      */
     public static function nestedFolderIDs($parentID, $maxDepth = 5)
     {

code/GraphQL/ReadFileQueryCreator.php

Doc Comments +3 added lines

@@ -51,6 +51,9 @@
             ->setConnectionResolver(array($this, 'resolveConnection'));
     }
 
+    /**
+     * @param \GraphQL\Type\Definition\ResolveInfo $info
+     */
     public function resolveConnection($object, array $args, $context, $info)
     {
         $filter = (!empty($args['filter'])) ? $args['filter'] : [];

tests/php/Forms/UploadFieldTest.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SilverStripe\Assets\Image;
 use SilverStripe\Assets\Tests\Storage\AssetStoreTest\TestAssetStore;
 use SilverStripe\Control\Controller;
-use SilverStripe\Dev\Debug;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;

code/Forms/RemoteFileFormFactory.php

Doc Comments +8 added lines

@@ -77,6 +77,10 @@ 
         return ['type'];
     }
 
+    /**
+     * @param null|RequestHandler $controller
+     * @param string $name
+     */
     protected function getFormFields($controller, $name, $context)
     {
         $formType = $context['type'];
@@ -90,6 +94,10 @@ 
         }
     }
 
+    /**
+     * @param null|RequestHandler $controller
+     * @param string $name
+     */
     protected function getFormActions($controller, $name, $context)
     {
         $actions = [];

code/Forms/AssetFormFactory.php

Doc Comments +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
      * Get the validator for the form to be built
      *
      * @param RequestHandler $controller
-     * @param $formName
+     * @param string $formName
      * @param $context
      * @return RequiredFields
      */
@@ -172,7 +172,7 @@ 
 
     /**
      * @param RequestHandler $controller
-     * @param $formName
+     * @param string $formName
      * @param array $context
      * @return FieldList
      */