silverstripe / silverstripe-asset-admin

code/Controller/AssetAdmin.php

Doc Comments +2 added lines, -1 removed lines

@@ -560,7 +560,7 @@ 
 
     /**
      * @param  bool      $unlinked
-     * @return ArrayList
+     * @return \ArrayList
      */
     public function breadcrumbs($unlinked = false)
     {
@@ -605,6 +605,7 @@ 
     /**
      * Don't include class namespace in template names
      * @todo Make code in framework more namespace-savvy so that we don't need this duplication
+     * @param string $suffix
      */
     public function getTemplatesWithSuffix($suffix)
     {

Unused Use Statements -2 removed lines

@@ -18,7 +18,6 @@ 
 use Form;
 use FormAction;
 use CheckboxField;
-use Convert;
 use ArrayData;
 use File;
 use Session;
@@ -30,7 +29,6 @@ 
 use Folder;
 use Security;
 use CMSForm;
-use CMSBatchAction;
 use SS_List;
 use CompositeField;
 use SSViewer;

code/FormField/AssetGalleryField.php

Doc Comments +2 added lines, -3 removed lines

@@ -147,7 +147,7 @@ 
      *
      * @param SS_HTTPRequest $request
      *
-     * @return SS_HTTPResponse
+     * @return Controller|null
      */
     public function item(SS_HTTPRequest $request)
     {
@@ -538,7 +538,7 @@ 
     /**
      * @param null|string $folder
      *
-     * @return null|Folder
+     * @return null|\DataObject
      */
     protected function getFolder($folder = null)
     {
@@ -775,7 +775,6 @@ 
     }
 
     /**
-     * @param boolean $bulkActions
      *
      * @return $this
      */

Unused Use Statements -2 removed lines

@@ -11,8 +11,6 @@
 use SS_HTTPRequest;
 use SS_HTTPResponse;
 use DataList;
-use Convert;
-use SilverStripe\Filesystem\Storage\AssetContainer;
 
 /**
  * Class AssetGalleryField

code/FormField/DropzoneUploadField.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      * This method is identical to `AssetGalleryField::getObjectFromData`.
      * Ideally this would be on File, and be available at some endpoint, similar to the form field schema.
      *
-     * @param $file
+     * @param \SilverStripe\Filesystem\Storage\AssetContainer $file
      *
      * @return array
      */

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SS_HTTPRequest;
 use SS_HTTPResponse;
 use Folder;
-use DataObject;
 
 /**
  * Class DropzoneUploadField

tests/behat/features/bootstrap/FeatureContext.php

Unused Use Statements +2 added lines, -7 removed lines

@@ -2,13 +2,8 @@
 
 namespace SilverStripe\Cms\Test\Behaviour;
 
-use SilverStripe\BehatExtension\Context\SilverStripeContext,
-    SilverStripe\BehatExtension\Context\BasicContext,
-    SilverStripe\BehatExtension\Context\LoginContext,
-    SilverStripe\BehatExtension\Context\FixtureContext,
-    SilverStripe\Framework\Test\Behaviour\CmsFormsContext,
-    SilverStripe\Framework\Test\Behaviour\CmsUiContext,
-    SilverStripe\Cms\Test\Behaviour;
+use SilverStripe\BehatExtension\Context\FixtureContext;
+use SilverStripe\Cms\Test\Behaviour;
 
 // PHPUnit
 require_once 'PHPUnit/Autoload.php';

tests/behat/features/bootstrap/SilverStripe/Cms/Test/Behaviour/ThemeContext.php

Doc Comments +6 added lines

@@ -52,6 +52,9 @@ 
         $this->requireFile(BASE_PATH . '/themes/' . $theme . '/templates/' . $template, $content);
     }
 
+    /**
+     * @param string $filename
+     */
     protected function requireFile($filename, $content)
     {
         // Already exists
@@ -69,6 +72,9 @@ 
         }
     }
 
+    /**
+     * @param string $dirname
+     */
     protected function requireDir($dirname)
     {
         // Directory doesn't exist, create it and mark it for deletion

Unused Use Statements +1 added lines, -9 removed lines

@@ -2,15 +2,7 @@
 
 namespace SilverStripe\Cms\Test\Behaviour;
 
-use Behat\Behat\Context\ClosuredContextInterface,
-    Behat\Behat\Context\TranslatedContextInterface,
-    Behat\Behat\Context\BehatContext,
-    Behat\Behat\Context\Step,
-    Behat\Behat\Event\StepEvent,
-    Behat\Behat\Exception\PendingException,
-    Behat\Mink\Driver\Selenium2Driver,
-    Behat\Gherkin\Node\PyStringNode,
-    Behat\Gherkin\Node\TableNode;
+use Behat\Behat\Context\BehatContext;
 
 // PHPUnit
 require_once 'PHPUnit/Autoload.php';

tests/php/AssetAdminTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * @param string $from Created from date
      * @param string $to Createi to date
      * @param string $category
-     * @return SS_List
+     * @return \SS_List
      */
     protected function getResultsForSearch($name = '', $from = '', $to = '', $category = '')
     {