silverstripe / silverstripe-asset-admin

tests/behat/features/bootstrap/FeatureContext.php

Unused Use Statements +2 added lines, -7 removed lines

@@ -2,13 +2,8 @@
 
 namespace SilverStripe\Cms\Test\Behaviour;
 
-use SilverStripe\BehatExtension\Context\SilverStripeContext,
-    SilverStripe\BehatExtension\Context\BasicContext,
-    SilverStripe\BehatExtension\Context\LoginContext,
-    SilverStripe\BehatExtension\Context\FixtureContext,
-    SilverStripe\Framework\Test\Behaviour\CmsFormsContext,
-    SilverStripe\Framework\Test\Behaviour\CmsUiContext,
-    SilverStripe\Cms\Test\Behaviour;
+use SilverStripe\BehatExtension\Context\FixtureContext;
+use SilverStripe\Cms\Test\Behaviour;
 
 // PHPUnit
 require_once 'PHPUnit/Autoload.php';

tests/behat/features/bootstrap/SilverStripe/Cms/Test/Behaviour/ThemeContext.php

Doc Comments +6 added lines

@@ -52,6 +52,9 @@ 
         $this->requireFile(BASE_PATH . '/themes/' . $theme . '/templates/' . $template, $content);
     }
 
+    /**
+     * @param string $filename
+     */
     protected function requireFile($filename, $content)
     {
         // Already exists
@@ -69,6 +72,9 @@ 
         }
     }
 
+    /**
+     * @param string $dirname
+     */
     protected function requireDir($dirname)
     {
         // Directory doesn't exist, create it and mark it for deletion

Unused Use Statements +1 added lines, -9 removed lines

@@ -2,15 +2,7 @@
 
 namespace SilverStripe\Cms\Test\Behaviour;
 
-use Behat\Behat\Context\ClosuredContextInterface,
-    Behat\Behat\Context\TranslatedContextInterface,
-    Behat\Behat\Context\BehatContext,
-    Behat\Behat\Context\Step,
-    Behat\Behat\Event\StepEvent,
-    Behat\Behat\Exception\PendingException,
-    Behat\Mink\Driver\Selenium2Driver,
-    Behat\Gherkin\Node\PyStringNode,
-    Behat\Gherkin\Node\TableNode;
+use Behat\Behat\Context\BehatContext;
 
 // PHPUnit
 require_once 'PHPUnit/Autoload.php';

code/Controller/AssetAdmin.php

Doc Comments +2 added lines, -2 removed lines

@@ -313,7 +313,7 @@ 
      * Creates a single file based on a form-urlencoded upload.
      *
      * @param SS_HTTPRequest $request
-     * @return SS_HTTPRequest|SS_HTTPResponse
+     * @return SS_HTTPResponse
      */
     public function apiCreateFile(SS_HTTPRequest $request)
     {
@@ -374,7 +374,7 @@ 
      * Creates a single folder, within an optional parent folder.
      *
      * @param SS_HTTPRequest $request
-     * @return SS_HTTPRequest|SS_HTTPResponse
+     * @return SS_HTTPResponse
      */
     public function apiCreateFolder(SS_HTTPRequest $request)
     {