silverstripe / silverstripe-activedirectory

src/Control/SAMLController.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
     }
 
     /**
-     * @return SS_HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse|null
      */
     protected function getRedirect()
     {

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ActiveDirectory\Model\LDAPUtil;
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Director;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\Form;
 use SilverStirpe\Security\Member;

src/Model/LDAPGroupMapping.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     /**
      * {@inheritDoc}
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {

src/Services/LDAPService.php

Doc Comments +3 added lines, -3 removed lines

@@ -273,7 +273,7 @@ 
      * Note that these get cached in-memory per-request for performance to avoid re-querying for the same results.
      *
      * @param string $dn
-     * @param array $attributes List of specific AD attributes to return. Empty array means return everything.
+     * @param string[] $attributes List of specific AD attributes to return. Empty array means return everything.
      * @return array
      */
     public function getNestedGroups($dn, $attributes = [])
@@ -477,7 +477,7 @@ 
      * @param Member
      * @param array|null $data If passed, this is pre-existing AD attribute data to update the Member with.
      *            If not given, the data will be looked up by the user's GUID.
-     * @return bool
+     * @return false|null
      */
     public function updateMemberFromLDAP(Member $member, $data = null)
     {
@@ -657,7 +657,7 @@ 
      * @param Group $group An existing Group or a new Group object
      * @param array $data LDAP group object data
      *
-     * @return bool
+     * @return false|null
      */
     public function updateGroupFromLDAP(Group $group, $data)
     {

src/Forms/LDAPChangePasswordForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      * Change the password
      *
      * @param array $data The user submitted data
-     * @return HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse
      */
     public function doChangePassword(array $data)
     {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Exception;
 use SilverStripe\Control\Director;
 use SilverStripe\Control\HTTP;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\TextField;

src/Control/LDAPDebugController.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
     /**
      * @param HTTPRequest $request
      *
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function index(HTTPRequest $request)
     {

src/Authenticators/LDAPAuthenticator.php

Unused Use Statements -2 removed lines

@@ -6,13 +6,11 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Email\Email;
 use SilverStripe\Control\HTTPRequest;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Authenticator;
 use SilverStripe\Security\Member;
-use SilverStripe\Security\MemberAuthenticator\LogoutHandler;
 use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
 
 /**

Doc Comments +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
      * @param array $data
      * @param HTTPRequest $request
      * @param ValidationResult|null $result
-     * @return null|Member
+     * @return null|\SilverStripe\ORM\DataObject
      * @internal param Form $form
      */
     public function authenticate(array $data, HTTPRequest $request, ValidationResult &$result = null)

src/Control/LDAPSecurityController.php

Doc Comments +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
     /**
      * Factory method for the lost password form
      *
-     * @return Form Returns the lost password form
+     * @return LDAPChangePasswordForm Returns the lost password form
      */
     public function ChangePasswordForm()
     {
@@ -103,7 +103,7 @@ 
     /**
      * Factory method for the lost password form
      *
-     * @return Form Returns the lost password form
+     * @return LDAPLoginForm Returns the lost password form
      */
     public function LostPasswordForm()
     {

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Director;
 use SilverStripe\Core\Convert;
-use SilverStripe\Core\Object;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Forms\EmailField;
 use SilverStripe\Forms\FormAction;

src/Authenticators/LDAPLoginForm.php

Unused Use Statements -2 removed lines

@@ -6,10 +6,8 @@
 use SilverStripe\ActiveDirectory\Services\LDAPService;
 use SilverStripe\Control\Email\Email;
 use SilverStripe\Control\RequestHandler;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\LiteralField;
 use SilverStripe\Forms\RequiredFields;
 use SilverStripe\Forms\TextField;

src/Authenticators/LDAPMemberLoginHandler.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator\LoginHandler;
-use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
 
 class LDAPMemberLoginHandler extends LoginHandler
 {