silverstripe / silverstripe-activedirectory

src/Authenticators/LDAPAuthenticator.php

Doc Comments +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
      * @param array $data
      * @param HTTPRequest $request
      * @param ValidationResult|null $result
-     * @return null|Member
+     * @return null|\SilverStripe\ORM\DataObject
      */
     public function authenticate(array $data, HTTPRequest $request, ValidationResult &$result = null)
     {

src/Authenticators/SAMLAuthenticator.php

Unused Use Statements -2 removed lines

@@ -6,10 +6,8 @@
 use SilverStripe\Control\Controller;
 use Silverstripe\Control\Director;
 use SilverStripe\Control\HTTPRequest;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Forms\Form;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Authenticator;
 use SilverStripe\Security\Member;

src/Services/LDAPService.php

Doc Comments +3 added lines, -3 removed lines

@@ -285,7 +285,7 @@ 
      * Note that these get cached in-memory per-request for performance to avoid re-querying for the same results.
      *
      * @param string $dn
-     * @param array $attributes List of specific AD attributes to return. Empty array means return everything.
+     * @param string[] $attributes List of specific AD attributes to return. Empty array means return everything.
      * @return array
      */
     public function getNestedGroups($dn, $attributes = [])
@@ -499,7 +499,7 @@ 
      *            If not given, the data will be looked up by the user's GUID.
      * @param bool $updateGroups controls whether to run the resource-intensive group update function as well. This is
      *                          skipped during login to reduce load.
-     * @return bool
+     * @return false|null
      * @internal param $Member
      */
     public function updateMemberFromLDAP(Member $member, $data = null, $updateGroups = true)
@@ -699,7 +699,7 @@ 
      * @param Group $group An existing Group or a new Group object
      * @param array $data LDAP group object data
      *
-     * @return bool
+     * @return false|null
      */
     public function updateGroupFromLDAP(Group $group, $data)
     {

src/Forms/LDAPChangePasswordForm.php

Unused Use Statements -5 removed lines

@@ -2,17 +2,12 @@
 
 namespace SilverStripe\ActiveDirectory\Forms;
 
-use Exception;
 use SilverStripe\ActiveDirectory\Authenticators\LDAPAuthenticator;
 use SilverStripe\ActiveDirectory\Services\LDAPService;
-use SilverStripe\Control\Director;
-use SilverStripe\Control\HTTP;
-use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\TextField;
-use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator\ChangePasswordForm;
 use SilverStripe\Security\Security;