silverstripe / silverstripe-activedirectory

src/Authenticators/LDAPAuthenticator.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
      *
      * @param array $data
      * @param Form $form
-     * @return bool|Member|void
+     * @return null|\SilverStripe\ORM\DataObject
      * @throws HTTPResponse_Exception
      */
     public static function authenticate($data, Form $form = null)

src/Authenticators/LDAPLoginForm.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
     /**
      * Constructor.
      *
-     * @param Controller $controller
+     * @param \SilverStripe\Control\Controller $controller
      * @param string $name method on the $controller
      * @param FieldList $fields
      * @param FieldList $actions
@@ -118,7 +118,7 @@ 
      * instead of the SecurityController
      *
      * @param array $data Submitted data
-     * @return SS_HTTPResponse
+     * @return null|\SilverStripe\Control\HTTPResponse
      */
     public function forgotPassword($data)
     {

src/Authenticators/SAMLLoginForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * Constructor
      *
-     * @param Controller $controller
+     * @param \SilverStripe\Control\Controller $controller
      * @param string $name method on the $controller
      * @param FieldList $fields
      * @param FieldList $actions

src/Control/LDAPSecurityController.php

Doc Comments +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
     /**
      * Factory method for the lost password form
      *
-     * @return Form Returns the lost password form
+     * @return LDAPSecurityController Returns the lost password form
      */
     public function ChangePasswordForm()
     {
@@ -98,7 +98,7 @@ 
     /**
      * Factory method for the lost password form
      *
-     * @return Form Returns the lost password form
+     * @return LDAPLoginForm Returns the lost password form
      */
     public function LostPasswordForm()
     {
@@ -114,7 +114,7 @@ 
     }
 
     /**
-     * @param null $action
+     * @param string $action
      * @return String
      */
     public function Link($action = null)

src/Control/SAMLController.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
     }
 
     /**
-     * @return SS_HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse|null
      */
     protected function getRedirect()
     {

src/Forms/LDAPChangePasswordForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      * Change the password
      *
      * @param array $data The user submitted data
-     * @return HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse|null
      */
     public function doChangePassword(array $data)
     {

src/Model/LDAPGroupMapping.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     /**
      * {@inheritDoc}
-     * @return FieldList
+     * @return \SilverStripe\Forms\FieldList
      */
     public function getCMSFields()
     {

src/Services/LDAPService.php

Doc Comments +4 added lines, -4 removed lines

@@ -98,7 +98,7 @@ 
      * Get the cache object used for LDAP results. Note that the default lifetime set here
      * is 8 hours, but you can change that by calling Cache::set_lifetime('ldap', <lifetime in seconds>)
      *
-     * @return Zend_Cache_Frontend
+     * @return \Zend_Cache_Core
      */
     public static function get_cache()
     {
@@ -252,7 +252,7 @@ 
      * Note that these get cached in-memory per-request for performance to avoid re-querying for the same results.
      *
      * @param string $dn
-     * @param array $attributes List of specific AD attributes to return. Empty array means return everything.
+     * @param string[] $attributes List of specific AD attributes to return. Empty array means return everything.
      * @return array
      */
     public function getNestedGroups($dn, $attributes = [])
@@ -456,7 +456,7 @@ 
      * @param Member
      * @param array|null $data If passed, this is pre-existing AD attribute data to update the Member with.
      *            If not given, the data will be looked up by the user's GUID.
-     * @return bool
+     * @return false|null
      */
     public function updateMemberFromLDAP(Member $member, $data = null)
     {
@@ -636,7 +636,7 @@ 
      * @param Group $group An existing Group or a new Group object
      * @param array $data LDAP group object data
      *
-     * @return bool
+     * @return false|null
      */
     public function updateGroupFromLDAP(Group $group, $data)
     {